unofficial mirror of bug-guile@gnu.org 
 help / color / mirror / Atom feed
From: Mark H Weaver <mhw@netris.org>
To: Daniel Tam <danooo.tam@gmail.com>
Cc: 32501@debbugs.gnu.org
Subject: bug#32501: Bouncing parentheses broken in REPL with vi-mode enabled
Date: Fri, 24 Aug 2018 01:36:00 -0400	[thread overview]
Message-ID: <87tvnkcon3.fsf@netris.org> (raw)
In-Reply-To: <87pny9by7s.fsf@netris.org> (Mark H. Weaver's message of "Wed, 22 Aug 2018 22:42:15 -0400")

Hello again,

I wrote:

> The relevant function is 'init_bouncing_parens' in
> guile-readline/readline.c:
>
>   static void
>   init_bouncing_parens ()
>   {
>     if (strncmp (rl_get_keymap_name (rl_get_keymap ()), "vi", 2))
>       {
>         rl_bind_key (')', match_paren);
>         rl_bind_key (']', match_paren);
>         rl_bind_key ('}', match_paren);
>       }
>   }

[...]

> The right fix might be to simply remove the 'if' check above.

Actually, it probably won't be that simple.  Whereas in emacs mode, we
can probably rely on these bindings being added to the correct keymap,
namely 'emacs_standard_keymap', when in vi mode it's likely that these
bindings would end up in the wrong keymap, namely 'vi_movement_keymap'.

When in vi mode, these mappings should be added to
'vi_insertion_keymap', and that probably involves using
'rl_bind_key_in_map' instead of 'rl_bind_key'.

       Mark





  parent reply	other threads:[~2018-08-24  5:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-22 15:47 bug#32501: Bouncing parentheses broken in REPL with vi-mode enabled Daniel Tam
2018-08-23  2:42 ` Mark H Weaver
2018-08-23  4:03   ` Mark H Weaver
2018-08-23 16:13     ` John Cowan
2018-08-24  5:36   ` Mark H Weaver [this message]
2018-08-24  6:09     ` Mark H Weaver
2018-08-24 12:42       ` Daniel Tam
2018-08-24 22:11         ` Mark H Weaver
2022-07-11 12:20 ` bug#32501: Bug #32501 - " Sean

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tvnkcon3.fsf@netris.org \
    --to=mhw@netris.org \
    --cc=32501@debbugs.gnu.org \
    --cc=danooo.tam@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).