From: Mark H Weaver <mhw@netris.org>
To: Zefram <zefram@fysh.org>
Cc: 26163-done@debbugs.gnu.org
Subject: bug#26163: time-difference doesn't detect error of differing time types
Date: Sun, 21 Oct 2018 19:45:14 -0400 [thread overview]
Message-ID: <87tvleyid1.fsf@netris.org> (raw)
In-Reply-To: <20170318222336.GJ6518@fysh.org> (Zefram's message of "Sat, 18 Mar 2017 22:23:36 +0000")
Zefram <zefram@fysh.org> writes:
> scheme@(guile-user)> (use-modules (srfi srfi-19))
> scheme@(guile-user)> (time-difference (make-time time-tai 0 1) (make-time time-utc 0 1))
> $1 = #<time type: time-duration nanosecond: 0 second: 0>
>
> SRFI-19 is explicit that it "is an error" if the arguments to
> time-difference are of different time types, and correspondingly the
> Guile documentation says the arguments "must be" of the same type.
> It would be very easy for time-difference to detect and signal this error.
> It's not absolutely a bug that it currently doesn't, but it would be a
> useful improvement if it did.
Agreed. Fixed in commit c9d903b6e4f8cc1d8382b20a2f0502c4ce8ffe0a on the
stable-2.2 branch. I'm closing this bug, but feel free to reopen if
appropriate.
Thanks!
Mark
prev parent reply other threads:[~2018-10-21 23:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-18 22:23 bug#26163: time-difference doesn't detect error of differing time types Zefram
2017-04-19 18:12 ` Zefram
2018-10-21 23:45 ` Mark H Weaver [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tvleyid1.fsf@netris.org \
--to=mhw@netris.org \
--cc=26163-done@debbugs.gnu.org \
--cc=zefram@fysh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).