From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Mark H Weaver Newsgroups: gmane.lisp.guile.bugs Subject: bug#17485: [PATCH 2/3] Rewrite take-right, drop-right, drop-right! Date: Tue, 03 Jun 2014 23:45:54 -0400 Message-ID: <87sinltk0d.fsf@yeeloong.lan> References: <1401821778-19972-1-git-send-email-dak@gnu.org> <1401821778-19972-2-git-send-email-dak@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1401853646 32320 80.91.229.3 (4 Jun 2014 03:47:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 4 Jun 2014 03:47:26 +0000 (UTC) Cc: 17485@debbugs.gnu.org To: David Kastrup Original-X-From: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Wed Jun 04 05:47:17 2014 Return-path: Envelope-to: guile-bugs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Ws2AX-0006Jy-Aq for guile-bugs@m.gmane.org; Wed, 04 Jun 2014 05:47:17 +0200 Original-Received: from localhost ([::1]:57046 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ws2AX-0007AL-0Q for guile-bugs@m.gmane.org; Tue, 03 Jun 2014 23:47:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60703) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ws2AO-00079E-TA for bug-guile@gnu.org; Tue, 03 Jun 2014 23:47:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ws2AI-0006wZ-HE for bug-guile@gnu.org; Tue, 03 Jun 2014 23:47:08 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:44031) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ws2AI-0006wS-ET for bug-guile@gnu.org; Tue, 03 Jun 2014 23:47:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Ws2AI-0007rJ-0q for bug-guile@gnu.org; Tue, 03 Jun 2014 23:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mark H Weaver Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Wed, 04 Jun 2014 03:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17485 X-GNU-PR-Package: guile X-GNU-PR-Keywords: Original-Received: via spool by 17485-submit@debbugs.gnu.org id=B17485.140185358030131 (code B ref 17485); Wed, 04 Jun 2014 03:47:01 +0000 Original-Received: (at 17485) by debbugs.gnu.org; 4 Jun 2014 03:46:20 +0000 Original-Received: from localhost ([127.0.0.1]:42908 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ws29b-0007pu-HU for submit@debbugs.gnu.org; Tue, 03 Jun 2014 23:46:20 -0400 Original-Received: from world.peace.net ([96.39.62.75]:50671 ident=hope4) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ws29V-0007pZ-5X for 17485@debbugs.gnu.org; Tue, 03 Jun 2014 23:46:17 -0400 Original-Received: from 209-6-91-212.c3-0.smr-ubr1.sbo-smr.ma.cable.rcn.com ([209.6.91.212] helo=yeeloong.lan) by world.peace.net with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1Ws29N-0000z4-Vl; Tue, 03 Jun 2014 23:46:06 -0400 In-Reply-To: <1401821778-19972-2-git-send-email-dak@gnu.org> (David Kastrup's message of "Tue, 3 Jun 2014 20:56:17 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Original-Sender: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.bugs:7490 Archived-At: David Kastrup writes: > * module/srfi/srfi-1.scm (take-right, drop-right, drop-right!): The > definitions tended to be overly complicate and/or rely on pushing > material on the VM stack, detrimental to scalability for Guile 2.0 and > also worse for performance. > > The changed definitions lead to different, more accurate exceptions > being raised. They rely on length+ returning the length of dotted > lists, behavior that is not specified by the SRFI-1 definition but > available in GUILE. I forgot to mention that, again, the commit log should not contain rationales, but merely summarize the changes made. Thanks, Mark