From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andy Wingo Newsgroups: gmane.lisp.guile.bugs Subject: bug#21902: reviewer for time-related bugs (srfi-19) Date: Sat, 25 Jun 2016 11:36:48 +0200 Message-ID: <87r3blboen.fsf_-___14073.1744039387$1466847459$gmane$org@pobox.com> References: <20151113125813.GM13455@fysh.org> <87eg7mcxgb.fsf@pobox.com> <20160624180143.GI1170@fysh.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1466847459 12283 80.91.229.3 (25 Jun 2016 09:37:39 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 25 Jun 2016 09:37:39 +0000 (UTC) Cc: 21902@debbugs.gnu.org To: Zefram , guile-devel@gnu.org Original-X-From: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Sat Jun 25 11:37:26 2016 Return-path: Envelope-to: guile-bugs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bGk1l-00075C-3R for guile-bugs@m.gmane.org; Sat, 25 Jun 2016 11:37:25 +0200 Original-Received: from localhost ([::1]:49141 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGk1k-0004Bb-72 for guile-bugs@m.gmane.org; Sat, 25 Jun 2016 05:37:24 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51732) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGk1Q-00043S-IX for bug-guile@gnu.org; Sat, 25 Jun 2016 05:37:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bGk1O-0003EK-8U for bug-guile@gnu.org; Sat, 25 Jun 2016 05:37:03 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:42555) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGk1O-0003EG-5H for bug-guile@gnu.org; Sat, 25 Jun 2016 05:37:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bGk1O-0004Vx-0p for bug-guile@gnu.org; Sat, 25 Jun 2016 05:37:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andy Wingo Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Sat, 25 Jun 2016 09:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21902 X-GNU-PR-Package: guile X-GNU-PR-Keywords: Original-Received: via spool by 21902-submit@debbugs.gnu.org id=B21902.146684742117350 (code B ref 21902); Sat, 25 Jun 2016 09:37:01 +0000 Original-Received: (at 21902) by debbugs.gnu.org; 25 Jun 2016 09:37:01 +0000 Original-Received: from localhost ([127.0.0.1]:54892 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bGk1N-0004Vi-5F for submit@debbugs.gnu.org; Sat, 25 Jun 2016 05:37:01 -0400 Original-Received: from pb-sasl1.pobox.com ([64.147.108.66]:55225 helo=sasl.smtp.pobox.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bGk1K-0004VY-AN for 21902@debbugs.gnu.org; Sat, 25 Jun 2016 05:36:59 -0400 Original-Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by pb-sasl1.pobox.com (Postfix) with ESMTP id C345417B1F; Sat, 25 Jun 2016 05:36:56 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=Lvp99Nb22v3No+89DBpVGIWjDCQ=; b=b0berW z1T/3TUfsn5WxF+YCzdeJS2dhWeaJ+BJNE/O2WFUhEPQ0xjfJz4pVlb4TgPASPPW IL13WC0CgwO3z9DYkIyb6lXhbx49UW2HUVB2OZvBvX2jCvROpGeKf6B7GdqDqmcL VLH9DtwZxmtHUhvJHZxZMawKZP5jxfE/c25/A= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=n6iewB/ygphsnR8wpoOnxkmEa8ElqIgF NtVUE3sqJFQ65Hjd1OSFrxrlfGLmWW+4MmGvztT8X2z3aBkutCJA7McsHpoa1Amd cm3WdZp0Kk9ZIfuL6oJl2+kp39UX1qFGD4OTEvkNVizWtmMAWkM3yjddcf8rqmgL XmNv/sYILrw= Original-Received: from pb-sasl1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-sasl1.pobox.com (Postfix) with ESMTP id A85D017B1D; Sat, 25 Jun 2016 05:36:56 -0400 (EDT) Original-Received: from clucks (unknown [88.160.190.192]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by pb-sasl1.pobox.com (Postfix) with ESMTPSA id CD57F17B1B; Sat, 25 Jun 2016 05:36:55 -0400 (EDT) In-Reply-To: <20160624180143.GI1170@fysh.org> (zefram@fysh.org's message of "Fri, 24 Jun 2016 19:01:43 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) X-Pobox-Relay-ID: 5B2FF9DC-3AB8-11E6-BCA8-C1836462E9F6-02397024!pb-sasl1.pobox.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Original-Sender: "bug-guile" Xref: news.gmane.org gmane.lisp.guile.bugs:8247 Archived-At: Thanks, that's great :) For this and the other time-related bugs it sounds like you know what you're doing but I would like someone to check the work just to make sure we're not introducing new errors. To that end, I ask guile-devel, in this top-post so that people will see it :), for a volunteer! Are you a person who is interested in the specifics of time representation? TAI, UTC, and all that? If so your input is very much appreciated on the patch quoted below from bug 21902, and also on these other bugs: https://debbugs.gnu.org/21902 doc incorrectly describes Julian Date https://debbugs.gnu.org/21903 date->string duff ISO 8601 negative years https://debbugs.gnu.org/21904 date->string duff ISO 8601 format for non-4-digit years https://debbugs.gnu.org/21906 julian-day->date negative input breakage https://debbugs.gnu.org/21907 date->string duff ISO 8601 zone format https://debbugs.gnu.org/21911 TAI-to-UTC conversion leaps at wrong time https://debbugs.gnu.org/21912 TAI<->UTC conversion botches the unknown https://debbugs.gnu.org/22033 time-utc format is lossy https://debbugs.gnu.org/22034 time-utc->date shows bogus zone-dependent leap second To give feedback is very easy. The first thing is to confirm the bug report: does it make sense to you? If you or Zefram comes up with a patch to fix the issue, as below, that's even better of course, but already just a confirmation of the bug would be great. To comment on the bug, just send a mail to NNNN@debbugs.gnu.org, where NNNN is the bug number. Super easy. Cheers, and thanks in advance! Andy On Fri 24 Jun 2016 20:01, Zefram writes: > Andy Wingo wrote: >>Would you like to propose a specific patch to the documentation? > > Sure. Patch attached. > > -zefram > > --- a/doc/ref/srfi-modules.texi 2014-03-20 20:21:21.000000000 +0000 > +++ b/doc/ref/srfi-modules.texi 2016-06-24 18:57:59.088243245 +0100 > @@ -2461,8 +2461,8 @@ > @cindex UTC > @cindex TAI > This module implements time and date representations and calculations, > -in various time systems, including universal time (UTC) and atomic > -time (TAI). > +in various time systems, including Coordinated Universal Time (UTC) > +and International Atomic Time (TAI). > > For those not familiar with these time systems, TAI is based on a > fixed length second derived from oscillations of certain atoms. UTC > @@ -2494,18 +2494,12 @@ > @cindex julian day > @cindex modified julian day > Also, for those not familiar with the terminology, a @dfn{Julian Day} > -is a real number which is a count of days and fraction of a day, in > -UTC, starting from -4713-01-01T12:00:00Z, ie.@: midday Monday 1 Jan > -4713 B.C. A @dfn{Modified Julian Day} is the same, but starting from > -1858-11-17T00:00:00Z, ie.@: midnight 17 November 1858 UTC. That time > -is julian day 2400000.5. > - > -@c The SRFI-1 spec says -4714-11-24T12:00:00Z (November 24, -4714 at > -@c noon, UTC), but this is incorrect. It looks like it might have > -@c arisen from the code incorrectly treating years a multiple of 100 > -@c but not 400 prior to 1582 as non-leap years, where instead the Julian > -@c calendar should be used so all multiples of 4 before 1582 are leap > -@c years. > +is a real number which is a count of days and fraction of a day, in UT, > +starting from -4713-11-24T12:00:00Z, ie.@: midday UT on Monday 24 November > +4714 BC in the proleptic Gregorian calendar (1 January 4713 BC in the > +proleptic Julian calendar). A @dfn{Modified Julian Day} is the same, > +but starting from 1858-11-17T00:00:00Z, ie.@: midnight UT on Wednesday > +17 November AD 1858. That time is julian day 2400000.5. > > > @node SRFI-19 Time