From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Newsgroups: gmane.lisp.guile.bugs Subject: bug#59321: ice-9's open-input-pipe is unexpectedly slow on some systems Date: Sun, 20 Nov 2022 18:24:57 +0100 Message-ID: <87r0xx5yja.fsf@gnu.org> References: <8d55cf7d1e5382c874cfcaee1f4cddd3@posteo.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15638"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Cc: hylophile@posteo.de, 59321@debbugs.gnu.org To: Andrew Whatson Original-X-From: bug-guile-bounces+guile-bugs=m.gmane-mx.org@gnu.org Sun Nov 20 18:26:15 2022 Return-path: Envelope-to: guile-bugs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1owo59-0003sR-K0 for guile-bugs@m.gmane-mx.org; Sun, 20 Nov 2022 18:26:15 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1owo4x-0002M3-Vu; Sun, 20 Nov 2022 12:26:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1owo4w-0002L5-KM for bug-guile@gnu.org; Sun, 20 Nov 2022 12:26:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1owo4w-0007tE-99 for bug-guile@gnu.org; Sun, 20 Nov 2022 12:26:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1owo4w-0002Xf-5Q for bug-guile@gnu.org; Sun, 20 Nov 2022 12:26:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Sun, 20 Nov 2022 17:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59321 X-GNU-PR-Package: guile Original-Received: via spool by 59321-submit@debbugs.gnu.org id=B59321.16689651079701 (code B ref 59321); Sun, 20 Nov 2022 17:26:02 +0000 Original-Received: (at 59321) by debbugs.gnu.org; 20 Nov 2022 17:25:07 +0000 Original-Received: from localhost ([127.0.0.1]:44461 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1owo42-0002WP-Rk for submit@debbugs.gnu.org; Sun, 20 Nov 2022 12:25:07 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:38526) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1owo41-0002VL-IL for 59321@debbugs.gnu.org; Sun, 20 Nov 2022 12:25:06 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1owo3w-0007Ua-8s; Sun, 20 Nov 2022 12:25:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=VECu9CtbGGfcWDVFEtiqSfN+IqwGvLvXiONCC45XmHw=; b=FP2dRBru/n65hdg1xcKR C39LCbUlFp7gChgHXfEGWpUZmUhfa0+e6bo5PVGewRx4BLdgZLmjWnZ98CYiWaE+gS+MOiCn+UX9b FEGW7FXCvn3GQDtaf1FGzxn09RBwQydZQRQYDN4/ZKQhcDo1yQVda7EQFUTN470WyLZy4HuoGJ20Q jMz9guP1Ov4QjgW8eNts7Ryx/tXOkzDBjuABv6HZLKiHJzUSxYnk3msMot6U9BBdrJcKYTXQ3e9YL 7yvDQCjBzo4VyYlZaZYIuyh5ZXHbzjefv2gHdsjHGdnr34RlSEfqAE5ifUTwF2MOcul0CGHheqxxL 8FfGdEYn0aS38A==; Original-Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1owo3v-0002PR-TF; Sun, 20 Nov 2022 12:25:00 -0500 In-Reply-To: (Andrew Whatson's message of "Fri, 18 Nov 2022 14:49:05 +1000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guile-bounces+guile-bugs=m.gmane-mx.org@gnu.org Original-Sender: bug-guile-bounces+guile-bugs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.lisp.guile.bugs:10439 Archived-At: Hi, Andrew Whatson skribis: > Forcibly closing file descriptors like this shouldn't be necessary if > the application has properly opened descriptors with the FD_CLOEXEC > flag. It would be good to get input from some more experienced Guile > hackers on the potential consequences of this change. Libguile opens all its own file descriptors at O_CLOEXEC (one omission was recently fixed in 0aa1a9976fc3c6af4d1087e59d728cb8fe7d369a) so it may be possible to remove that FD-closing loop. There=E2=80=99s still the possibility that application bug unwillingly leaks FDs, but we could consider it=E2=80=99s none of our business. Thoughts? Similarly, with commit a356ceebee000efe91a2a16dbcaa64d6c6a3a922, it=E2=80= =99s possible to pass =E2=80=98open-file=E2=80=99 a flag that corresponds to O_C= LOEXEC, which wasn=E2=80=99t possible before. I=E2=80=99ve also been thinking that files= opened with =E2=80=98call-with-*=E2=80=99 should be O_CLOEXEC. That=E2=80=99d be an in= compatible change though, so maybe not something for 3.0.x. Ludo=E2=80=99.