* bug#10684: guile-2.0.5 test failures on powerpc-darwin8
@ 2012-01-31 22:51 David Fang
2012-02-01 22:36 ` Ludovic Courtès
0 siblings, 1 reply; 13+ messages in thread
From: David Fang @ 2012-01-31 22:51 UTC (permalink / raw)
To: 10684
[-- Attachment #1: Type: TEXT/PLAIN, Size: 1349 bytes --]
Using the fink packaging that I maintain for guile:
http://fink.cvs.sf.net/viewvc/fink/experimental/fangism/finkinfo/guile20.info?revision=1.15&view=markup
I get a few test failures on powerpc-darwin8, complete test log:
http://paste.lisp.org/display/127426
FAIL: i18n.test: character mapping: char-locale-upcase Turkish
FAIL: i18n.test: character mapping: char-locale-downcase Turkish
FAIL: i18n.test: string mapping: string-locale-upcase Turkish
FAIL: i18n.test: string mapping: string-locale-downcase Turkish
FAIL: net-db.test: getaddrinfo: wrong service name
ERROR: regexp.test: regexp-quote: regexp/extended: (char 254 #\þ "þ") -
arguments: ((regular-expression-syntax "make-regexp" "empty
(sub)expression" #f ("þ")))
FAIL: regexp.test: regexp-quote: regexp/extended: (string "aX" 254 #\þ
"aþ" "aþ")
FAIL: regexp.test: regexp-quote: regexp/extended: string of all chars
Totals for this test run:
passes: 34818
failures: 7
unexpected passes: 0
expected failures: 30
unresolved test cases: 37
untested test cases: 1
unsupported test cases: 15
errors: 1
Most of these failures are not new and have been around a while.
Let me know what other information I can provide about these tests in my
build environment.
Thanks for guile!
Fang
^ permalink raw reply [flat|nested] 13+ messages in thread
* bug#10684: guile-2.0.5 test failures on powerpc-darwin8
2012-01-31 22:51 bug#10684: guile-2.0.5 test failures on powerpc-darwin8 David Fang
@ 2012-02-01 22:36 ` Ludovic Courtès
2012-02-01 22:56 ` David Fang
0 siblings, 1 reply; 13+ messages in thread
From: Ludovic Courtès @ 2012-02-01 22:36 UTC (permalink / raw)
To: David Fang; +Cc: 10684
Hi David,
David Fang <fang@csl.cornell.edu> skribis:
> FAIL: i18n.test: character mapping: char-locale-upcase Turkish
> FAIL: i18n.test: character mapping: char-locale-downcase Turkish
> FAIL: i18n.test: string mapping: string-locale-upcase Turkish
> FAIL: i18n.test: string mapping: string-locale-downcase Turkish
This most likely indicates that Darwin 8 has incorrect case mapping data
for the Turkish locale.
Can you try this (in a UTF-8 terminal):
(use-modules (ice-9 i18n))
(setlocale LC_ALL "tr_TR.UTF-8")
(char-locale-upcase #\i)
> FAIL: net-db.test: getaddrinfo: wrong service name
Can you try this:
(getaddrinfo "127.0.0.1" "does-not-exist" AI_NUMERICHOST)
> ERROR: regexp.test: regexp-quote: regexp/extended: (char 254 #\þ
> "þ") -
> arguments: ((regular-expression-syntax "make-regexp" "empty
> (sub)expression" #f ("þ")))
Hm?
> FAIL: regexp.test: regexp-quote: regexp/extended: (string "aX" 254
> #\þ "aþ" "aþ")
> FAIL: regexp.test: regexp-quote: regexp/extended: string of all chars
Can you try:
(setlocale LC_ALL "en_US.ISO-8859-1") ;; or some other ISO-8859-1 locale
(let* ((s (string (integer->char 254)))
(q (regexp-quote s)))
(regexp-exec (make-regexp q regexp/extended) s))
Thanks,
Ludo’.
^ permalink raw reply [flat|nested] 13+ messages in thread
* bug#10684: guile-2.0.5 test failures on powerpc-darwin8
2012-02-01 22:36 ` Ludovic Courtès
@ 2012-02-01 22:56 ` David Fang
2012-02-02 21:58 ` Ludovic Courtès
0 siblings, 1 reply; 13+ messages in thread
From: David Fang @ 2012-02-01 22:56 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: 10684
[-- Attachment #1: Type: TEXT/PLAIN, Size: 3040 bytes --]
> Hi David,
>
> David Fang <fang@csl.cornell.edu> skribis:
>
>> FAIL: i18n.test: character mapping: char-locale-upcase Turkish
>> FAIL: i18n.test: character mapping: char-locale-downcase Turkish
>> FAIL: i18n.test: string mapping: string-locale-upcase Turkish
>> FAIL: i18n.test: string mapping: string-locale-downcase Turkish
>
> This most likely indicates that Darwin 8 has incorrect case mapping data
> for the Turkish locale.
>
> Can you try this (in a UTF-8 terminal):
>
> (use-modules (ice-9 i18n))
> (setlocale LC_ALL "tr_TR.UTF-8")
> (char-locale-upcase #\i)
fang% guile-2.0
GNU Guile 2.0.5
Copyright (C) 1995-2012 Free Software Foundation, Inc.
Guile comes with ABSOLUTELY NO WARRANTY; for details type `,show w'.
This program is free software, and you are welcome to redistribute it
under certain conditions; type `,show c' for details.
Enter `,help' for help.
scheme@(guile-user)> (use-modules (ice-9 i18n))
scheme@(guile-user)> (setlocale LC_ALL "tr_TR.UTF-8")
$1 = "tr_TR.UTF-8"
scheme@(guile-user)> (char-locale-upcase #\i)
$2 = #\I
scheme@(guile-user)>
Does that look right?
>> FAIL: net-db.test: getaddrinfo: wrong service name
>
> Can you try this:
>
> (getaddrinfo "127.0.0.1" "does-not-exist" AI_NUMERICHOST)
scheme@(guile-user)> (getaddrinfo "127.0.0.1" "does-not-exist"
AI_NUMERICHOST)
ERROR: In procedure getaddrinfo:
ERROR: In procedure getaddrinfo: No address associated with nodename
Entering a new prompt. Type `,bt' for a backtrace or `,q' to continue.
>> ERROR: regexp.test: regexp-quote: regexp/extended: (char 254 #\þ
>> "þ") -
>> arguments: ((regular-expression-syntax "make-regexp" "empty
>> (sub)expression" #f ("þ")))
>
> Hm?
>
>> FAIL: regexp.test: regexp-quote: regexp/extended: (string "aX" 254
>> #\þ "aþ" "aþ")
>> FAIL: regexp.test: regexp-quote: regexp/extended: string of all chars
>
> Can you try:
>
> (setlocale LC_ALL "en_US.ISO-8859-1") ;; or some other ISO-8859-1 locale
> (let* ((s (string (integer->char 254)))
> (q (regexp-quote s)))
> (regexp-exec (make-regexp q regexp/extended) s))
scheme@(guile-user)> (setlocale LC_ALL "en_US.ISO-8859-1")
ERROR: In procedure setlocale:
ERROR: In procedure setlocale: Invalid argument
Entering a new prompt. Type `,bt' for a backtrace or `,q' to continue.
scheme@(guile-user)> (setlocale LC_ALL "en_US.ISO8859-1")
$1 = "en_US.ISO8859-1"
scheme@(guile-user)> (let* ((s (string (integer->char 254))) (q
(regexp-quote s))) (regexp-exec (make-regexp q regexp/extended) s))
ERROR: In procedure make-regexp:
ERROR: In procedure make-regexp: empty (sub)expression
Entering a new prompt. Type `,bt' for a backtrace or `,q' to continue.
I have (on darwin8):
fang% locale -a | grep 8859 | grep en
en_AU.ISO8859-1
en_AU.ISO8859-15
en_CA.ISO8859-1
en_CA.ISO8859-15
en_GB.ISO8859-1
en_GB.ISO8859-15
en_NZ.ISO8859-1
en_NZ.ISO8859-15
en_US.ISO8859-1
en_US.ISO8859-15
Fang
--
David Fang
http://www.csl.cornell.edu/~fang/
^ permalink raw reply [flat|nested] 13+ messages in thread
* bug#10684: guile-2.0.5 test failures on powerpc-darwin8
2012-02-01 22:56 ` David Fang
@ 2012-02-02 21:58 ` Ludovic Courtès
2012-02-02 22:50 ` David Fang
2012-02-03 16:02 ` Ludovic Courtès
0 siblings, 2 replies; 13+ messages in thread
From: Ludovic Courtès @ 2012-02-02 21:58 UTC (permalink / raw)
To: David Fang; +Cc: 10684
[-- Attachment #1: Type: text/plain, Size: 1103 bytes --]
Hi David,
David Fang <fang@csl.cornell.edu> skribis:
>> Can you try this (in a UTF-8 terminal):
>>
>> (use-modules (ice-9 i18n))
>> (setlocale LC_ALL "tr_TR.UTF-8")
>> (char-locale-upcase #\i)
[...]
> scheme@(guile-user)> (use-modules (ice-9 i18n))
> scheme@(guile-user)> (setlocale LC_ALL "tr_TR.UTF-8")
> $1 = "tr_TR.UTF-8"
> scheme@(guile-user)> (char-locale-upcase #\i)
> $2 = #\I
> scheme@(guile-user)>
>
> Does that look right?
No, it should be İ, so it means that this version of Darwin has invalid
Turkish locale data.
Can show what %host-type is on your system? I’ll add an exception to
skip these tests on this platform.
>>> FAIL: net-db.test: getaddrinfo: wrong service name
>>
>> Can you try this:
>>
>> (getaddrinfo "127.0.0.1" "does-not-exist" AI_NUMERICHOST)
>
> scheme@(guile-user)> (getaddrinfo "127.0.0.1" "does-not-exist"
> AI_NUMERICHOST)
> ERROR: In procedure getaddrinfo:
> ERROR: In procedure getaddrinfo: No address associated with nodename
Can you apply this patch, run ‘./check-guile net-db.test’, and report
back?
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 633 bytes --]
diff --git a/test-suite/tests/net-db.test b/test-suite/tests/net-db.test
index 89ebb1b..8b14a92 100644
--- a/test-suite/tests/net-db.test
+++ b/test-suite/tests/net-db.test
@@ -102,5 +102,7 @@
;; According to POSIX, both error codes are valid (glibc 2.11
;; chooses `EAI_SERVICE'; Darwin chooses `EAI_NONAME'.)
(and (or (= errcode EAI_SERVICE)
- (= errcode EAI_NONAME))
+ (= errcode EAI_NONAME)
+ (and (defined? 'EAI_NODATA)
+ (= errcode EAI_NODATA)))
(string? (gai-strerror errcode))))))))
[-- Attachment #3: Type: text/plain, Size: 1313 bytes --]
> Entering a new prompt. Type `,bt' for a backtrace or `,q' to continue.
>
>
>>> ERROR: regexp.test: regexp-quote: regexp/extended: (char 254 #\þ
>>> "þ") -
>>> arguments: ((regular-expression-syntax "make-regexp" "empty
>>> (sub)expression" #f ("þ")))
>>
>> Hm?
>>
>>> FAIL: regexp.test: regexp-quote: regexp/extended: (string "aX" 254
>>> #\þ "aþ" "aþ")
>>> FAIL: regexp.test: regexp-quote: regexp/extended: string of all chars
>>
>> Can you try:
>>
>> (setlocale LC_ALL "en_US.ISO-8859-1") ;; or some other ISO-8859-1 locale
>> (let* ((s (string (integer->char 254)))
>> (q (regexp-quote s)))
>> (regexp-exec (make-regexp q regexp/extended) s))
[...]
> scheme@(guile-user)> (setlocale LC_ALL "en_US.ISO8859-1")
> $1 = "en_US.ISO8859-1"
> scheme@(guile-user)> (let* ((s (string (integer->char 254))) (q
> (regexp-quote s))) (regexp-exec (make-regexp q regexp/extended) s))
> ERROR: In procedure make-regexp:
> ERROR: In procedure make-regexp: empty (sub)expression
This looks like a bug of Darwin’s regcomp that’s likely to be solved by
using Gnulib’s ‘regex’ module. If you don’t mind, I’ll provide you
with a new tarball to test when we’re done with the other issues.
Thanks for your patient investigation!
Ludo’.
^ permalink raw reply related [flat|nested] 13+ messages in thread
* bug#10684: guile-2.0.5 test failures on powerpc-darwin8
2012-02-02 21:58 ` Ludovic Courtès
@ 2012-02-02 22:50 ` David Fang
2012-02-03 16:02 ` Ludovic Courtès
1 sibling, 0 replies; 13+ messages in thread
From: David Fang @ 2012-02-02 22:50 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: 10684
[-- Attachment #1: Type: TEXT/PLAIN, Size: 1906 bytes --]
Hi,
Answers below.
> David Fang <fang@csl.cornell.edu> skribis:
>
>>> Can you try this (in a UTF-8 terminal):
>>>
>>> (use-modules (ice-9 i18n))
>>> (setlocale LC_ALL "tr_TR.UTF-8")
>>> (char-locale-upcase #\i)
>
> [...]
>
>> scheme@(guile-user)> (use-modules (ice-9 i18n))
>> scheme@(guile-user)> (setlocale LC_ALL "tr_TR.UTF-8")
>> $1 = "tr_TR.UTF-8"
>> scheme@(guile-user)> (char-locale-upcase #\i)
>> $2 = #\I
>> scheme@(guile-user)>
>>
>> Does that look right?
>
> No, it should be ÿÿ, so it means that this version of Darwin has invalid
> Turkish locale data.
>
> Can show what %host-type is on your system? Iÿÿll add an exception to
> skip these tests on this platform.
scheme@(guile-user)> %host-type
$1 = "powerpc-apple-darwin8.11.0"
>>>> FAIL: net-db.test: getaddrinfo: wrong service name
>>>
>>> Can you try this:
>>>
>>> (getaddrinfo "127.0.0.1" "does-not-exist" AI_NUMERICHOST)
>>
>> scheme@(guile-user)> (getaddrinfo "127.0.0.1" "does-not-exist"
>> AI_NUMERICHOST)
>> ERROR: In procedure getaddrinfo:
>> ERROR: In procedure getaddrinfo: No address associated with nodename
>
> Can you apply this patch, run ÿÿ./check-guile net-db.testÿÿ, and report
> back?
Looks better:
[fangism:guile20-2.0.5-0/guile-2.0.5/build] fang% ./check-guile net-db.test
Testing /Volumes/Mercedes2/sw/src/fink.build/guile20-2.0.5-0/guile-2.0.5/build/meta/guile
... net-db.test
with GUILE_LOAD_PATH=/Volumes/Mercedes2/sw/src/fink.build/guile20-2.0.5-0/guile-2.0.5/test-suite
Running net-db.test
Totals for this test run:
passes: 6
failures: 0
unexpected passes: 0
expected failures: 0
unresolved test cases: 0
untested test cases: 0
unsupported test cases: 0
errors: 0
Thanks for the proposed fixes/workarounds!
Fang
--
David Fang
http://www.csl.cornell.edu/~fang/
^ permalink raw reply [flat|nested] 13+ messages in thread
* bug#10684: guile-2.0.5 test failures on powerpc-darwin8
2012-02-02 21:58 ` Ludovic Courtès
2012-02-02 22:50 ` David Fang
@ 2012-02-03 16:02 ` Ludovic Courtès
2012-02-04 1:58 ` David Fang
1 sibling, 1 reply; 13+ messages in thread
From: Ludovic Courtès @ 2012-02-03 16:02 UTC (permalink / raw)
To: David Fang; +Cc: 10684
Hi David,
ludo@gnu.org (Ludovic Courtès) skribis:
>>> Can you try:
>>>
>>> (setlocale LC_ALL "en_US.ISO-8859-1") ;; or some other ISO-8859-1 locale
>>> (let* ((s (string (integer->char 254)))
>>> (q (regexp-quote s)))
>>> (regexp-exec (make-regexp q regexp/extended) s))
>
> [...]
>
>> scheme@(guile-user)> (setlocale LC_ALL "en_US.ISO8859-1")
>> $1 = "en_US.ISO8859-1"
>> scheme@(guile-user)> (let* ((s (string (integer->char 254))) (q
>> (regexp-quote s))) (regexp-exec (make-regexp q regexp/extended) s))
>> ERROR: In procedure make-regexp:
>> ERROR: In procedure make-regexp: empty (sub)expression
>
> This looks like a bug of Darwin’s regcomp that’s likely to be solved by
> using Gnulib’s ‘regex’ module. If you don’t mind, I’ll provide you
> with a new tarball to test when we’re done with the other issues.
Guile now uses Gnulib’s regex module. Can you try again with the
tarball from
<http://hydra.nixos.org/job/gnu/guile-2-0/tarball/latest/download-by-type/file/source-dist>?
Thanks,
Ludo’.
^ permalink raw reply [flat|nested] 13+ messages in thread
* bug#10684: guile-2.0.5 test failures on powerpc-darwin8
2012-02-03 16:02 ` Ludovic Courtès
@ 2012-02-04 1:58 ` David Fang
2012-02-04 11:04 ` Ludovic Courtès
0 siblings, 1 reply; 13+ messages in thread
From: David Fang @ 2012-02-04 1:58 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: 10684
[-- Attachment #1: Type: TEXT/PLAIN, Size: 601 bytes --]
>> This looks like a bug of Darwinÿÿs regcomp thatÿÿs likely to be solved by
>> using Gnulibÿÿs ÿÿregexÿÿ module. If you donÿÿt mind, Iÿÿll provide you
>> with a new tarball to test when weÿÿre done with the other issues.
>
> Guile now uses Gnulibÿÿs regex module. Can you try again with the
> tarball from
> <http://hydra.nixos.org/job/gnu/guile-2-0/tarball/latest/download-by-type/file/source-dist>?
Ludovic,
Updated results look better:
http://paste.lisp.org/display/127426#1
Only one failure:
FAIL: i18n.test: format ~h: English: 12345.5678
Thanks a lot for fixing!
Fang
^ permalink raw reply [flat|nested] 13+ messages in thread
* bug#10684: guile-2.0.5 test failures on powerpc-darwin8
2012-02-04 1:58 ` David Fang
@ 2012-02-04 11:04 ` Ludovic Courtès
2012-02-04 19:56 ` David Fang
0 siblings, 1 reply; 13+ messages in thread
From: Ludovic Courtès @ 2012-02-04 11:04 UTC (permalink / raw)
To: David Fang; +Cc: 10684
Hi,
David Fang <fang@csl.cornell.edu> skribis:
> Updated results look better:
Good. :-)
> Only one failure:
> FAIL: i18n.test: format ~h: English: 12345.5678
Yes, that’s a new feature, and a new regression. ;-)
Can you try:
(use-modules (ice-9 format))
(setlocale LC_ALL "en_US")
(format #f "~h" 12345.5678)
and:
(use-modules (ice-9 i18n))
(setlocale LC_ALL "en_US")
(locale-decimal-point)
(locale-thousands-separator)
Thanks,
Ludo’.
^ permalink raw reply [flat|nested] 13+ messages in thread
* bug#10684: guile-2.0.5 test failures on powerpc-darwin8
2012-02-04 11:04 ` Ludovic Courtès
@ 2012-02-04 19:56 ` David Fang
2012-02-04 20:10 ` Stefan Israelsson Tampe
0 siblings, 1 reply; 13+ messages in thread
From: David Fang @ 2012-02-04 19:56 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: 10684
[-- Attachment #1: Type: TEXT/PLAIN, Size: 1675 bytes --]
>> FAIL: i18n.test: format ~h: English: 12345.5678
>
> Yes, thatÿÿs a new feature, and a new regression. ;-)
> Can you try:
>
> (use-modules (ice-9 format))
> (setlocale LC_ALL "en_US")
> (format #f "~h" 12345.5678)
[fangism:guile20-2.0.5.24-e7f7-0/guile-2.0.5.24-e7f7/build] fang%
meta/guile
GNU Guile 2.0.5.24-e7f7
Copyright (C) 1995-2012 Free Software Foundation, Inc.
Guile comes with ABSOLUTELY NO WARRANTY; for details type `,show w'.
This program is free software, and you are welcome to redistribute it
under certain conditions; type `,show c' for details.
Enter `,help' for help.
scheme@(guile-user)> (use-modules (ice-9 format))
scheme@(guile-user)> (setlocale LC_ALL "en_US")
$1 = "en_US"
scheme@(guile-user)> (format #f "~" 12345.5678)
;;; <stdin>:3:0: warning: "~": wrong number of `format' arguments:
expected 0, got 1
$2 = "~"
> (use-modules (ice-9 i18n))
> (setlocale LC_ALL "en_US")
> (locale-decimal-point)
> (locale-thousands-separator)
[fangism:guile20-2.0.5.24-e7f7-0/guile-2.0.5.24-e7f7/build] fang%
meta/guile
GNU Guile 2.0.5.24-e7f7
Copyright (C) 1995-2012 Free Software Foundation, Inc.
Guile comes with ABSOLUTELY NO WARRANTY; for details type `,show w'.
This program is free software, and you are welcome to redistribute it
under certain conditions; type `,show c' for details.
Enter `,help' for help.
scheme@(guile-user)> (use-modules (ice-9 i18n))
scheme@(guile-user)> (setlocale LC_ALL "en_US")
$1 = "en_US"
scheme@(guile-user)> (locale-decimal-point)
$2 = "."
scheme@(guile-user)> (locale-thousands-separator)
$3 = ","
--
David Fang
http://www.csl.cornell.edu/~fang/
^ permalink raw reply [flat|nested] 13+ messages in thread
* bug#10684: guile-2.0.5 test failures on powerpc-darwin8
2012-02-04 19:56 ` David Fang
@ 2012-02-04 20:10 ` Stefan Israelsson Tampe
2012-02-04 20:49 ` David Fang
0 siblings, 1 reply; 13+ messages in thread
From: Stefan Israelsson Tampe @ 2012-02-04 20:10 UTC (permalink / raw)
To: David Fang; +Cc: Ludovic Courtès, 10684
[-- Attachment #1: Type: text/plain, Size: 2040 bytes --]
You forgot h in the format expression
asked for,
(format #f "~h" 12345.5678)
you wrote,
(format #f "~" 12345.5678)
/Stefan
On Sat, Feb 4, 2012 at 8:56 PM, David Fang <fang@csl.cornell.edu> wrote:
> FAIL: i18n.test: format ~h: English: 12345.5678
>>>
>>
>> Yes, thatÿÿs a new feature, and a new regression. ;-)
>> Can you try:
>>
>> (use-modules (ice-9 format))
>> (setlocale LC_ALL "en_US")
>> (format #f "~h" 12345.5678)
>>
>
> [fangism:guile20-2.0.5.24-**e7f7-0/guile-2.0.5.24-e7f7/**build] fang%
> meta/guile
> GNU Guile 2.0.5.24-e7f7
> Copyright (C) 1995-2012 Free Software Foundation, Inc.
>
> Guile comes with ABSOLUTELY NO WARRANTY; for details type `,show w'.
> This program is free software, and you are welcome to redistribute it
> under certain conditions; type `,show c' for details.
>
> Enter `,help' for help.
> scheme@(guile-user)> (use-modules (ice-9 format))
> scheme@(guile-user)> (setlocale LC_ALL "en_US")
> $1 = "en_US"
> scheme@(guile-user)> (format #f "~" 12345.5678)
> ;;; <stdin>:3:0: warning: "~": wrong number of `format' arguments:
> expected 0, got 1
> $2 = "~"
>
> (use-modules (ice-9 i18n))
>> (setlocale LC_ALL "en_US")
>> (locale-decimal-point)
>> (locale-thousands-separator)
>>
>
> [fangism:guile20-2.0.5.24-**e7f7-0/guile-2.0.5.24-e7f7/**build] fang%
> meta/guile
> GNU Guile 2.0.5.24-e7f7
> Copyright (C) 1995-2012 Free Software Foundation, Inc.
>
> Guile comes with ABSOLUTELY NO WARRANTY; for details type `,show w'.
> This program is free software, and you are welcome to redistribute it
> under certain conditions; type `,show c' for details.
>
> Enter `,help' for help.
> scheme@(guile-user)> (use-modules (ice-9 i18n))
> scheme@(guile-user)> (setlocale LC_ALL "en_US")
> $1 = "en_US"
> scheme@(guile-user)> (locale-decimal-point)
> $2 = "."
> scheme@(guile-user)> (locale-thousands-separator)
> $3 = ","
>
>
>
> --
> David Fang
> http://www.csl.cornell.edu/~**fang/ <http://www.csl.cornell.edu/%7Efang/>
>
[-- Attachment #2: Type: text/html, Size: 3028 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* bug#10684: guile-2.0.5 test failures on powerpc-darwin8
2012-02-04 20:10 ` Stefan Israelsson Tampe
@ 2012-02-04 20:49 ` David Fang
2012-02-04 22:40 ` Ludovic Courtès
0 siblings, 1 reply; 13+ messages in thread
From: David Fang @ 2012-02-04 20:49 UTC (permalink / raw)
To: Stefan Israelsson Tampe; +Cc: Ludovic Courtès, 10684
[-- Attachment #1: Type: TEXT/PLAIN, Size: 2408 bytes --]
On Sat, 4 Feb 2012, Stefan Israelsson Tampe wrote:
> You forgot h in the format expression
>
> asked for,
> (format #f "~h" 12345.5678)
>
> you wrote,
> (format #f "~" 12345.5678)
Oops.
scheme@(guile-user)> (use-modules (ice-9 format))
scheme@(guile-user)> (setlocale LC_ALL "en_US")
$1 = "en_US"
scheme@(guile-user)> (format #f "~h" 12345.5678)
$2 = "12345.5678"
> On Sat, Feb 4, 2012 at 8:56 PM, David Fang <fang@csl.cornell.edu> wrote:
>
>> FAIL: i18n.test: format ~h: English: 12345.5678
>>>>
>>>
>>> Yes, thatÿÿs a new feature, and a new regression. ;-)
>>> Can you try:
>>>
>>> (use-modules (ice-9 format))
>>> (setlocale LC_ALL "en_US")
>>> (format #f "~h" 12345.5678)
>>>
>>
>> [fangism:guile20-2.0.5.24-**e7f7-0/guile-2.0.5.24-e7f7/**build] fang%
>> meta/guile
>> GNU Guile 2.0.5.24-e7f7
>> Copyright (C) 1995-2012 Free Software Foundation, Inc.
>>
>> Guile comes with ABSOLUTELY NO WARRANTY; for details type `,show w'.
>> This program is free software, and you are welcome to redistribute it
>> under certain conditions; type `,show c' for details.
>>
>> Enter `,help' for help.
>> scheme@(guile-user)> (use-modules (ice-9 format))
>> scheme@(guile-user)> (setlocale LC_ALL "en_US")
>> $1 = "en_US"
>> scheme@(guile-user)> (format #f "~" 12345.5678)
>> ;;; <stdin>:3:0: warning: "~": wrong number of `format' arguments:
>> expected 0, got 1
>> $2 = "~"
>>
>> (use-modules (ice-9 i18n))
>>> (setlocale LC_ALL "en_US")
>>> (locale-decimal-point)
>>> (locale-thousands-separator)
>>>
>>
>> [fangism:guile20-2.0.5.24-**e7f7-0/guile-2.0.5.24-e7f7/**build] fang%
>> meta/guile
>> GNU Guile 2.0.5.24-e7f7
>> Copyright (C) 1995-2012 Free Software Foundation, Inc.
>>
>> Guile comes with ABSOLUTELY NO WARRANTY; for details type `,show w'.
>> This program is free software, and you are welcome to redistribute it
>> under certain conditions; type `,show c' for details.
>>
>> Enter `,help' for help.
>> scheme@(guile-user)> (use-modules (ice-9 i18n))
>> scheme@(guile-user)> (setlocale LC_ALL "en_US")
>> $1 = "en_US"
>> scheme@(guile-user)> (locale-decimal-point)
>> $2 = "."
>> scheme@(guile-user)> (locale-thousands-separator)
>> $3 = ","
>>
>>
>>
>> --
>> David Fang
>> http://www.csl.cornell.edu/~**fang/ <http://www.csl.cornell.edu/%7Efang/>
>>
>
--
David Fang
http://www.csl.cornell.edu/~fang/
^ permalink raw reply [flat|nested] 13+ messages in thread
* bug#10684: guile-2.0.5 test failures on powerpc-darwin8
2012-02-04 20:49 ` David Fang
@ 2012-02-04 22:40 ` Ludovic Courtès
2012-02-06 13:02 ` Ludovic Courtès
0 siblings, 1 reply; 13+ messages in thread
From: Ludovic Courtès @ 2012-02-04 22:40 UTC (permalink / raw)
To: David Fang; +Cc: 10684
[-- Attachment #1: Type: text/plain, Size: 138 bytes --]
Hello!
I believe commit 13fb25ba0c24a9e7732d2c32dbc882c7d462bce9 (pasted below)
fixes that. Can you confirm?
Thanks,
Ludo’.
[-- Attachment #2: Type: text/x-patch, Size: 1852 bytes --]
commit 13fb25ba0c24a9e7732d2c32dbc882c7d462bce9 (HEAD, refs/remotes/origin/stable-2.0, refs/heads/stable-2.0)
Author: Ludovic Courtès <ludo@gnu.org>
Date: Sat Feb 4 23:38:47 2012 +0100
i18n: Skips ~h `format' tests when digit grouping info is missing.
* test-suite/tests/i18n.test ("format ~h"): Skip tests when
`locale-digit-grouping' returns '().
Modified test-suite/tests/i18n.test
diff --git a/test-suite/tests/i18n.test b/test-suite/tests/i18n.test
index 335f450..ef08dd4 100644
--- a/test-suite/tests/i18n.test
+++ b/test-suite/tests/i18n.test
@@ -495,22 +495,30 @@
(with-test-prefix "format ~h"
+ ;; Some systems like Darwin lack the `GROUPING' nl_item, and thus
+ ;; `locale-digit-grouping' defaults to '(); skip the tests in that
+ ;; case.
+
(with-test-prefix "French"
(pass-if "12345.5678"
(under-french-locale-or-unresolved
(lambda ()
- (string=? "12 345,6789"
- (format #f "~:h" 12345.6789 %french-locale))))))
+ (if (null? (locale-digit-grouping %french-locale))
+ (throw 'unresolved)
+ (string=? "12 345,6789"
+ (format #f "~:h" 12345.6789 %french-locale)))))))
(with-test-prefix "English"
(pass-if "12345.5678"
(under-american-english-locale-or-unresolved
(lambda ()
- (string=? "12,345.6789"
- (format #f "~:h" 12345.6789
- %american-english-locale)))))))
+ (if (null? (locale-digit-grouping %american-english-locale))
+ (throw 'unresolved)
+ (string=? "12,345.6789"
+ (format #f "~:h" 12345.6789
+ %american-english-locale))))))))
(with-test-prefix "monetary-amount->locale-string"
^ permalink raw reply related [flat|nested] 13+ messages in thread
* bug#10684: guile-2.0.5 test failures on powerpc-darwin8
2012-02-04 22:40 ` Ludovic Courtès
@ 2012-02-06 13:02 ` Ludovic Courtès
0 siblings, 0 replies; 13+ messages in thread
From: Ludovic Courtès @ 2012-02-06 13:02 UTC (permalink / raw)
To: David Fang; +Cc: 10684-done
Hi,
ludo@gnu.org (Ludovic Courtès) skribis:
> I believe commit 13fb25ba0c24a9e7732d2c32dbc882c7d462bce9 (pasted below)
> fixes that. Can you confirm?
I do! :-)
Hydra tells me it’s OK on Darwin, so closing the bug.
Thanks, David!
Ludo’.
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2012-02-06 13:02 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-31 22:51 bug#10684: guile-2.0.5 test failures on powerpc-darwin8 David Fang
2012-02-01 22:36 ` Ludovic Courtès
2012-02-01 22:56 ` David Fang
2012-02-02 21:58 ` Ludovic Courtès
2012-02-02 22:50 ` David Fang
2012-02-03 16:02 ` Ludovic Courtès
2012-02-04 1:58 ` David Fang
2012-02-04 11:04 ` Ludovic Courtès
2012-02-04 19:56 ` David Fang
2012-02-04 20:10 ` Stefan Israelsson Tampe
2012-02-04 20:49 ` David Fang
2012-02-04 22:40 ` Ludovic Courtès
2012-02-06 13:02 ` Ludovic Courtès
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).