From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Daniel Hartwig Newsgroups: gmane.lisp.guile.bugs Subject: bug#10621: Incorrect usage of hash procedures in (ice-9 mapping) Date: Wed, 28 Nov 2012 23:56:43 +0800 Message-ID: <87pq2x201w.fsf@gmail.com> References: <87k44do8lw.fsf@netris.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1354118240 2465 80.91.229.3 (28 Nov 2012 15:57:20 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 28 Nov 2012 15:57:20 +0000 (UTC) To: 10621@debbugs.gnu.org Original-X-From: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Wed Nov 28 16:57:33 2012 Return-path: Envelope-to: guile-bugs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Tdk0y-0004Qt-GZ for guile-bugs@m.gmane.org; Wed, 28 Nov 2012 16:57:32 +0100 Original-Received: from localhost ([::1]:53845 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tdk0n-0004kc-AV for guile-bugs@m.gmane.org; Wed, 28 Nov 2012 10:57:21 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:47456) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tdk0h-0004k0-OS for bug-guile@gnu.org; Wed, 28 Nov 2012 10:57:19 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tdk0Z-0002HX-VT for bug-guile@gnu.org; Wed, 28 Nov 2012 10:57:15 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:33576) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tdk0Z-0002HT-S8 for bug-guile@gnu.org; Wed, 28 Nov 2012 10:57:07 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1Tdk2Q-0007qq-CA for bug-guile@gnu.org; Wed, 28 Nov 2012 10:59:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <87k44do8lw.fsf@netris.org> Resent-From: Daniel Hartwig Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-guile@gnu.org Resent-Date: Wed, 28 Nov 2012 15:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10621 X-GNU-PR-Package: guile X-GNU-PR-Keywords: Original-Received: via spool by 10621-submit@debbugs.gnu.org id=B10621.135411833930172 (code B ref 10621); Wed, 28 Nov 2012 15:59:02 +0000 Original-Received: (at 10621) by debbugs.gnu.org; 28 Nov 2012 15:58:59 +0000 Original-Received: from localhost ([127.0.0.1]:43827 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tdk2N-0007qa-Ci for submit@debbugs.gnu.org; Wed, 28 Nov 2012 10:58:59 -0500 Original-Received: from mail-da0-f44.google.com ([209.85.210.44]:58757) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tdk2K-0007qS-0E for 10621@debbugs.gnu.org; Wed, 28 Nov 2012 10:58:57 -0500 Original-Received: by mail-da0-f44.google.com with SMTP id z20so3103468dae.3 for <10621@debbugs.gnu.org>; Wed, 28 Nov 2012 07:56:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:mime-version:content-type; bh=NCs/vbbtjE6m4bd5G0Bzu6LcX412W6tOtiAE2mjJRcg=; b=LkM5h3yyLcgXfXvQAkt48fIg6GB7JYNh0iC+xEImQnynR7dO2nihrWyC2QRRcq3wSP FA2gFlReFXzF/xRmEeRKHFiRquOsXinaMnP1/owF9njUZ6ONGqFmXwsgMg7UdXa2JPwE uFz1+9Up4wVxoFtUZZ4kWPaoIftTSSaN3NPSI9fiaGoKM/Lq/36ki6IW5mDkcPHyo1HI 3+GefdiSs7KZt9J2uFNtnS0icoS+NoxNn8xwn7ZV4Q49S65zJo85NJUrsmcmn9Wc49OU vHV9imb5S930KTNhdbgIgzb5ydbtZ469SgRe1iijZZCNWu4FKvvLAMcip71EeQGo3Stz ThUQ== Original-Received: by 10.68.232.201 with SMTP id tq9mr59345939pbc.12.1354118219190; Wed, 28 Nov 2012 07:56:59 -0800 (PST) Original-Received: from io ([101.119.17.23]) by mx.google.com with ESMTPS id l5sm12718345paz.14.2012.11.28.07.56.54 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 28 Nov 2012 07:56:57 -0800 (PST) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Original-Sender: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.bugs:6613 Archived-At: Mark H Weaver wrote: > ice-9/mapping.scm:97:48: warning: possibly wrong number of arguments to `hashx-get-handle' > ice-9/mapping.scm:94:48: warning: possibly unbound variable `hashx-create-handle' This module is quite ancient, and, in addition to these warnings, has not worked for some time. Some logic errors in hash-table-mapping (detecting len) and mapping-ref (detecting dflt), for example. Since noone has reported the brokenness I guess that means the module has no users. There is no practical way to accomodate a separate delete-proc, as hashx-remove! uses assoc. The use of delq! and others to convey the intended delete semantics is incorrect, since mapping-remove! actually presents and expects a different interface, that of hashq-remove!. There is no documentation. It seems the main purpose of this module is to associate hash and assoc procedures with a hash table, and so provide a single set of accessors (rather than one for each of hashq, hashv, etc.). This is more-or-less handled by both srfi-69 and rnrs hashtables. A short module, it is not hard to fix, though given all of the above it makes sense to simply remove it.