From: Daniel Hartwig <mandyke@gmail.com>
To: 10621@debbugs.gnu.org
Subject: bug#10621: Incorrect usage of hash procedures in (ice-9 mapping)
Date: Wed, 28 Nov 2012 23:56:43 +0800 [thread overview]
Message-ID: <87pq2x201w.fsf@gmail.com> (raw)
In-Reply-To: <87k44do8lw.fsf@netris.org>
Mark H Weaver <mhw@netris.org> wrote:
> ice-9/mapping.scm:97:48: warning: possibly wrong number of arguments to `hashx-get-handle'
> ice-9/mapping.scm:94:48: warning: possibly unbound variable `hashx-create-handle'
This module is quite ancient, and, in addition to these warnings, has
not worked for some time. Some logic errors in hash-table-mapping
(detecting len) and mapping-ref (detecting dflt), for example. Since
noone has reported the brokenness I guess that means the module has no
users.
There is no practical way to accomodate a separate delete-proc, as
hashx-remove! uses assoc. The use of delq! and others to convey the
intended delete semantics is incorrect, since mapping-remove! actually
presents and expects a different interface, that of hashq-remove!.
There is no documentation.
It seems the main purpose of this module is to associate hash and assoc
procedures with a hash table, and so provide a single set of accessors
(rather than one for each of hashq, hashv, etc.). This is more-or-less
handled by both srfi-69 and rnrs hashtables.
A short module, it is not hard to fix, though given all of the above it
makes sense to simply remove it.
next prev parent reply other threads:[~2012-11-28 15:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-27 8:25 bug#10621: Incorrect usage of hash procedures in (ice-9 mapping) Mark H Weaver
2012-11-28 15:56 ` Daniel Hartwig [this message]
2012-11-28 16:32 ` Daniel Hartwig
2013-02-24 14:10 ` Andy Wingo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pq2x201w.fsf@gmail.com \
--to=mandyke@gmail.com \
--cc=10621@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).