From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Mark H Weaver Newsgroups: gmane.lisp.guile.bugs Subject: bug#20109: Incompatible API change in 2.0 series for string port encoding Date: Tue, 17 Mar 2015 18:44:17 -0400 Message-ID: <87pp87fdmm.fsf@netris.org> References: <87mw3eh04z.fsf@fencepost.gnu.org> <87zj7cznb5.fsf@netris.org> <874mpkf25p.fsf@fencepost.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1426632606 27618 80.91.229.3 (17 Mar 2015 22:50:06 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 17 Mar 2015 22:50:06 +0000 (UTC) Cc: 20109@debbugs.gnu.org To: David Kastrup Original-X-From: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Tue Mar 17 23:49:57 2015 Return-path: Envelope-to: guile-bugs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YY0J7-0007jw-UH for guile-bugs@m.gmane.org; Tue, 17 Mar 2015 23:49:54 +0100 Original-Received: from localhost ([::1]:57516 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YY0J7-0003aR-Dj for guile-bugs@m.gmane.org; Tue, 17 Mar 2015 18:49:53 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49912) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YY0J3-0003aG-Jx for bug-guile@gnu.org; Tue, 17 Mar 2015 18:49:50 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YY0Iz-00056Y-Gl for bug-guile@gnu.org; Tue, 17 Mar 2015 18:49:49 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:51892) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YY0DS-0003Wh-TU for bug-guile@gnu.org; Tue, 17 Mar 2015 18:44:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YY0DS-0004Fi-BU for bug-guile@gnu.org; Tue, 17 Mar 2015 18:44:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mark H Weaver Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Tue, 17 Mar 2015 22:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20109 X-GNU-PR-Package: guile X-GNU-PR-Keywords: Original-Received: via spool by 20109-submit@debbugs.gnu.org id=B20109.142663224016329 (code B ref 20109); Tue, 17 Mar 2015 22:44:02 +0000 Original-Received: (at 20109) by debbugs.gnu.org; 17 Mar 2015 22:44:00 +0000 Original-Received: from localhost ([127.0.0.1]:50460 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YY0DQ-0004FJ-6h for submit@debbugs.gnu.org; Tue, 17 Mar 2015 18:44:00 -0400 Original-Received: from world.peace.net ([50.252.239.5]:35646) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YY0DN-0004F9-QB for 20109@debbugs.gnu.org; Tue, 17 Mar 2015 18:43:58 -0400 Original-Received: from [10.1.10.78] (helo=jojen) by world.peace.net with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1YY0DG-000870-S5; Tue, 17 Mar 2015 18:43:50 -0400 In-Reply-To: <874mpkf25p.fsf@fencepost.gnu.org> (David Kastrup's message of "Tue, 17 Mar 2015 09:39:46 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Original-Sender: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.bugs:7753 Archived-At: David Kastrup writes: > Mark H Weaver writes: > >> This hack of giving Guile a buffer containing UTF-8, but claiming that >> it is Latin-1, is not good. It will cause Guile to see non-ASCII >> characters as garbage. > > For one thing we are talking about an external file here that is mainly > parsed by LilyPond. LilyPond provides sensible pinpointing of UTF-8 > encoding errors, something which GUILE cannot do with its UTF-8 > representation since it has no transparent or reproducible > representation of bad bytes. Emacs uses overlong encodings for 0-127 to > represent badly encoded bytes (which includes any overlong sequences) in > the range 128-255, making 128-255 encode as patterns 0xc0 0x80 to 0xc1 > 0xbf. I intend to add a similar mechanism to Guile, but it is not yet done. >> However, if you insist on doing this, I would >> suggest using a bytevector input port instead, like this: (untested) >> >> char *buf = c_str (); >> SCM bv = scm_c_make_bytevector (strlen (buf) + 1); >> strcpy (SCM_BYTEVECTOR_CONTENTS (bv), buf); >> str_port_ = scm_open_bytevector_input_port (bv, SCM_UNDEFINED); > > dak@lola:/usr/local/tmp/guile$ git grep scm_open_byte_vector_input_port v2.0.11 > dak@lola:/usr/local/tmp/guile$ git grep scm_open_byte_vector_input_port origin/stable-2.0 > dak@lola:/usr/local/tmp/guile$ You have mispelled the name of the function. The following (untested) code should work on Guile 2.0.5 or later: char *buf = c_str (); size_t len = strlen (buf); SCM bv = scm_c_make_bytevector (len); memcpy (SCM_BYTEVECTOR_CONTENTS (bv), buf, len); str_port_ = scm_open_bytevector_input_port (bv, SCM_UNDEFINED); Mark