unofficial mirror of bug-guile@gnu.org 
 help / color / mirror / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Christopher Baines <mail@cbaines.net>
Cc: 62290-done@debbugs.gnu.org
Subject: bug#62290: Error when handling invalid unicode with suspendable ports
Date: Mon, 20 Mar 2023 23:27:32 +0100	[thread overview]
Message-ID: <87pm932h4b.fsf_-_@gnu.org> (raw)
In-Reply-To: <20230320091513.10817-1-mail@cbaines.net> (Christopher Baines's message of "Mon, 20 Mar 2023 09:15:13 +0000")

Hello,

Christopher Baines <mail@cbaines.net> skribis:

> Based on the implementation in ports.c.  I don't understand what this
> code is really doing, but the suspendable ports implementation differs
> from the similar C code for a couple of inequalities.
>
> * module/ice-9/suspendable-ports.scm (decode-utf8, bad-utf8-len): Flip a
> couple of inequalities.
> * test-suite/tests/ports.test ("string ports"): Add additional invalid
> UTF-8 test case.

Pushed as cba2e7e3fec3c781230570f5d1ef070625eeeda8.

Thanks for documenting the problem and providing a perfect patch!

Ludo’.





      reply	other threads:[~2023-03-20 22:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-20  9:09 bug#62290: Error when handling invalid unicode with suspendable ports Christopher Baines
2023-03-20  9:15 ` bug#62290: [PATCH] Fix some invalid unicode handling issues " Christopher Baines
2023-03-20 22:27   ` Ludovic Courtès [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pm932h4b.fsf_-_@gnu.org \
    --to=ludo@gnu.org \
    --cc=62290-done@debbugs.gnu.org \
    --cc=mail@cbaines.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).