unofficial mirror of bug-guile@gnu.org 
 help / color / mirror / Atom feed
From: Kevin Ryde <user42@zip.com.au>
Cc: bug-guile@gnu.org
Subject: guile-core (cvs) patch
Date: Sun, 25 Apr 2004 06:59:07 +1000	[thread overview]
Message-ID: <87oephhz38.fsf@zip.com.au> (raw)
In-Reply-To: 40893811.mailNWN1WP2KH@localhost

hyperdivision@sleepynyago.dyndns.org (Hyperdivision) writes:
>
> patch to get guile-cvs to build with gcc-cvs

Random diffs are not a bug report. :(

> -          if (BIGMPZ_FITSP)
> +#ifdef BIGMPZ_FITSP

No, that makes scm_num2long_long seg fault.  If you want to propose a
change then run it first.

I see the range checking in the "non mpz_fits" part is not quite
accurate either, actually.

> -      SCM_ASSERT_RANGE (which_arg, address, bignum_in_ipv6_range_p);\
> +      SCM_ASSERT_RANGE (which_arg, address, bignum_in_ipv6_range_p(address));\

> -  return SCM_BOOL (scm_thread_yield);
> +  return SCM_BOOL (scm_thread_yield());

Thanks, these are bugs.

> -static const char s_scm_make_uve[];
> +/*static const char s_scm_make_uve[];*/

Thanks.


_______________________________________________
Bug-guile mailing list
Bug-guile@gnu.org
http://mail.gnu.org/mailman/listinfo/bug-guile


  reply	other threads:[~2004-04-24 20:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-04-23 15:36 (no subject) Hyperdivision
2004-04-24 20:59 ` Kevin Ryde [this message]
2004-04-24 22:30   ` guile-core (cvs) patch Hyperdivision

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87oephhz38.fsf@zip.com.au \
    --to=user42@zip.com.au \
    --cc=bug-guile@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).