From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Kevin Ryde Newsgroups: gmane.lisp.guile.bugs Subject: Re: Patch for scm_strftime() in stime.c Date: Mon, 03 May 2004 09:02:33 +1000 Sender: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Message-ID: <87oep6xwja.fsf@zip.com.au> References: <633F02B4-9C47-11D8-BCCF-000D93673682@gmx.net> <5E7FD87F-9C71-11D8-BCCF-000D93673682@gmx.net> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: sea.gmane.org 1083539499 15977 80.91.224.253 (2 May 2004 23:11:39 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 2 May 2004 23:11:39 +0000 (UTC) Original-X-From: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Mon May 03 01:11:30 2004 Return-path: Original-Received: from monty-python.gnu.org ([199.232.76.173]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1BKQ7O-0003SJ-00 for ; Mon, 03 May 2004 01:11:30 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.30) id 1BKQ77-00077Y-G5 for guile-bugs@m.gmane.org; Sun, 02 May 2004 19:11:13 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30) id 1BKQ5C-0005Rg-DN for bug-guile@gnu.org; Sun, 02 May 2004 19:09:14 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30) id 1BKQ4W-0004fA-Eq for bug-guile@gnu.org; Sun, 02 May 2004 19:09:03 -0400 Original-Received: from [199.232.41.8] (helo=mx20.gnu.org) by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168) (Exim 4.30) id 1BKQ4V-0004QP-Rb for bug-guile@gnu.org; Sun, 02 May 2004 19:08:31 -0400 Original-Received: from [61.8.0.84] (helo=mailout1.pacific.net.au) by mx20.gnu.org with esmtp (Exim 4.30) id 1BKPyt-0005Ry-Sk for bug-guile@gnu.org; Sun, 02 May 2004 19:02:44 -0400 Original-Received: from mailproxy2.pacific.net.au (mailproxy2.pacific.net.au [61.8.0.87]) by mailout1.pacific.net.au (8.12.3/8.12.3/Debian-6.6) with ESMTP id i42N2d4u001934 for ; Mon, 3 May 2004 09:02:39 +1000 Original-Received: from localhost (ppp2A37.dyn.pacific.net.au [61.8.42.55]) by mailproxy2.pacific.net.au (8.12.3/8.12.3/Debian-6.6) with ESMTP id i42N2bHV029205 for ; Mon, 3 May 2004 09:02:38 +1000 Original-Received: from gg by localhost with local (Exim 3.36 #1 (Debian)) id 1BKPyk-0000LK-00; Mon, 03 May 2004 09:02:34 +1000 Original-To: bug-guile@gnu.org In-Reply-To: <5E7FD87F-9C71-11D8-BCCF-000D93673682@gmx.net> (Andreas =?iso-8859-1?q?V=F6gele's?= message of "Sun, 2 May 2004 21:46:13 +0200") User-Agent: Gnus/5.110002 (No Gnus v0.2) Emacs/21.3 (gnu/linux) X-BeenThere: bug-guile@gnu.org X-Mailman-Version: 2.1.4 Precedence: list List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Xref: main.gmane.org gmane.lisp.guile.bugs:1388 X-Report-Spam: http://spam.gmane.org/gmane.lisp.guile.bugs:1388 Andreas V=F6gele writes: > > I thought about this problem. It's probably better to fix the test > instead of scm_strftime(). Yep, it looks pretty dodgy. I wonder what it was trying to exercise. > Or do you think that scm_strftime() should silently fix > mismatches between the time zone name and dst? I think it should print what's in the tm record it's given. If the user has butchered the info then that's their problem. > A patch for time.test is attached. Thanks, I made that change, but using set-tm:isdst. _______________________________________________ Bug-guile mailing list Bug-guile@gnu.org http://mail.gnu.org/mailman/listinfo/bug-guile