From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: ludo@gnu.org (Ludovic =?iso-8859-1?Q?Court=E8s?=) Newsgroups: gmane.lisp.guile.bugs Subject: Re: [PATCH] Final: thread lock nesting debugging Date: Tue, 18 Nov 2008 14:26:09 +0100 Message-ID: <87od0d413i.fsf@gnu.org> References: <3ae3aa420811162042n4b5d50e3i136a9f7b00262a69@mail.gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1227014824 28447 80.91.229.12 (18 Nov 2008 13:27:04 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 18 Nov 2008 13:27:04 +0000 (UTC) To: bug-guile@gnu.org Original-X-From: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Tue Nov 18 14:28:06 2008 Return-path: Envelope-to: guile-bugs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1L2QcK-00032S-2l for guile-bugs@m.gmane.org; Tue, 18 Nov 2008 14:27:44 +0100 Original-Received: from localhost ([127.0.0.1]:49840 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L2QbB-0004aw-57 for guile-bugs@m.gmane.org; Tue, 18 Nov 2008 08:26:33 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L2Qb7-0004ai-CU for bug-guile@gnu.org; Tue, 18 Nov 2008 08:26:29 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L2Qb6-0004aW-1O for bug-guile@gnu.org; Tue, 18 Nov 2008 08:26:29 -0500 Original-Received: from [199.232.76.173] (port=44240 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L2Qb5-0004aT-PQ for bug-guile@gnu.org; Tue, 18 Nov 2008 08:26:27 -0500 Original-Received: from main.gmane.org ([80.91.229.2]:54235 helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1L2Qb5-0001dd-Ps for bug-guile@gnu.org; Tue, 18 Nov 2008 08:26:27 -0500 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1L2Qay-0005Eb-61 for bug-guile@gnu.org; Tue, 18 Nov 2008 13:26:20 +0000 Original-Received: from 195.83.213.140 ([195.83.213.140]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 18 Nov 2008 13:26:20 +0000 Original-Received: from ludo by 195.83.213.140 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 18 Nov 2008 13:26:20 +0000 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 22 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 195.83.213.140 X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 28 Brumaire an 217 de la =?iso-8859-1?Q?R=E9volution?= X-PGP-Key-ID: 0xEA52ECF4 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 821D 815D 902A 7EAB 5CEE D120 7FBA 3D4F EB1F 5364 X-OS: i686-pc-linux-gnu User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.3 (gnu/linux) Cancel-Lock: sha1:0LeFP/tWf30Vh81Kz/kLvkn0aLY= X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: bug-guile@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Errors-To: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.bugs:4109 Archived-At: Hello, "Linas Vepstas" writes: > I've been seeing all sorts of deadlocks in guile, and so I wrote a small > debugging utility to try to track down the problems. I'd like to see > this patch included in future versions of guile. FWIW, I'm reluctant to committing this patch for various reasons: intrusion, non-genericity, bitrot of conditional code as Han-Wen noted, non-C89ness, pollution outside of the `scm_' namespace, incorrect style. Another reason is that pthread libraries are sometimes able to debug deadlocks by themselves. NetBSD's performs several run-time checks by default [0]. Another solution is the explicit use of error-checking mutexes, as with the patch at [1]. What do you think? Thanks, Ludo'. [0] http://thread.gmane.org/gmane.lisp.guile.devel/6656 [1] http://thread.gmane.org/gmane.lisp.guile.devel/6733