From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Rob Browning Newsgroups: gmane.lisp.guile.bugs Subject: bug#56413: [PATCH 1/1] scm_i_utf8_string_hash: compute u8 chars not bytes Date: Sun, 06 Nov 2022 10:44:50 -0600 Message-ID: <87o7tkvxq5.fsf@trouble.defaultvalue.org> References: <20220706012323.1024763-1-rlb@defaultvalue.org> <87zgd5gi4t.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28652"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 56413@debbugs.gnu.org To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-X-From: bug-guile-bounces+guile-bugs=m.gmane-mx.org@gnu.org Sun Nov 06 17:45:42 2022 Return-path: Envelope-to: guile-bugs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1orimE-0007HH-4T for guile-bugs@m.gmane-mx.org; Sun, 06 Nov 2022 17:45:42 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1orilg-00034B-J0; Sun, 06 Nov 2022 11:45:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1orilb-00033R-OY for bug-guile@gnu.org; Sun, 06 Nov 2022 11:45:06 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1orila-0001o3-25 for bug-guile@gnu.org; Sun, 06 Nov 2022 11:45:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1orilZ-0001Kj-I4 for bug-guile@gnu.org; Sun, 06 Nov 2022 11:45:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Rob Browning Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Sun, 06 Nov 2022 16:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56413 X-GNU-PR-Package: guile X-GNU-PR-Keywords: patch Original-Received: via spool by 56413-submit@debbugs.gnu.org id=B56413.16677530945100 (code B ref 56413); Sun, 06 Nov 2022 16:45:01 +0000 Original-Received: (at 56413) by debbugs.gnu.org; 6 Nov 2022 16:44:54 +0000 Original-Received: from localhost ([127.0.0.1]:60503 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1orilS-0001KC-8m for submit@debbugs.gnu.org; Sun, 06 Nov 2022 11:44:54 -0500 Original-Received: from defaultvalue.org ([45.33.119.55]:59688 ident=postfix) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1orilQ-0001K3-0N for 56413@debbugs.gnu.org; Sun, 06 Nov 2022 11:44:53 -0500 Original-Received: from trouble.defaultvalue.org (localhost [127.0.0.1]) (Authenticated sender: rlb@defaultvalue.org) by defaultvalue.org (Postfix) with ESMTPSA id 68BE22017E; Sun, 6 Nov 2022 10:44:51 -0600 (CST) Original-Received: by trouble.defaultvalue.org (Postfix, from userid 1000) id A599D14E553; Sun, 6 Nov 2022 10:44:50 -0600 (CST) In-Reply-To: <87zgd5gi4t.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-guile" Errors-To: bug-guile-bounces+guile-bugs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.lisp.guile.bugs:10414 Archived-At: Ludovic Court=C3=A8s writes: > For the final patch please add a ChangeLog-style entry. Will do. > Is this a documented example of Jenkins? Or did you use a reference > implementation? Jenkins? > Yes, it may be nicer to have it in =E2=80=98test-suite/tests/hash.test=E2= =80=99. > > AFAICS this will only change the hash of UTF-8 symbols and won=E2=80=99t = have > any effect on the output of =E2=80=98string-hash=E2=80=99, right? If not= that would be > an incompatibility. I think that's right, but I'll have to refresh my memory regarding the changes. (Haven't gotten back to the utf-8 work for a bit so it's not top of mind, though I hope to soon.) Thanks --=20 Rob Browning rlb @defaultvalue.org and @debian.org GPG as of 2011-07-10 E6A9 DA3C C9FD 1FF8 C676 D2C4 C0F0 39E9 ED1B 597A GPG as of 2002-11-03 14DD 432F AE39 534D B592 F9A0 25C8 D377 8C7E 73A4