From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Newsgroups: gmane.lisp.guile.bugs Subject: bug#73605: [PATCH] Replace SRFI-64 with a new implementation. Date: Sun, 13 Oct 2024 22:09:36 +0200 Message-ID: <87o73nrchr.fsf__14659.8639593989$1728850272$gmane$org@gnu.org> References: <20241002194105.24409-1-~@wolfsden.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39634"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Andy Wingo , guile-devel@gnu.org, 73605@debbugs.gnu.org, Rob Browning To: Tomas Volf <~@wolfsden.cz> Original-X-From: bug-guile-bounces+guile-bugs=m.gmane-mx.org@gnu.org Sun Oct 13 22:11:04 2024 Return-path: Envelope-to: guile-bugs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t04ve-000A6H-6W for guile-bugs@m.gmane-mx.org; Sun, 13 Oct 2024 22:11:02 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t04vQ-0003AP-Rv; Sun, 13 Oct 2024 16:10:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t04vO-00039y-MU for bug-guile@gnu.org; Sun, 13 Oct 2024 16:10:46 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t04vO-0005Kx-DG for bug-guile@gnu.org; Sun, 13 Oct 2024 16:10:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=OBVzCy+EpEgQOzuFazZV3O8vImKqQlbRZHKijDef+jQ=; b=uEhb6l4sUmHq8s6Ul/acyO1fuTWAit8YUZLN0e6rQxD7iiwJng/CqQs4lY9xxlrBSCooaIPQ/9tq1rO66yoONsTfkbth3OpeCzZz6T3qZRIxcO1oZtbgsd+MlyaH4xaAVUB9puD/zpOg/NvCHOdWT1G3co8+hgB6oBKkgCJuv5uLNjvx9UFpwNumCt5oz6YKdXHL6Nr9VY0MAkg0Vlu5IsWdrHztzbi7jFzY+CgPy1NGT5QBpxckgKliu2EzQShRLkrndj+IGMM1yzTw7Ylm85EmcYvI1TOmevp039dfMgiW1B0vaR72GMnZUlRxa/E4WyrfMNR21VUXsNA4UXnyiA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t04vd-0001eF-T7 for bug-guile@gnu.org; Sun, 13 Oct 2024 16:11:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Sun, 13 Oct 2024 20:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73605 X-GNU-PR-Package: guile X-GNU-PR-Keywords: patch Original-Received: via spool by 73605-submit@debbugs.gnu.org id=B73605.17288502125713 (code B ref 73605); Sun, 13 Oct 2024 20:11:01 +0000 Original-Received: (at 73605) by debbugs.gnu.org; 13 Oct 2024 20:10:12 +0000 Original-Received: from localhost ([127.0.0.1]:57015 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t04uq-0001U4-Gr for submit@debbugs.gnu.org; Sun, 13 Oct 2024 16:10:12 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:42322) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t04un-0001Tk-50 for 73605@debbugs.gnu.org; Sun, 13 Oct 2024 16:10:11 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t04uQ-00055m-TC; Sun, 13 Oct 2024 16:09:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=OBVzCy+EpEgQOzuFazZV3O8vImKqQlbRZHKijDef+jQ=; b=O5cTYYSAanCvnEuPqX4e zD495jyp15TFVrNEwTdSn2SoWZ5UY9SwXSKAJQ7NAT2FknuSrJQwgNhl0nGLk4xdjyVN5zNXpVBpC vK7H87ZPAduKslu+T2+mebaXMvIyXhvRD8wfcgQ/JchTl2icZSzXWsR/jPPUACKiDBKtLMioailMF FRCsbs5l4Zl1cKjeMqftFSTGRhyv0JuW81ErjBo6dJ4sqfm9aQoB26GjsyVgyBqKvdg3dliW0fp+h GNz0MVU2oOGYFMmkc/b+CMgPPLYeGFUOWRLVI3fwXLTYMLE8vnwHBWxsPP9YZX5r/uUat+FF6yqE1 lEEHNRBFiSY0hA==; In-Reply-To: <20241002194105.24409-1-~@wolfsden.cz> (Tomas Volf's message of "Wed, 2 Oct 2024 21:27:59 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guile-bounces+guile-bugs=m.gmane-mx.org@gnu.org Original-Sender: bug-guile-bounces+guile-bugs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.lisp.guile.bugs:11033 Archived-At: Hi Tomas, Tomas Volf <~@wolfsden.cz> skribis: > The bundled (reference) implementation was of somewhat mixed quality and > it failed to follow standard in multiple places. This commit replaces > it with a new one, written from scratch to follow the standard as close > as possible. > > * module/srfi/srfi-64/testing.scm: Delete file. > * module/srfi/srfi-64.scm: Replace with new implementation. > * am/bootstrap.am (srfi/srfi-64.go): Remove extra dependencies. > (NOCOMP_SOURCES): Remove srfi/srfi-64/testing.scm. > * test-suite/tests/srfi-64-test.scm > ("8.6.1. Simple (form 1) test-apply") > ("8.6.2. Simple (form 2) test-apply"): Adjust tests to follow the > specification. Nice work! Andy, Rob: I=E2=80=99m willing to apply this patch as I think it=E2=80=99s = an improvement over the reference implementation that we currently have, and whose weaknesses Tomas described at length in . The fact that this new implementation was successfully tested with the test suite of Guix (probably the largest SRFI-64 user) is also reassuring to me. Everyone, please speak up if you object. If there are no objections within a week or so, I=E2=80=99d like to apply it. Thanks, Ludo=E2=80=99.