From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andy Wingo Newsgroups: gmane.lisp.guile.bugs Subject: bug#21872: [PATCH] guile fails to build on illumos Date: Fri, 24 Jun 2016 17:54:17 +0200 Message-ID: <87mvmaeg5y.fsf@pobox.com> References: <8DDFFA1D-5FA8-4F1C-9C19-345CE17CC69C@racktopsystems.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1466784098 32555 80.91.229.3 (24 Jun 2016 16:01:38 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 24 Jun 2016 16:01:38 +0000 (UTC) Cc: 21872-done@debbugs.gnu.org To: Andy Stormont Original-X-From: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Fri Jun 24 18:01:26 2016 Return-path: Envelope-to: guile-bugs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bGTXp-0005YB-QB for guile-bugs@m.gmane.org; Fri, 24 Jun 2016 18:01:25 +0200 Original-Received: from localhost ([::1]:44504 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGTXo-0005lZ-W3 for guile-bugs@m.gmane.org; Fri, 24 Jun 2016 12:01:25 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57850) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGTRk-0007mB-AY for bug-guile@gnu.org; Fri, 24 Jun 2016 11:55:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bGTRf-0005Lq-16 for bug-guile@gnu.org; Fri, 24 Jun 2016 11:55:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:42182) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGTRe-0005Ll-Sy for bug-guile@gnu.org; Fri, 24 Jun 2016 11:55:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bGTRe-0006ro-OZ for bug-guile@gnu.org; Fri, 24 Jun 2016 11:55:02 -0400 Resent-From: Andy Wingo Original-Sender: "Debbugs-submit" Resent-To: bug-guile@gnu.org Resent-Date: Fri, 24 Jun 2016 15:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 21872 X-GNU-PR-Package: guile X-GNU-PR-Keywords: patch Mail-Followup-To: 21872@debbugs.gnu.org, wingo@pobox.com, astormont@racktopsystems.com Original-Received: via spool by 21872-done@debbugs.gnu.org id=D21872.146678367026344 (code D ref 21872); Fri, 24 Jun 2016 15:55:02 +0000 Original-Received: (at 21872-done) by debbugs.gnu.org; 24 Jun 2016 15:54:30 +0000 Original-Received: from localhost ([127.0.0.1]:54519 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bGTR8-0006qq-98 for submit@debbugs.gnu.org; Fri, 24 Jun 2016 11:54:30 -0400 Original-Received: from pb-sasl1.pobox.com ([64.147.108.66]:54900 helo=sasl.smtp.pobox.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bGTR6-0006qh-8T for 21872-done@debbugs.gnu.org; Fri, 24 Jun 2016 11:54:28 -0400 Original-Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by pb-sasl1.pobox.com (Postfix) with ESMTP id EBD181F706; Fri, 24 Jun 2016 11:54:25 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=sasl; bh=LPzvqYPvOY5H W+n/flm6T3wxDSg=; b=p9jBKOFznms84NuIKO+WxZx9Mao36SQ9wM5xnPz8XXlZ 4x7leTavIiKub+McuVML/bj8ZKJuQflTJ/cGVN4Bxz6O+RoWObIKDU8s6DZj+lpL +0yOVAoPCvpjr+Ug7jSYBIQDQ0Fc/I8u7EgjYfmbY7eb51lNNbcobZl5BWlyKWM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; q=dns; s=sasl; b=eZpxY4 VdTnBXTHliC79PHLMa5pPbzOk6e4agg1YQIBJ4nObItgCHZ8YLPgGpkVnvca98Lp 539skoj00FfCWYIDv6wUUSlk6ZZRoQ4vp1zAsV98wRdInGLm6O8FZZPFMFuqkjJe bYTm8QHBUw6+48Ag1OppW1H4hXmKIPuzKEh8g= Original-Received: from pb-sasl1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-sasl1.pobox.com (Postfix) with ESMTP id E3F951F705; Fri, 24 Jun 2016 11:54:25 -0400 (EDT) Original-Received: from clucks (unknown [88.160.190.192]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by pb-sasl1.pobox.com (Postfix) with ESMTPSA id 226261F704; Fri, 24 Jun 2016 11:54:25 -0400 (EDT) In-Reply-To: <8DDFFA1D-5FA8-4F1C-9C19-345CE17CC69C@racktopsystems.com> (Andy Stormont's message of "Tue, 10 Nov 2015 16:16:39 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) X-Pobox-Relay-ID: ECE377AE-3A23-11E6-BA14-C1836462E9F6-02397024!pb-sasl1.pobox.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Original-Sender: "bug-guile" Xref: news.gmane.org gmane.lisp.guile.bugs:8231 Archived-At: Fixed in git; thanks :) Andy On Tue 10 Nov 2015 17:16, Andy Stormont writ= es: > The patch below allows Guile to build on illumos, which does not have ful= l support for the GNU locale extensions. For more information on what=E2= =80=99s missing see here: https://www.illumos.org/issues/5346 > > diff --git a/configure.ac b/configure.ac > index 9e639d6..408643b 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -765,8 +765,8 @@ AC_CHECK_FUNCS([DINFINITY DQNAN cexp chsize clog clog= 10 ctermid \ > strdup system usleep atexit on_exit chown link fcntl ttyname getpwent = \ > getgrent kill getppid getpgrp fork setitimer getitimer strchr strcmp \ > index bcopy memcpy rindex truncate unsetenv isblank _NSGetEnviron \ > - strcoll strcoll_l newlocale uselocale utimensat sched_getaffinity \ > - sched_setaffinity sendfile]) > + strcoll strcoll_l strtod_l strtol_l newlocale uselocale utimensat \ > + sched_getaffinity sched_setaffinity sendfile]) >=20=20 > # Reasons for testing: > # netdb.h - not in mingw > diff --git a/libguile/i18n.c b/libguile/i18n.c > index f0e3443..bd0b5a2 100644 > --- a/libguile/i18n.c > +++ b/libguile/i18n.c > @@ -1373,7 +1373,7 @@ SCM_DEFINE (scm_locale_string_to_integer, "locale-s= tring->integer", >=20=20 > if (c_locale !=3D NULL) > { > -#ifdef USE_GNU_LOCALE_API > +#if defined USE_GNU_LOCALE_API && defined HAVE_STRTOL_L > c_result =3D strtol_l (c_str, &c_endptr, c_base, c_locale); > #else > RUN_IN_LOCALE_SECTION (c_locale, > @@ -1417,7 +1417,7 @@ SCM_DEFINE (scm_locale_string_to_inexact, "locale-s= tring->inexact", >=20=20 > if (c_locale !=3D NULL) > { > -#ifdef USE_GNU_LOCALE_API > +#if defined USE_GNU_LOCALE_API && defined HAVE_STRTOD_L > c_result =3D strtod_l (c_str, &c_endptr, c_locale); > #else > RUN_IN_LOCALE_SECTION (c_locale, > > - Andy.