From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Rob Browning Newsgroups: gmane.lisp.guile.bugs Subject: Re: gethost error display Date: Tue, 22 Jun 2004 10:51:33 -0500 Sender: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Message-ID: <87llifzj3u.fsf@trouble.defaultvalue.org> References: <871y2av8yi.fsf@zip.com.au> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1087919524 28471 80.91.224.253 (22 Jun 2004 15:52:04 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 22 Jun 2004 15:52:04 +0000 (UTC) Cc: bug-guile@gnu.org Original-X-From: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Tue Jun 22 17:51:54 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1BcnYv-0001Dd-00 for ; Tue, 22 Jun 2004 17:51:54 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1BcnaF-0000ZH-1x for guile-bugs@m.gmane.org; Tue, 22 Jun 2004 11:53:15 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1BcnaC-0000Ys-9S for bug-guile@gnu.org; Tue, 22 Jun 2004 11:53:12 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1BcnaA-0000YR-OT for bug-guile@gnu.org; Tue, 22 Jun 2004 11:53:12 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1BcnaA-0000YG-Ka for bug-guile@gnu.org; Tue, 22 Jun 2004 11:53:10 -0400 Original-Received: from [66.93.216.237] (helo=defaultvalue.org) by monty-python.gnu.org with esmtp (Exim 4.34) id 1BcnYd-0008Oh-Qr for bug-guile@gnu.org; Tue, 22 Jun 2004 11:51:36 -0400 Original-Received: from trouble.defaultvalue.org (omen.defaultvalue.org [192.168.1.1]) by defaultvalue.org (Postfix) with ESMTP id 5682D40F4; Tue, 22 Jun 2004 10:51:35 -0500 (CDT) Original-Received: by trouble.defaultvalue.org (Postfix, from userid 1000) id 26267410C0; Tue, 22 Jun 2004 10:51:34 -0500 (CDT) Original-To: Kevin Ryde In-Reply-To: <871y2av8yi.fsf@zip.com.au> (Kevin Ryde's message of "Sat, 15 Feb 2003 07:38:45 +1000") User-Agent: Gnus/5.1006 (Gnus v5.10.6) Emacs/21.3 (gnu/linux) X-BeenThere: bug-guile@gnu.org X-Mailman-Version: 2.1.4 Precedence: list List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Xref: main.gmane.org gmane.lisp.guile.bugs:1508 X-Report-Spam: http://spam.gmane.org/gmane.lisp.guile.bugs:1508 Kevin Ryde writes: > I don't know if the gethost error should be changed, it might break > existing code to do so. > > But it might be nice if the default error handler was more forgiving > of exception arguments. If the arguments are pretty much arbitrary > then perhaps some sort of heuristic like using simple-format only if > there's the right number of ~A or ~S in the string. Actually, I wonder if this is just a bug. The scm_error call in scm_resolv_error passes the bad host name as a format argument, but none of the error messages have format escapes. So I suspect maybe this call: scm_error (key, subr, errmsg, scm_cons (bad_value, SCM_EOL), SCM_EOL); should actually look like this: scm_error (key, subr, errmsg, SCM_BOOL_F, scm_list_1 (bad_value)); so that we pass the bad hostname as one of the exception extra data items rather than making it the first format string item. Anyone have any counterarguments? -- Rob Browning rlb @defaultvalue.org and @debian.org; previously @cs.utexas.edu GPG starting 2002-11-03 = 14DD 432F AE39 534D B592 F9A0 25C8 D377 8C7E 73A4 _______________________________________________ Bug-guile mailing list Bug-guile@gnu.org http://lists.gnu.org/mailman/listinfo/bug-guile