unofficial mirror of bug-guile@gnu.org 
 help / color / mirror / Atom feed
From: Rob Browning <rlb@defaultvalue.org>
Cc: bug-guile@gnu.org
Subject: Re: gethost error display
Date: Tue, 22 Jun 2004 10:51:33 -0500	[thread overview]
Message-ID: <87llifzj3u.fsf@trouble.defaultvalue.org> (raw)
In-Reply-To: <871y2av8yi.fsf@zip.com.au> (Kevin Ryde's message of "Sat, 15 Feb 2003 07:38:45 +1000")

Kevin Ryde <user42@zip.com.au> writes:

> I don't know if the gethost error should be changed, it might break
> existing code to do so.
>
> But it might be nice if the default error handler was more forgiving
> of exception arguments.  If the arguments are pretty much arbitrary
> then perhaps some sort of heuristic like using simple-format only if
> there's the right number of ~A or ~S in the string.

Actually, I wonder if this is just a bug.  The scm_error call in
scm_resolv_error passes the bad host name as a format argument, but
none of the error messages have format escapes.  So I suspect maybe
this call:

      scm_error (key, subr, errmsg, scm_cons (bad_value, SCM_EOL), SCM_EOL);

should actually look like this:

      scm_error (key, subr, errmsg, SCM_BOOL_F, scm_list_1 (bad_value));

so that we pass the bad hostname as one of the exception extra data
items rather than making it the first format string item.

Anyone have any counterarguments?

-- 
Rob Browning
rlb @defaultvalue.org and @debian.org; previously @cs.utexas.edu
GPG starting 2002-11-03 = 14DD 432F AE39 534D B592  F9A0 25C8 D377 8C7E 73A4


_______________________________________________
Bug-guile mailing list
Bug-guile@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-guile


  reply	other threads:[~2004-06-22 15:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-02-14 21:38 gethost error display Kevin Ryde
2004-06-22 15:51 ` Rob Browning [this message]
2004-07-01  0:40   ` Kevin Ryde
2004-08-12  1:05     ` Rob Browning

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87llifzj3u.fsf@trouble.defaultvalue.org \
    --to=rlb@defaultvalue.org \
    --cc=bug-guile@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).