From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Mark H Weaver Newsgroups: gmane.lisp.guile.bugs Subject: bug#17485: [PATCH 2/3] Rewrite take-right, drop-right, drop-right! Date: Sat, 20 Sep 2014 10:56:12 -0400 Message-ID: <87k34yl4s3.fsf@yeeloong.lan> References: <1401821778-19972-1-git-send-email-dak@gnu.org> <1401821778-19972-2-git-send-email-dak@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1411225171 24835 80.91.229.3 (20 Sep 2014 14:59:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 20 Sep 2014 14:59:31 +0000 (UTC) Cc: 17485@debbugs.gnu.org To: David Kastrup Original-X-From: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Sat Sep 20 16:59:24 2014 Return-path: Envelope-to: guile-bugs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XVM8B-00024f-9U for guile-bugs@m.gmane.org; Sat, 20 Sep 2014 16:59:23 +0200 Original-Received: from localhost ([::1]:34920 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XVM8A-00059e-UD for guile-bugs@m.gmane.org; Sat, 20 Sep 2014 10:59:22 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55589) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XVM82-00059T-EN for bug-guile@gnu.org; Sat, 20 Sep 2014 10:59:20 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XVM7w-0008EM-CV for bug-guile@gnu.org; Sat, 20 Sep 2014 10:59:14 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:55237) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XVM7w-0008Dn-8x for bug-guile@gnu.org; Sat, 20 Sep 2014 10:59:08 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XVM7q-0006Fx-ML for bug-guile@gnu.org; Sat, 20 Sep 2014 10:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mark H Weaver Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Sat, 20 Sep 2014 14:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17485 X-GNU-PR-Package: guile X-GNU-PR-Keywords: Original-Received: via spool by 17485-submit@debbugs.gnu.org id=B17485.141122509723995 (code B ref 17485); Sat, 20 Sep 2014 14:59:02 +0000 Original-Received: (at 17485) by debbugs.gnu.org; 20 Sep 2014 14:58:17 +0000 Original-Received: from localhost ([127.0.0.1]:46801 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XVM76-0006Ev-QC for submit@debbugs.gnu.org; Sat, 20 Sep 2014 10:58:17 -0400 Original-Received: from world.peace.net ([96.39.62.75]:49310) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XVM75-0006En-1Y for 17485@debbugs.gnu.org; Sat, 20 Sep 2014 10:58:15 -0400 Original-Received: from c-98-217-13-77.hsd1.ma.comcast.net ([98.217.13.77] helo=yeeloong.lan) by world.peace.net with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1XVM6y-0006bn-3a; Sat, 20 Sep 2014 10:58:08 -0400 In-Reply-To: <1401821778-19972-2-git-send-email-dak@gnu.org> (David Kastrup's message of "Tue, 3 Jun 2014 20:56:17 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Original-Sender: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.bugs:7559 Archived-At: David Kastrup writes: > * module/srfi/srfi-1.scm (take-right, drop-right, drop-right!): The > definitions tended to be overly complicate and/or rely on pushing > material on the VM stack, detrimental to scalability for Guile 2.0 and > also worse for performance. > > The changed definitions lead to different, more accurate exceptions > being raised. They rely on length+ returning the length of dotted > lists, behavior that is not specified by the SRFI-1 definition but > available in GUILE. Your patches look good to me, except that we can't change 'length+' as you propose. Instead I'd like to add a lax variant of 'length+' with a different name, and use that. I can take care of doing this myself, and will of course still credit you in whatever manner you prefer, but I've run into a legal problem: we don't currently have copyright papers for you on file. Are you willing to file copyright papers for GUILE? Mark