unofficial mirror of bug-guile@gnu.org 
 help / color / mirror / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Rob Browning <rlb@defaultvalue.org>
Cc: 24819-done@debbugs.gnu.org, 24769-done@debbugs.gnu.org
Subject: bug#24769: bug#24819: Intermittent 00-repl-server.test failure in 2.0.13
Date: Fri, 04 Nov 2016 22:50:11 +0100	[thread overview]
Message-ID: <87k2ci7w4s.fsf@gnu.org> (raw)
In-Reply-To: <87a8dn2guc.fsf@trouble.defaultvalue.org> (Rob Browning's message of "Sat, 29 Oct 2016 12:41:15 -0500")

Hello!

Rob Browning <rlb@defaultvalue.org> skribis:

> I noticed that 00-repl-server.test had failed on some of the debian
> buildds like this:
>
>   Running 00-initial-env.test
>   Running 00-repl-server.test
>   FAIL: 00-repl-server.test: repl-server: simple expression - arguments: (expected-value "scheme@(repl-server)> $1 = 42\n" actual-value "$1 = 42\n")

The reason is that ‘repl-reader’ in boot-9.scm goes like this:

  (lambda* (prompt #:optional (reader (fluid-ref current-reader)))
    (if (not (char-ready?))
        (begin
          (display (if (string? prompt) prompt (prompt)))
          (set-port-column! (current-output-port) 0)))
    (force-output)
    (run-hook before-read-hook)
    ((or reader read) (current-input-port)))

Thus, if there’s already data available on the current input port, it
does not print the prompt.

That situation can arise in 00-repl-server.test if we write “(+ 40 2)”
too quickly.

Fixed in 2fbde7f02adb8c6585e9baf6e293ee49cd23d4c4.

Thanks!

Ludo’.





      parent reply	other threads:[~2016-11-04 21:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-29 17:41 bug#24819: Intermittent 00-repl-server.test failure in 2.0.13 Rob Browning
2016-10-29 18:19 ` Rob Browning
2016-11-04 21:50 ` Ludovic Courtès [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k2ci7w4s.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=24769-done@debbugs.gnu.org \
    --cc=24819-done@debbugs.gnu.org \
    --cc=rlb@defaultvalue.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).