From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Newsgroups: gmane.lisp.guile.bugs Subject: bug#52835: [PATCH 0/2] Fix spawning a child not setting standard fds properly Date: Fri, 13 Jan 2023 16:20:28 +0100 Message-ID: <87k01qbgw3.fsf@gnu.org> References: <83e7661b7b89afbe406184b3c12a0310@tailcall.au> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14392"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Cc: 52835-done@debbugs.gnu.org, Josselin Poiret To: Andrew Whatson Original-X-From: bug-guile-bounces+guile-bugs=m.gmane-mx.org@gnu.org Fri Jan 13 16:37:03 2023 Return-path: Envelope-to: guile-bugs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pGM74-0002yk-Cd for guile-bugs@m.gmane-mx.org; Fri, 13 Jan 2023 16:37:02 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pGLrj-0002c5-HS; Fri, 13 Jan 2023 10:21:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pGLrb-0002Xm-I1 for bug-guile@gnu.org; Fri, 13 Jan 2023 10:21:08 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pGLrb-0000Nc-9P for bug-guile@gnu.org; Fri, 13 Jan 2023 10:21:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pGLrb-0005Kb-5A for bug-guile@gnu.org; Fri, 13 Jan 2023 10:21:03 -0500 Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-To: bug-guile@gnu.org Resent-Date: Fri, 13 Jan 2023 15:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 52835 X-GNU-PR-Package: guile X-GNU-PR-Keywords: patch Mail-Followup-To: 52835@debbugs.gnu.org, ludo@gnu.org, dev@jpoiret.xyz Original-Received: via spool by 52835-done@debbugs.gnu.org id=D52835.167362325120445 (code D ref 52835); Fri, 13 Jan 2023 15:21:02 +0000 Original-Received: (at 52835-done) by debbugs.gnu.org; 13 Jan 2023 15:20:51 +0000 Original-Received: from localhost ([127.0.0.1]:52151 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGLrP-0005Jh-19 for submit@debbugs.gnu.org; Fri, 13 Jan 2023 10:20:51 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:56828) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGLrN-0005JN-GY for 52835-done@debbugs.gnu.org; Fri, 13 Jan 2023 10:20:49 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pGLrD-0000FI-77; Fri, 13 Jan 2023 10:20:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=iSD93xd/4K834COndMIgMoK1sxX6o5WFKatbJaxgFxg=; b=Zf7CGQtkGjz3mqdhf2BQ ptgaH3sWovDR3XCJt+GKyIYc+y/Lt+qWUR+M+QQXisFsNhGe5C2nhyMO/pebEGp5DElisrm4UFCi4 U9/+9VJzlCl5Px3GD32ilRa+m2LHEXh6NJywu5gyPx+uWxrosV425rC3hZ6Z3pBQV1NvNvM+KQ8QU 6UbZ+njiIr4FBeQttaP0IetXFcCC7EiGmuw2zECsJdq4hqsCyt+vkL7SIFwJh9jZXDlg6JJ1sbK0a 1nqegg9b2T0YsbRKr8vnZfxtMoOuLEMtJEqYROJKyZ10HNMIEnKdHdi7qnTqPEwrPDf+VmgZn0/vJ 7/LuM23MV6Vo1w==; Original-Received: from [193.50.110.246] (helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pGLrB-0003i1-I6; Fri, 13 Jan 2023 10:20:39 -0500 In-Reply-To: <83e7661b7b89afbe406184b3c12a0310@tailcall.au> (Andrew Whatson's message of "Fri, 13 Jan 2023 11:11:18 +1000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guile-bounces+guile-bugs=m.gmane-mx.org@gnu.org Original-Sender: bug-guile-bounces+guile-bugs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.lisp.guile.bugs:10510 Archived-At: Hi Andrew & Josselin, Andrew Whatson skribis: > Thanks for your work on this, posix_spawn is a nice improvement! > > My comments on the changes in the wip-posix-spawn branch follow. As discussed on IRC, I took your comments into account. I also added a =E2=80=98system*=E2=80=99 test based on what Josselin provided at the begin= ning of this bug report (let=E2=80=99s not forget we were initially fixing an actual bug= :-)) and updated =E2=80=98NEWS=E2=80=99: 527c257d6 Make 'system*' and 'piped-process' internally use 'spawn'. 551929e4f Add 'spawn'. edfca3b7e Update gnulib to 0.1.5414-8204d and add posix_spawn, posix_spaw= np. Let me know if you notice anything fishy! Thanks a lot, Josselin, for your hard work and for your patience. Ludo=E2=80=99.