From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: ludo@gnu.org (Ludovic =?iso-8859-1?Q?Court=E8s?=) Newsgroups: gmane.lisp.guile.bugs Subject: Re: [PATCH] Fix bug: Init auto var to unrandomize `stack_depth' rv. Date: Wed, 13 Jan 2010 11:02:47 +0100 Message-ID: <87iqb67260.fsf@gnu.org> References: <877hrroaux.fsf@ambire.localdomain> <87skadrh67.fsf@ambire.localdomain> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1263377031 8148 80.91.229.12 (13 Jan 2010 10:03:51 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 13 Jan 2010 10:03:51 +0000 (UTC) To: bug-guile@gnu.org Original-X-From: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Wed Jan 13 11:03:44 2010 Return-path: Envelope-to: guile-bugs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NV04c-0000IE-JH for guile-bugs@m.gmane.org; Wed, 13 Jan 2010 11:03:34 +0100 Original-Received: from localhost ([127.0.0.1]:48159 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NV04d-0000Jf-7w for guile-bugs@m.gmane.org; Wed, 13 Jan 2010 05:03:35 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NV04Q-0000IM-JN for bug-guile@gnu.org; Wed, 13 Jan 2010 05:03:22 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NV04L-0000Gr-GJ for bug-guile@gnu.org; Wed, 13 Jan 2010 05:03:21 -0500 Original-Received: from [199.232.76.173] (port=56431 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NV04L-0000Go-6f for bug-guile@gnu.org; Wed, 13 Jan 2010 05:03:17 -0500 Original-Received: from lo.gmane.org ([80.91.229.12]:59662) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NV04K-0007E6-Km for bug-guile@gnu.org; Wed, 13 Jan 2010 05:03:16 -0500 Original-Received: from list by lo.gmane.org with local (Exim 4.50) id 1NV04C-00005y-LD for bug-guile@gnu.org; Wed, 13 Jan 2010 11:03:08 +0100 Original-Received: from laptop-147-210-128-170.labri.fr ([147.210.128.170]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 13 Jan 2010 11:03:08 +0100 Original-Received: from ludo by laptop-147-210-128-170.labri.fr with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 13 Jan 2010 11:03:08 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 23 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: laptop-147-210-128-170.labri.fr X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 24 =?iso-8859-1?Q?Niv=F4se?= an 218 de la =?iso-8859-1?Q?R=E9volution?= X-PGP-Key-ID: 0xEA52ECF4 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 83C4 F8E5 10A3 3B4C 5BEA D15D 77DD 95E2 EA52 ECF4 X-OS: x86_64-unknown-linux-gnu User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) Cancel-Lock: sha1:dtXZy8KhlYXMShUK9ybbjPVA+X8= X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-guile@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Errors-To: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.bugs:4462 Archived-At: Hi, Thien-Thi Nguyen writes: > Often i include some kind of commentary describing the patch or > the motivation of the patch, etc. Where should i include that > info? Maybe "git-format-patch --attach"? I would advise adding explanatory comments in the code, rather than in the log. >From the GCS (info "(standards) Change Log Concepts"): There's no need to describe the full purpose of the changes or how they work together. If you think that a change calls for explanation, you're probably right. Please do explain it--but please put the explanation in comments in the code, where people will see it whenever they see the code. For example, "New function" is enough for the change log when you add a function, because there should be a comment before the function definition to explain what it does. Thanks, Ludo’.