From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Thien-Thi Nguyen Newsgroups: gmane.lisp.guile.bugs Subject: Re: libguile/read.c warning Date: Mon, 15 Feb 2010 15:37:41 +0100 Message-ID: <87iq9ysgy2.fsf@ambire.localdomain> References: <87d407s6uv.fsf@ambire.localdomain> <87635yrgrq.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1266246017 28131 80.91.229.12 (15 Feb 2010 15:00:17 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 15 Feb 2010 15:00:17 +0000 (UTC) To: bug-guile@gnu.org Original-X-From: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Mon Feb 15 16:00:15 2010 Return-path: Envelope-to: guile-bugs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Nh2Qi-0005ts-0s for guile-bugs@m.gmane.org; Mon, 15 Feb 2010 16:00:08 +0100 Original-Received: from localhost ([127.0.0.1]:44099 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nh2Qh-0002F5-5S for guile-bugs@m.gmane.org; Mon, 15 Feb 2010 10:00:07 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nh2Qb-0002F0-V9 for bug-guile@gnu.org; Mon, 15 Feb 2010 10:00:01 -0500 Original-Received: from [140.186.70.92] (port=50121 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nh2Qb-0002Es-8J for bug-guile@gnu.org; Mon, 15 Feb 2010 10:00:01 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Nh2Qa-0006Wd-QT for bug-guile@gnu.org; Mon, 15 Feb 2010 10:00:01 -0500 Original-Received: from host115-67-dynamic.45-79-r.retail.telecomitalia.it ([79.45.67.115]:60614 helo=ambire.localdomain) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nh2Qa-0006WT-Gl for bug-guile@gnu.org; Mon, 15 Feb 2010 10:00:00 -0500 Original-Received: from ttn by ambire.localdomain with local (Exim 4.63) (envelope-from ) id 1Nh24z-0004iJ-40 for bug-guile@gnu.org; Mon, 15 Feb 2010 15:37:41 +0100 In-Reply-To: <87635yrgrq.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Mon, 15 Feb 2010 10:26:49 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.91 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-BeenThere: bug-guile@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Errors-To: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.bugs:4517 Archived-At: () ludo@gnu.org (Ludovic Court=C3=A8s) () Mon, 15 Feb 2010 10:26:49 +0100 Which platform & compiler? $ uname -a Linux ambire 2.6.18-6-k7 #1 SMP Thu Nov 5 16:59:00 UTC 2009 i686 GNU/Linux $ gcc --version gcc (GCC) 4.1.2 20061115 (prerelease) (Debian 4.1.1-21) Inspection shows that (at least, as of commit 69f90b0b0): overflow =3D read_token (port, buffer, READER_CHAR_NAME_MAX_SIZE, &bytes_= read); if (overflow) goto char_error; ... char_error: scm_i_input_error (FUNC_NAME, port, "unknown character name ~a", scm_list_1 (charname)); if there is an overflow condition, `scm_i_input_error' is called with `charname' not yet initialized. This is in `scm_read_character', which differs from the function indicated in the warning message. I think the fix would be to do: if (overflow) scm_i_input_error (FUNC_NAME, port, "character overflow error", SCM_EOL= ); or somesuch. GNU/Linux builds at http://hydra.nixos.org/jobset/gnu/guile-master/all are done with =E2=80=98-Werror=E2=80=99 on GCC 4.4.3 and they don=E2=80= =99t have this problem. Yeah, i'm still clinging onto personal happiness on Debian Etch. It's high time for a dist-upgrade, but then again, look at all the interesting bugs we find on the trailing edge! :-D thi