From: Mark H Weaver <mhw@netris.org>
To: "Göran Weinholt" <goran@weinholt.se>
Cc: 14916@debbugs.gnu.org
Subject: bug#14916: Fixnum procedures can be made to return non-fixnums
Date: Fri, 16 Aug 2013 23:32:32 -0400 [thread overview]
Message-ID: <87ioz5gffz.fsf@tines.lan> (raw)
In-Reply-To: <8738r9ai62.fsf@industria.weinholt.se> ("Göran Weinholt"'s message of "Sat, 20 Jul 2013 07:56:21 +0200")
Göran Weinholt <goran@weinholt.se> writes:
> the fxdiv procedure from (rnrs) fails to check that its result is
> representable as a fixnum:
>
> scheme@(guile-user)> (import (rnrs))
> scheme@(guile-user)> (fxdiv (least-fixnum) -1)
> $1 = 2305843009213693952
>
> It should raise an &implementation-restriction.
Hmm. Currently, our fixnum and flonum operations are implemented in
terms of the generic operations, with added checks. Whereas the most
important generic arithmetic operations compile to VM instructions, the
fixnum and flonum operations compile into procedure calls to scheme code
that performs the checks and then uses the generic ops.
Needless to say, this is terribly slow. I'm reluctant to make that code
any slower by adding more checks.
However, in the coming months I intend to reimplement the fixnum and
flonum operations, using dedicated instructions in the new RTL VM which
will be the basis of Guile 2.2.
It would be possible to backport some of this to Guile 2.0 as well, but
I'm not sure it's worth the effort.
What do you think?
Mark
next prev parent reply other threads:[~2013-08-17 3:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-20 5:56 bug#14916: Fixnum procedures can be made to return non-fixnums Göran Weinholt
2013-08-17 3:32 ` Mark H Weaver [this message]
2013-08-17 7:55 ` Göran Weinholt
2016-06-21 7:20 ` Andy Wingo
2016-06-22 15:32 ` Mark H Weaver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ioz5gffz.fsf@tines.lan \
--to=mhw@netris.org \
--cc=14916@debbugs.gnu.org \
--cc=goran@weinholt.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).