From: Andy Wingo <wingo@pobox.com>
To: taylanbayirli@gmail.com (Taylan Ulrich "Bayırlı/Kammer")
Cc: 21887@debbugs.gnu.org
Subject: bug#21887: 'monitor' form broken
Date: Fri, 24 Jun 2016 18:04:06 +0200 [thread overview]
Message-ID: <87inwyefpl.fsf@pobox.com> (raw)
In-Reply-To: <87vb97s0bp.fsf@T420.taylan> ("Taylan Ulrich \"Bayırlı/Kammer\""'s message of "Thu, 12 Nov 2015 16:29:30 +0100")
Hi Taylan,
On Thu 12 Nov 2015 16:29, taylanbayirli@gmail.com (Taylan Ulrich "Bayırlı/Kammer") writes:
> It seems that the 'monitor' form is currently a no-op. The form
>
> (par-for-each (lambda (x)
> (monitor
> (foo)))
> xs)
>
> should be functionally equivalent to
>
> (let ((mutex (make-mutex)))
> (par-for-each (lambda (x)
> (with-mutex mutex
> (foo)))
> xs))
>
> but currently becomes
>
> (par-for-each (lambda (x)
> (let ((mutex (make-mutex)))
> (with-mutex mutex
> (foo))))
> xs)
>
> which is ineffective.
>
> I don't know what's the best way to fix this. The simplest thing that
> comes to my mind is something along the lines of:
>
> (define-syntax monitor
> (lambda (stx)
> (syntax-case stx ()
> ((_ body body* ...)
> (let ((uuid (generate-uuid)))
> #`(with-mutex (mutex-with-uuid #,uuid)
> body body* ...))))))
>
> where mutex-with-uuid looks it up from a hash table at run-time and
> instantiates it when it doesn't exist, this operation also being
> synchronized across threads, like:
>
> (define mutex-table (make-hash-table))
>
> (define mutex-table-mutex (make-mutex))
>
> (define (mutex-with-uuid uuid)
> (with-mutex mutex-table-mutex
> (or (hash-ref mutex-table uuid)
> (let ((mutex (make-mutex)))
> (hash-set! mutex-table uuid mutex)
> mutex))))
>
> If that looks OK, I can try to make a proper patch from it. I'm not
> sure what I'd use in place of `generate-uuid' though. Would `gensym' be
> good enough?
You're totally right on all points. Please do prepare a patch :) I
wish we could do something faster for the "embedded" mutex but
correctness should come first.
Cheers,
Andy
next prev parent reply other threads:[~2016-06-24 16:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-12 15:29 bug#21887: 'monitor' form broken Taylan Ulrich Bayırlı/Kammer
2016-06-24 16:04 ` Andy Wingo [this message]
2016-06-25 14:51 ` Taylan Ulrich Bayırlı/Kammer
2016-06-27 7:33 ` Andy Wingo
2016-06-27 7:33 ` Andy Wingo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87inwyefpl.fsf@pobox.com \
--to=wingo@pobox.com \
--cc=21887@debbugs.gnu.org \
--cc=taylanbayirli@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).