libguile/socket.c

libguile/socket.c

[hyperdivision]

line 1259 from cvs
libguile/socket.c

size_t c_address_size needs to be set to 0
otherwise gcc4 croaks.

also, i am having no luck getting cvs to work with x86_64
alot of errors and i can't get any of them worked out.
stack overflows, etc.
if you want more specific info i can send the build messages.



_______________________________________________
Bug-guile mailing list
Bug-guile@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-guile

Re: libguile/socket.c

[Neil Jerram]

hyperdivision@firefly.is-a-geek.org (hyperdivision) writes:

> line 1259 from cvs
> libguile/socket.c
>
> size_t c_address_size needs to be set to 0
> otherwise gcc4 croaks.

I wonder if that's because it's generally concerned about
uninitialized variables, or because it's noticed the apparent bug in
scm_c_make_socket_address, which does nothing with its address_size
parameter and instead has another size_t variable on the stack.

Can you try changing scm_c_make_socket_address to this:

{
  struct sockaddr *soka;

  soka = scm_fill_sockaddr (scm_to_ushort (family), address, &args, 1,
			    "scm_c_make_socket_address", &address_size);

  return soka;
}

and report whether that solves the problem?

> also, i am having no luck getting cvs to work with x86_64
> alot of errors and i can't get any of them worked out.
> stack overflows, etc.
> if you want more specific info i can send the build messages.

Yes please.

    Neil



_______________________________________________
Bug-guile mailing list
Bug-guile@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-guile

Re: libguile/socket.c

[Ludovic Courtès]

Hi,

Neil Jerram <neil@ossau.uklinux.net> writes:

> I wonder if that's because it's generally concerned about
> uninitialized variables, or because it's noticed the apparent bug in
> scm_c_make_socket_address, which does nothing with its address_size
> parameter and instead has another size_t variable on the stack.

It's a bug in `scm_c_make_socket_address ()'.  I apologize for this.

> Can you try changing scm_c_make_socket_address to this:
>
> {
>   struct sockaddr *soka;
>
>   soka = scm_fill_sockaddr (scm_to_ushort (family), address, &args, 1,
> 			    "scm_c_make_socket_address", &address_size);
                                                         ^^
Here it should read `address_size', not `&address_size'.

Thanks,
Ludovic.


_______________________________________________
Bug-guile mailing list
Bug-guile@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-guile

Re: libguile/socket.c

[Neil Jerram]

ludovic.courtes@laas.fr (Ludovic Courtès) writes:

> Hi,
>
> Neil Jerram <neil@ossau.uklinux.net> writes:
>
>> I wonder if that's because it's generally concerned about
>> uninitialized variables, or because it's noticed the apparent bug in
>> scm_c_make_socket_address, which does nothing with its address_size
>> parameter and instead has another size_t variable on the stack.
>
> It's a bug in `scm_c_make_socket_address ()'.  I apologize for this.

Thanks for confirming this.  I'll make the change in CVS.

>>   soka = scm_fill_sockaddr (scm_to_ushort (family), address, &args, 1,
>> 			    "scm_c_make_socket_address", &address_size);
>                                                          ^^
> Here it should read `address_size', not `&address_size'.

Indeed, thanks.

        Neil 



_______________________________________________
Bug-guile mailing list
Bug-guile@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-guile

Re: libguile/socket.c

[Marius Vollmer]

Neil Jerram <neil@ossau.uklinux.net> writes:

> Thanks for confirming this.  I'll make the change in CVS.

Please also make this change in the branch_release-1-8 branch if
appropriate.

(I'll make a note so that I don't forget about it myself in case you
can't find time.)

-- 
GPG: D5D4E405 - 2F9B BCCC 8527 692A 04E3  331E FAF8 226A D5D4 E405


_______________________________________________
Bug-guile mailing list
Bug-guile@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-guile

Re: libguile/socket.c

[Neil Jerram]

Marius Vollmer <mvo@zagadka.de> writes:

> Neil Jerram <neil@ossau.uklinux.net> writes:
>
>> Thanks for confirming this.  I'll make the change in CVS.
>
> Please also make this change in the branch_release-1-8 branch if
> appropriate.

Yes, I've done that.

     Neil



_______________________________________________
Bug-guile mailing list
Bug-guile@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-guile

Re: libguile/socket.c

[Marius Vollmer]

Neil Jerram <neil@ossau.uklinux.net> writes:

> Marius Vollmer <mvo@zagadka.de> writes:
>
>> Please also make this change in the branch_release-1-8 branch if
>> appropriate.
>
> Yes, I've done that.

Thanks!

-- 
GPG: D5D4E405 - 2F9B BCCC 8527 692A 04E3  331E FAF8 226A D5D4 E405


_______________________________________________
Bug-guile mailing list
Bug-guile@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-guile

Re: libguile/socket.c

[Ludovic Courtès]

Hi,

Marius Vollmer <mvo@zagadka.de> writes:

> Please also make this change in the branch_release-1-8 branch if
> appropriate.

BTW, what's going to be put in HEAD from now on (apart from what goes in
the 1.8 branch)?

Thanks,
Ludovic.


_______________________________________________
Bug-guile mailing list
Bug-guile@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-guile