From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: ludovic.courtes@laas.fr (Ludovic =?iso-8859-1?Q?Court=E8s?=) Newsgroups: gmane.lisp.guile.bugs Subject: Re: CVS-060720 compilation failure on Solaris 10, patch Date: Thu, 20 Jul 2006 09:52:37 +0200 Organization: LAAS-CNRS Message-ID: <87hd1c67cq.fsf@laas.fr> References: <44BEFCF4.5020301@student.liu.se> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1153382100 20083 80.91.229.2 (20 Jul 2006 07:55:00 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 20 Jul 2006 07:55:00 +0000 (UTC) Cc: bug-guile@gnu.org Original-X-From: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Thu Jul 20 09:54:58 2006 Return-path: Envelope-to: guile-bugs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1G3TN4-0008Jw-G1 for guile-bugs@m.gmane.org; Thu, 20 Jul 2006 09:54:58 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1G3TN3-0003Nd-Qi for guile-bugs@m.gmane.org; Thu, 20 Jul 2006 03:54:57 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1G3TMT-0002mV-23 for bug-guile@gnu.org; Thu, 20 Jul 2006 03:54:21 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1G3TMR-0002kq-3H for bug-guile@gnu.org; Thu, 20 Jul 2006 03:54:20 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1G3TMQ-0002kI-IH for bug-guile@gnu.org; Thu, 20 Jul 2006 03:54:18 -0400 Original-Received: from [140.93.0.15] (helo=laas.laas.fr) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1G3TMY-00039j-Vh for bug-guile@gnu.org; Thu, 20 Jul 2006 03:54:27 -0400 Original-Received: by laas.laas.fr (8.13.7/8.13.4) with SMTP id k6K7sCl3025810; Thu, 20 Jul 2006 09:54:14 +0200 (CEST) Original-To: Claes Wallin X-URL: http://www.laas.fr/~lcourtes/ X-Revolutionary-Date: 2 Thermidor an 214 de la =?iso-8859-1?Q?R=E9volution?= X-PGP-Key-ID: 0xEB1F5364 X-PGP-Key: http://www.laas.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 821D 815D 902A 7EAB 5CEE D120 7FBA 3D4F EB1F 5364 X-OS: powerpc-unknown-linux-gnu Mail-Followup-To: Claes Wallin , bug-guile@gnu.org In-Reply-To: <44BEFCF4.5020301@student.liu.se> (Claes Wallin's message of "Thu, 20 Jul 2006 05:48:04 +0200") User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) X-Spam-Score: 0 () X-Scanned-By: MIMEDefang at CNRS-LAAS X-BeenThere: bug-guile@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Errors-To: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.bugs:3291 Archived-At: Hi, Claes Wallin writes: > guile-CVS-060720 doesn't compile on Solaris 10. Attaching patch. I won't be able to test your patch so here are just a few remarks. > Comments: > - Compiles and passes standalone tests now. Gets stack overflows on > elisp.test and when trying to start 'guile'. Did you compile Guile with optimizations? When using GCC, compiling with `-O0' quickly yields stack overflows (to that point that one doesn't even get to the REPL). > - The sethostname and PTHREAD_ONCE_INIT conditions should be tested for > instead of just slapping a __sun__ on the workarounds. Please help. Sorry, I don't understand this. > - Does any __GNUC__ platform _not_ want alloca.h? I don't known. We should normally not have to touch the `#ifdef's around `alloca ()' since they are the documented way to deal with `alloca ()' [0]. OTOH, the `#ifdef's changed a bit in the Autoconf manual (see [0]), so perhaps we should update them accordingly. Would this solve your problem? Otherwise, you can provide specific details as to why this arrangement fails on your platform and report it to the Autoconf maintainers. :-) In any case, I'd be surprised that it fails on Solaris 10 since this is quite a widespread platform. Also, when submitting a patch, please follow the GNU coding standard for ChangeLog entries and code (see below). > diff -ur ../guile-core/test-suite/standalone/test-list.c ./test-suite/standalone/test-list.c > --- ../guile-core/test-suite/standalone/test-list.c 2006-02-04 00:34:48.000000000 +0100 > +++ ./test-suite/standalone/test-list.c 2006-07-20 04:42:12.000000000 +0200 > @@ -26,7 +26,7 @@ > /* pretty trivial, but ensure this entrypoint exists, since it was > documented in Guile 1.6 and earlier */ > static void > -test_scm_list (void) > +test_scm_list () Is there something wrong with the original form? > diff -ur ../guile-core/test-suite/standalone/test-num2integral.c ./test-suite/standalone/test-num2integral.c > --- ../guile-core/test-suite/standalone/test-num2integral.c 2006-04-17 01:27:13.000000000 +0200 > +++ ./test-suite/standalone/test-num2integral.c 2006-07-20 04:37:41.000000000 +0200 > @@ -141,12 +141,15 @@ > #endif /* SCM_SIZEOF_LONG_LONG != 0 */ > } > > +static void f() { > + test_long_long (); > + test_ulong_long (); > +} > + This should really be something like: static void startup () { ... } > int > main (int argc, char *argv[]) > { > - scm_init_guile(); > - test_long_long (); > - test_ulong_long (); > + scm_boot_guile(argc, argv, f, NULL); `scm_init_guile ()' is documented and perfectly legal in 1.8.0. Is there any reason why you removed it from test cases? Thanks, Ludovic. [0] http://www.gnu.org/software/autoconf/manual/html_node/Particular-Functions.html#Particular-Functions _______________________________________________ Bug-guile mailing list Bug-guile@gnu.org http://lists.gnu.org/mailman/listinfo/bug-guile