From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: taylanbayirli@gmail.com (Taylan Ulrich =?UTF-8?Q?Bay=C4=B1rl=C4=B1/Kammer?=) Newsgroups: gmane.lisp.guile.bugs Subject: bug#22447: (rnrs hashtables): Mutation of immutable hashtable ignored Date: Sun, 24 Jan 2016 12:44:57 +0100 Message-ID: <87h9i3jj5y.fsf@T420.taylan> References: <87lh7fkhoq.fsf@T420.taylan> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ger.gmane.org 1453635741 24104 80.91.229.3 (24 Jan 2016 11:42:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 24 Jan 2016 11:42:21 +0000 (UTC) To: 22447@debbugs.gnu.org Original-X-From: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Sun Jan 24 12:42:12 2016 Return-path: Envelope-to: guile-bugs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aNJ3b-0006wy-T1 for guile-bugs@m.gmane.org; Sun, 24 Jan 2016 12:42:12 +0100 Original-Received: from localhost ([::1]:60020 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aNJ3b-00043b-3Q for guile-bugs@m.gmane.org; Sun, 24 Jan 2016 06:42:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50090) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aNJ3V-00043E-Nv for bug-guile@gnu.org; Sun, 24 Jan 2016 06:42:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aNJ3S-0008D0-HI for bug-guile@gnu.org; Sun, 24 Jan 2016 06:42:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:44559) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aNJ3S-0008Cw-DC for bug-guile@gnu.org; Sun, 24 Jan 2016 06:42:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aNJ3S-00086Y-4v for bug-guile@gnu.org; Sun, 24 Jan 2016 06:42:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: taylanbayirli@gmail.com (Taylan Ulrich =?UTF-8?Q?Bay=C4=B1rl=C4=B1/Kammer?=) Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Sun, 24 Jan 2016 11:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22447 X-GNU-PR-Package: guile X-GNU-PR-Keywords: Original-Received: via spool by 22447-submit@debbugs.gnu.org id=B22447.145363566331083 (code B ref 22447); Sun, 24 Jan 2016 11:42:02 +0000 Original-Received: (at 22447) by debbugs.gnu.org; 24 Jan 2016 11:41:03 +0000 Original-Received: from localhost ([127.0.0.1]:32779 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aNJ2V-00085H-Ej for submit@debbugs.gnu.org; Sun, 24 Jan 2016 06:41:03 -0500 Original-Received: from mail-wm0-f53.google.com ([74.125.82.53]:32837) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aNJ2T-00084d-3u for 22447@debbugs.gnu.org; Sun, 24 Jan 2016 06:41:01 -0500 Original-Received: by mail-wm0-f53.google.com with SMTP id 123so34273207wmz.0 for <22447@debbugs.gnu.org>; Sun, 24 Jan 2016 03:41:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:references:date:in-reply-to:message-id:user-agent :mime-version:content-type; bh=Bm/vcRtHbzvMlBFqLmu8kdvTmzj4Eq8uCP5jylteS+M=; b=H8plbzWqXijVwCwWBj8CckQqtIwYK1pauN3AT7NdmtVJ0pM7KTUNmOLAbQHpG80qll CD/TOavfu6YBVSkAF0tKsJ40mscV03dOsts42OsKOOIon/ytpTqNxBUDVQePVA2nWsmp Zw4Jhg6l1e2rg25fkeU4RtgwV+GPCtHPR2zImwzSysbWpLzSybz4eb4RhCno0wswzSAq SPRhttQMpUbspU9T2F7/V2Dn5w041DtTr5nAn+llEVZm7yqzOmXDNTU7feWz0RB421ye /G2XmGfy5BFilCsOPvYneC1xZc0YTPXsJOJXDVNgY36Yx/CFBGkjhFMAZYasFaeSrFsD dTtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=Bm/vcRtHbzvMlBFqLmu8kdvTmzj4Eq8uCP5jylteS+M=; b=HVUkAceb+N5O9qmjFjfRjbF/Q9hZGnp947VU1nv+uFR+OgE0AjnGq1xfGDMjjMAWZ7 ILLxpmZXTAGpHhWaiIR3y6KGgO30t/7WKRJuV2IKmd1+ROv2V83s4yN4t+jAd4uXCu+0 NCVaGS6RhsUtL2y1vAfLqowie440BzbN2inAgLtJPRU/BOWAVO+ZhFIFChqpA/i7NWOx qpkHIQGKiB/2JpL0H8zBssHb8dSZ5XAKDWzzI8h0enkXuKRXnnrkCsa6vIic9WJzJivM lbDVELSrXQ5m7hS+78N/G5j13Dt0a2z2GlSPl4PKc94PEzv7e6P6msthvDFEp7Xd0XvX dedw== X-Gm-Message-State: AG10YOSa5ehPZQARTBSujfFroKegBf9drSjskSoR6U7zUQxJpC0nLHESHmbC4cSECRHVzg== X-Received: by 10.28.172.193 with SMTP id v184mr13786784wme.94.1453635655470; Sun, 24 Jan 2016 03:40:55 -0800 (PST) Original-Received: from T420.taylan ([2a02:908:c30:3ec0:221:ccff:fe66:68f0]) by smtp.gmail.com with ESMTPSA id l194sm11274623wmb.14.2016.01.24.03.40.53 for <22447@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 24 Jan 2016 03:40:53 -0800 (PST) In-Reply-To: <87lh7fkhoq.fsf@T420.taylan> ("Taylan Ulrich \=\?utf-8\?Q\?\=5C\=22Bay\=C4\=B1rl\=C4\=B1\=2FKammer\=5C\=22\=22's\?\= message of "Sun, 24 Jan 2016 00:19:17 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Original-Sender: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.bugs:7943 Archived-At: --=-=-= Content-Type: text/plain I forgot to change the test suite accordingly. Here's an updated patch. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Hashtable-set-errors-on-immutable-hashtable.patch >From 7483d98cf1e5439ac62ee8da3e216a413853b40c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Taylan=20Ulrich=20Bay=C4=B1rl=C4=B1/Kammer?= Date: Sat, 23 Jan 2016 22:35:24 +0100 Subject: [PATCH 1/2] Hashtable-set! errors on immutable hashtable. * module/rnrs/hashtables.scm (hashtable-set!): Raise an assertion violation error when the hashtable is immutable. --- module/rnrs/hashtables.scm | 5 +++-- test-suite/tests/r6rs-hashtables.test | 6 ++++-- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/module/rnrs/hashtables.scm b/module/rnrs/hashtables.scm index 98d2d76..5773eb1 100644 --- a/module/rnrs/hashtables.scm +++ b/module/rnrs/hashtables.scm @@ -122,8 +122,9 @@ (define (hashtable-set! hashtable key obj) (if (r6rs:hashtable-mutable? hashtable) - (hash-table-set! (r6rs:hashtable-wrapped-table hashtable) key obj)) - *unspecified*) + (hash-table-set! (r6rs:hashtable-wrapped-table hashtable) key obj) + (assertion-violation + 'hashtable-set! "Hashtable is immutable." hashtable))) (define (hashtable-delete! hashtable key) (if (r6rs:hashtable-mutable? hashtable) diff --git a/test-suite/tests/r6rs-hashtables.test b/test-suite/tests/r6rs-hashtables.test index c7812c5..dbf6859 100644 --- a/test-suite/tests/r6rs-hashtables.test +++ b/test-suite/tests/r6rs-hashtables.test @@ -20,6 +20,7 @@ (define-module (test-suite test-rnrs-hashtable) :use-module (ice-9 receive) :use-module ((rnrs hashtables) :version (6)) + :use-module ((rnrs exceptions) :version (6)) :use-module (srfi srfi-1) :use-module (test-suite lib)) @@ -130,8 +131,9 @@ (pass-if "hashtable-copy with mutability #f produces immutable copy" (let ((copied-table (hashtable-copy (make-eq-hashtable) #f))) - (hashtable-set! copied-table 'foo 1) - (not (hashtable-ref copied-table 'foo #f))))) + (guard (exc (else #t)) + (hashtable-set! copied-table 'foo 1) + #f)))) (with-test-prefix "hashtable-clear!" (pass-if "hashtable-clear! removes all values from hashtable" -- 2.6.3 --=-=-=--