From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andy Wingo Newsgroups: gmane.lisp.guile.bugs Subject: bug#19540: repeated ./././ in compiled modules Date: Fri, 24 Jun 2016 10:49:12 +0200 Message-ID: <87fus3geev.fsf@pobox.com> References: <188846A3-246A-49DB-95F0-37FEE6903C85@alumni.caltech.edu> <877fwiy0q2.fsf@gnu.org> <093940B7-4480-4FD4-A0AD-0B19B6FEECDB@alumni.caltech.edu> <87iog117is.fsf@gnu.org> <871t3oqp2e.fsf@pobox.com> <87k2hgoy0c.fsf@gnu.org> <87fus3opto.fsf@pobox.com> <87twgj9eiu.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1466758237 28941 80.91.229.3 (24 Jun 2016 08:50:37 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 24 Jun 2016 08:50:37 +0000 (UTC) Cc: 19540-done@debbugs.gnu.org, Matt Wette To: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Original-X-From: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Fri Jun 24 10:50:22 2016 Return-path: Envelope-to: guile-bugs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bGMob-0000wS-Eo for guile-bugs@m.gmane.org; Fri, 24 Jun 2016 10:50:17 +0200 Original-Received: from localhost ([::1]:42059 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGMoZ-0003rB-F1 for guile-bugs@m.gmane.org; Fri, 24 Jun 2016 04:50:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45370) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGMoQ-0003nl-Ha for bug-guile@gnu.org; Fri, 24 Jun 2016 04:50:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bGMoM-0003fG-9p for bug-guile@gnu.org; Fri, 24 Jun 2016 04:50:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41049) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGMoM-0003fC-7D for bug-guile@gnu.org; Fri, 24 Jun 2016 04:50:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bGMoL-0002V8-Tr for bug-guile@gnu.org; Fri, 24 Jun 2016 04:50:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andy Wingo Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Fri, 24 Jun 2016 08:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19540 X-GNU-PR-Package: guile X-GNU-PR-Keywords: Original-Received: via spool by 19540-done@debbugs.gnu.org id=D19540.14667581659567 (code D ref 19540); Fri, 24 Jun 2016 08:50:01 +0000 Original-Received: (at 19540-done) by debbugs.gnu.org; 24 Jun 2016 08:49:25 +0000 Original-Received: from localhost ([127.0.0.1]:53386 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bGMnk-0002UE-W2 for submit@debbugs.gnu.org; Fri, 24 Jun 2016 04:49:25 -0400 Original-Received: from pb-sasl2.pobox.com ([64.147.108.67]:59342 helo=sasl.smtp.pobox.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bGMnj-0002U7-SW for 19540-done@debbugs.gnu.org; Fri, 24 Jun 2016 04:49:24 -0400 Original-Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by pb-sasl2.pobox.com (Postfix) with ESMTP id 7272020EA4; Fri, 24 Jun 2016 04:49:21 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=sasl; bh=Be6SHy8IjW/z ezDwAqiHxXmIO2I=; b=MJC/pcVCLUqTnOYGh3v2fvrvQk2TwEjoRviQjObWSbrc 0Y+pq32uMFrln4yLGgcTBMgpfsk/yJvtr6AjYwm9O/KVif37A3Zsu7FXUJqbPyE9 7JXbQjXDRc7ENwas/CCHRTqLzAf0EpS+14u79yuvQWFRvraFLeIzQUuiYo1dLdk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; q=dns; s=sasl; b=DK8uiC +I0fday0TIJX/PPWcBGoWsmF0oX0+4gotXNxchjcHH8R8vTvFViZobgSqOletf1B HZYxGxcQUxONeZ4viJh2P7V39M4mXhZKWYsazuwPYehLI9sllaitCqh3upxeW8rX e3qlXnJ8+AyeslMTc4FbG8orB8nZ+jSj77KII= Original-Received: from pb-sasl2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-sasl2.pobox.com (Postfix) with ESMTP id 5A62C20EA2; Fri, 24 Jun 2016 04:49:21 -0400 (EDT) Original-Received: from clucks (unknown [88.160.190.192]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by pb-sasl2.pobox.com (Postfix) with ESMTPSA id 3D58520EA1; Fri, 24 Jun 2016 04:49:19 -0400 (EDT) In-Reply-To: <87twgj9eiu.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Fri, 24 Jun 2016 10:28:41 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) X-Pobox-Relay-ID: 8ADD2810-39E8-11E6-8B69-28A6F1301B6D-02397024!pb-sasl2.pobox.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Original-Sender: "bug-guile" Xref: news.gmane.org gmane.lisp.guile.bugs:8214 Archived-At: Hi :) On Fri 24 Jun 2016 10:28, ludo@gnu.org (Ludovic Court=C3=A8s) writes: > Hello! > > Andy Wingo skribis: > >> On Thu 23 Jun 2016 15:06, ludo@gnu.org (Ludovic Court=C3=A8s) writes: >> >>> =E2=80=98canonicalize_file_name=E2=80=99 is costly: roughly one syscall= per file name >>> component. >>> >>> IIUC, =E2=80=98canonicalize_file_name=E2=80=99 is now called once for e= ach =E2=80=98%load-path=E2=80=99 >>> entry and file name that we canonicalize. Is this correct? >> >> That's correct, but only for relative canonicalization, which is in >> practive only when loading Scheme files from source. Seems out of the >> hot path; what do you think? > > I think it=E2=80=99s likely to have a noticeable impact on startup time f= or > projects with a large number of modules like Guix. Aren't they usually compiled? Loading compiled files will not go through this path AFAIU. > For instance, commands like =E2=80=98guix package -A=E2=80=99 or =E2=80= =98guix build foo=E2=80=99 load > all the modules. The impact will be smaller on a laptop with an SSD > than on an NFS mount, where it=E2=80=99s likely going to be terrrible (th= is > could be tested using the =E2=80=98delay=E2=80=99 device mapper.) Oh I'm with you that we need to be careful here. I am under the impression though that there's no additional impact here because this is just something that happens at compile-time. Or if you load a source file, but in that case you're evaluating and expecting a perf loss is not the end of the world. Andy