From: "Ludovic Courtès" <ludo@gnu.org>
To: Andrew Whatson <whatson@gmail.com>
Cc: hylophile@posteo.de, 59321-done@debbugs.gnu.org
Subject: bug#59321: ice-9's open-input-pipe is unexpectedly slow on some systems
Date: Fri, 13 Jan 2023 16:37:24 +0100 [thread overview]
Message-ID: <87fscebg3v.fsf@gnu.org> (raw)
In-Reply-To: <CAPE069diUWciWtkEdcKz68gJAHbjXQWozwwOA2_wd7vdM0cPug@mail.gmail.com> (Andrew Whatson's message of "Thu, 8 Dec 2022 22:02:04 +1000")
Hello!
Andrew Whatson <whatson@gmail.com> skribis:
> commit c012d7b0d5248a99a3a92780687a676c5d420f5f
> Author: Andrew Whatson <whatson@gmail.com>
> Date: Thu Dec 8 21:43:28 2022 +1000
>
> Reduce redundant close() calls when forking on some systems.
>
> Some systems provide "/proc/self/fd" which is a directory containing an
> entry for each open file descriptor in the current process. We use this
> to limit the number of close() calls needed to ensure file descriptors
> aren't leaked to the child process when forking.
>
> * libguile/posix.c (close_inherited_fds_slow):
> (close_inherited_fds): New static helper functions.
> (scm_spawn_process): Attempt to close inherited file descriptors
> efficiently using 'close_inherited_fds', falling back to the brute-force
> approach in 'close_inherited_fds_slow'.
Finally applied on top of the ‘posix_spawn’ series as commit
9332b632407894c2e1951cce1bc678f19e1fa8e4.
Thanks!
Ludo’.
prev parent reply other threads:[~2023-01-13 15:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-16 18:06 bug#59321: ice-9's open-input-pipe is unexpectedly slow on some systems hylophile
2022-11-18 4:49 ` Andrew Whatson
2022-11-18 5:52 ` tomas
2022-11-20 17:24 ` Ludovic Courtès
2022-11-20 19:00 ` tomas
2022-11-21 4:22 ` Andrew Whatson
2022-11-26 14:39 ` Ludovic Courtès
2022-12-08 12:02 ` Andrew Whatson
2022-12-08 14:34 ` Ludovic Courtès
2023-01-13 15:37 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fscebg3v.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=59321-done@debbugs.gnu.org \
--cc=hylophile@posteo.de \
--cc=whatson@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).