missing gnulib modules

missing gnulib modules

[Giuseppe Scrivano]

Hello,

I got some linker errors while compiling the latest guile git revision.

I had to include some other gnulib modules to get it working, by this
command:

../gnulib/gnulib-tool --import --dir=. --lib=libgnu --source-base=lib \
--m4-base=m4 --doc-base=doc --tests-base=tests --aux-dir=build-aux \
--lgpl --libtool --macro-prefix=gl --no-vc-files alloca-opt autobuild \
byteswap canonicalize-lgpl count-one-bits environ extensions flock \
fpieee full-read full-write havelib iconv_open-utf lib-symbol-versions \
lib-symbol-visibility libunistring putenv stdlib strcase strftime \
striconveh string verify vsnprintf unicase/u32-ct-tolower \
unistr/u8-strnlen   unicase/tolower  uniconv/u32-conv-from-enc \
unicase/u32-casemap unistdio/ulc-fprintf uniconv/u8-strconv-from-locale \
unictype/syntax-c-whitespace   unictype/property-ascii-hex-digit \
unictype/numeric unictype/property-decimal-digit 

Does anybody have this problem too?

Cheers,
Giuseppe

Re: missing gnulib modules

[Ludovic Courtès]

Hi!

Giuseppe Scrivano <gscrivano@gnu.org> writes:

> I got some linker errors while compiling the latest guile git revision.

In `master', right?

I don't have any problems, but it could be that I have stale Gnulib
files anyway.

Can you post the exact error messages?  (You need to start from a
pristine tree where you haven't run `gnulib-tool'.)

Thanks,
Ludo'.

Re: missing gnulib modules

[Giuseppe Scrivano]

Hello,

this is the error I get inside libguile/ on a pristine `master':

gen-scmconfig.c:128:21: error: uniconv.h: No such file or directory
gen-scmconfig.c: In function ‘main’:
gen-scmconfig.c:430: error: ‘iconveh_error’ undeclared (first use in this function)
gen-scmconfig.c:430: error: (Each undeclared identifier is reported only once
gen-scmconfig.c:430: error: for each function it appears in.)
gen-scmconfig.c:432: error: ‘iconveh_question_mark’ undeclared (first use in this function)
gen-scmconfig.c:434: error: ‘iconveh_escape_sequence’ undeclared (first use in this function)
make[2]: *** [gen-scmconfig.o] Error 1

Cheers,
Giuseppe


ludo@gnu.org (Ludovic Courtès) writes:

> Hi!
>
> Giuseppe Scrivano <gscrivano@gnu.org> writes:
>
>> I got some linker errors while compiling the latest guile git revision.
>
> In `master', right?
>
> I don't have any problems, but it could be that I have stale Gnulib
> files anyway.
>
> Can you post the exact error messages?  (You need to start from a
> pristine tree where you haven't run `gnulib-tool'.)
>
> Thanks,
> Ludo'.

Re: missing gnulib modules

[Ludovic Courtès]

Hi Giuseppe,

Giuseppe Scrivano <gscrivano@gnu.org> writes:

> this is the error I get inside libguile/ on a pristine `master':
>
> gen-scmconfig.c:128:21: error: uniconv.h: No such file or directory

<uniconv.h> comes from GNU libunistring.  So it looks like we got the
CPPFLAGS wrong or something.

Now, I remember that `configure' won't bail out if libunistring is not
found (but it really should!).  Can you grep for "libunistring" in
`config.log'?

Thanks,
Ludo'.

Re: missing gnulib modules

[Giuseppe Scrivano]

ludo@gnu.org (Ludovic Courtès) writes:

> Hi Giuseppe,
>
> Giuseppe Scrivano <gscrivano@gnu.org> writes:
>
>> this is the error I get inside libguile/ on a pristine `master':
>>
>> gen-scmconfig.c:128:21: error: uniconv.h: No such file or directory
>
> <uniconv.h> comes from GNU libunistring.  So it looks like we got the
> CPPFLAGS wrong or something.
>
> Now, I remember that `configure' won't bail out if libunistring is not
> found (but it really should!).  Can you grep for "libunistring" in
> `config.log'?

This is what I get:

ac_cv_libunistring='no, consider installing GNU libunistring'


Now I remember that I don't have this same problem on another machine
where libunistring is installed.  I don't know if there are differences
between libunistring and the gnulib modules, in case they are the same
wouldn't be better to use the latter, considering that guile is already
using gnulib?

Cheers,
Giuseppe

Re: missing gnulib modules

[Ludovic Courtès]

Giuseppe Scrivano <gscrivano@gnu.org> writes:

> This is what I get:
>
> ac_cv_libunistring='no, consider installing GNU libunistring'

We need to fix `configure' so that it throws an error in this case.

> Now I remember that I don't have this same problem on another machine
> where libunistring is installed.  I don't know if there are differences
> between libunistring and the gnulib modules, in case they are the same
> wouldn't be better to use the latter, considering that guile is already
> using gnulib?

Yes, this is the same code, but no, I don't think we should use Gnulib
modules.  GNU libunistring was actually started as an independent
project after the corresponding modules had been imported in Gnulib.  I
think libunistring may eventually become a dependency of several
components in GNU, so it makes sense to just share the code among them,
rather than having N different copies of the code.

Thanks,
Ludo'.

Re: missing gnulib modules

[Andy Wingo]

On Wed 02 Sep 2009 15:11, ludo@gnu.org (Ludovic Courtès) writes:

>> ac_cv_libunistring='no, consider installing GNU libunistring'
>
> We need to fix `configure' so that it throws an error in this case.

I guess we need to pull in the configure.ac patch from
1ee2c72eafaae5f91f4c899bc4b4853af5c16f28 again. Are you certain that
f4863880f5ef539cb545999c19b6b5c0eec9382d was not correct? I don't see
why gnulib is checking for libunistring at all.

Andy
-- 
http://wingolog.org/

Re: missing gnulib modules

[Giuseppe Scrivano]

Hello Andy,

I confirm that I get the same check using the revision
f4863880f5ef539cb545999c19b6b5c0eec9382d.

I have this in config.log (it has a different value because I have
installed the library):

ac_cv_libunistring=yes

Giuseppe

Andy Wingo <wingo@pobox.com> writes:

> On Wed 02 Sep 2009 15:11, ludo@gnu.org (Ludovic Courtès) writes:
>
>>> ac_cv_libunistring='no, consider installing GNU libunistring'
>>
>> We need to fix `configure' so that it throws an error in this case.
>
> I guess we need to pull in the configure.ac patch from
> 1ee2c72eafaae5f91f4c899bc4b4853af5c16f28 again. Are you certain that
> f4863880f5ef539cb545999c19b6b5c0eec9382d was not correct? I don't see
> why gnulib is checking for libunistring at all.
>
> Andy

Re: missing gnulib modules

[Ludovic Courtès]

Andy Wingo <wingo@pobox.com> writes:

> On Wed 02 Sep 2009 15:11, ludo@gnu.org (Ludovic Courtès) writes:
>
>>> ac_cv_libunistring='no, consider installing GNU libunistring'
>>
>> We need to fix `configure' so that it throws an error in this case.
>
> I guess we need to pull in the configure.ac patch from
> 1ee2c72eafaae5f91f4c899bc4b4853af5c16f28 again. 

Yes.

> Are you certain that f4863880f5ef539cb545999c19b6b5c0eec9382d was not
> correct?

Yes.

> I don't see why gnulib is checking for libunistring at all.

As mentioned in 18c73f8e2bc4a184db62a975fa5bf2fdf43453e1, Gnulib's
`gl_LIBUNISTRING' (which is automatically called since we use the
`libunistring' module) does this already, and doing it twice just
doesn't work.

Thanks,
Ludo'.