[PATCH] lambda* fails with #:key and rest argument

[PATCH] lambda* fails with #:key and rest argument

[Christopher Cramer]

Here's the problem:

guile> (use-modules (ice-9 optargs))
guile> (lambda* (#:key foo . bar) #t)
/usr/local/share/guile/1.5.6/ice-9/optargs.scm:371:24: In procedure list-copy in expression (list-copy arglist):
/usr/local/share/guile/1.5.6/ice-9/optargs.scm:371:24: Wrong type argument in position 1: (#:key foo . bar)
ABORT: (wrong-type-arg)

Basically, there's a part where it tries to copy an improper list
with list-copy, which doesn't work. The solution lies in creating
improper-list-copy. At first I just put a new function in list.c (which
is trivial: copy scm_list_copy to scm_improper_list_copy and change
SCM_VALIDATE_LIST to SCM_VALIDATE_CONS), but then I figured I wanted
it fixed in stable, and we probably don't want a new public procedure at
this point.

Index: ice-9/optargs.scm
===================================================================
RCS file: /cvsroot/guile/guile/guile-core/ice-9/optargs.scm,v
retrieving revision 1.14.2.3
diff -u -r1.14.2.3 optargs.scm
--- ice-9/optargs.scm	18 Oct 2001 19:41:08 -0000	1.14.2.3
+++ ice-9/optargs.scm	30 May 2002 18:26:05 -0000
@@ -368,7 +368,7 @@
      ((null? arglist) (cont '() '() '() #f #f))
      ((not (pair? arglist)) (cont '() '() '() #f arglist))
      ((not (list? arglist))
-	  (let* ((copy (list-copy arglist))
+	  (let* ((copy (improper-list-copy arglist))
 		 (lp (last-pair copy))
 		 (ra (cdr lp)))
 	    (set-cdr! lp '())
@@ -387,7 +387,16 @@
 
   (parse-rest arglist cont))
 
-
+(define (improper-list-copy l)
+    (let ((out '()))
+	(let loop ((in l) (prev '()))
+	    (if (pair? in)
+		(let ((cur (cons (car in) (cdr in))))
+		    (if (null? prev)
+			(set! out cur)
+			(set-cdr! prev cur))
+		    (loop (cdr in) cur))
+		out))))
 
 ;; define* args . body
 ;; define*-public args . body

-- 
Christopher Cramer <crayc@pyro.net> <http://www.pyro.net/~crayc/>
On résiste à l'invasion des armées; on ne résiste pas à l'invasion
des idées.  -- Victor Hugo

_______________________________________________
Bug-guile mailing list
Bug-guile@gnu.org
http://mail.gnu.org/mailman/listinfo/bug-guile

Re: [PATCH] lambda* fails with #:key and rest argument

[Thien-Thi Nguyen]

   From: Christopher Cramer <crayc@pyro.net>
   Date: Thu, 30 May 2002 13:44:11 -0500

   Index: ice-9/optargs.scm

thanks for the patch.  i've applied it for 1.4.2.

thi

_______________________________________________
Bug-guile mailing list
Bug-guile@gnu.org
http://mail.gnu.org/mailman/listinfo/bug-guile

Re: [PATCH] lambda* fails with #:key and rest argument

[Dirk Herrmann]

On Sat, 29 Jun 2002, Thien-Thi Nguyen wrote:

>    From: Christopher Cramer <crayc@pyro.net>
>    Date: Thu, 30 May 2002 13:44:11 -0500
> 
>    Index: ice-9/optargs.scm
> 
> thanks for the patch.  i've applied it for 1.4.2.
> 
> thi

Hi,

I assume that the problem is also relevant for the newer branches.  
There, we could think of providing a public improper-list-copy in list.c
instead of providing it privately within optargs.scm.  Do we want that?

Best regards,
Dirk


_______________________________________________
Bug-guile mailing list
Bug-guile@gnu.org
http://mail.gnu.org/mailman/listinfo/bug-guile

Re: [PATCH] lambda* fails with #:key and rest argument

[Marius Vollmer]

Dirk Herrmann <dirk@sallust.ida.ing.tu-bs.de> writes:

> I assume that the problem is also relevant for the newer branches.  
> There, we could think of providing a public improper-list-copy in list.c
> instead of providing it privately within optargs.scm.  Do we want that?

Yes, that looks like the better option to me.  What names are other
Schemes using for this operation?  We shouldn't be gratuitously
incompatible.  Also, should improper-list-copy be able to copy
circular lists, or only dotted lists?

SRFI-1 list-copy can copy dotted lists.  Maybe we can just use it.

_______________________________________________
Bug-guile mailing list
Bug-guile@gnu.org
http://mail.gnu.org/mailman/listinfo/bug-guile

Re: [PATCH] lambda* fails with #:key and rest argument

[Marius Vollmer]

Marius Vollmer <mvo@zagadka.ping.de> writes:

> SRFI-1 list-copy can copy dotted lists.  Maybe we can just use it.

But ours can't since it is the core list-copy!  Bugger!

_______________________________________________
Bug-guile mailing list
Bug-guile@gnu.org
http://mail.gnu.org/mailman/listinfo/bug-guile

Re: [PATCH] lambda* fails with #:key and rest argument

[Dirk Herrmann]

On 8 Jul 2002, Marius Vollmer wrote:

> Marius Vollmer <mvo@zagadka.ping.de> writes:
> 
> > SRFI-1 list-copy can copy dotted lists.  Maybe we can just use it.
> 
> But ours can't since it is the core list-copy!  Bugger!

Hmmm... So what should we do?  Provide a separate SRFI-1 list-copy, or
change the core list-copy?

Best regards,
Dirk Herrmann


_______________________________________________
Bug-guile mailing list
Bug-guile@gnu.org
http://mail.gnu.org/mailman/listinfo/bug-guile