unofficial mirror of bug-guile@gnu.org 
 help / color / mirror / Atom feed
From: Thien-Thi Nguyen <ttn@gnuvola.org>
To: bug-guile@gnu.org
Subject: Re: [PATCH] Declare `GC_dump' ourselves if <gc/gc.h> doesn't.
Date: Tue, 12 Jan 2010 19:51:49 +0100	[thread overview]
Message-ID: <87d41fma0q.fsf@ambire.localdomain> (raw)
In-Reply-To: <87my0jfdfz.fsf@gnu.org> ("Ludovic Courtès"'s message of "Tue, 12 Jan 2010 18:19:44 +0100")

() ludo@gnu.org (Ludovic Courtès)
() Tue, 12 Jan 2010 18:19:44 +0100

   > | dnl See note for PKG_CHECK_MODULES in aclocal.m4.
   > | PKG_PROG_PKG_CONFIG
   > | if test "$BDW_GC_CFLAGS" || test "$BDW_GC_LIBS" ; then :
   > |   dnl We don't need to declare those env vars precious;
   > |   dnl PKG_CHECK_MODULES does that.
   > | else
   > |   PKG_CHECK_MODULES([BDW_GC], [bdw-gc])
   > | fi

   This patch shouldn’t be necessary since it duplicates what
   ‘PKG_CHECK_MODULES’ does.

Not exactly.  If there is no bdw-gc.pc on the system (as is the
case here on a Debian Etch installation),  PKG_CHECK_MODULES dies,
and so does the configure script.  The original README recommends
in such case to munge three variables.  Two of them are valid:
BDW_GC_CFLAGS and BDW_GC_LIBS.  The other (PKG_CONFIG) is bogus
because munging it interferes with "make installcheck".

   ... without reading ‘README’, so you basically shoot yourself
   in the foot and there’s not much we can do.  :-)

I don't know where you got that idea.  Here's what actually
happened: I read the README, applied the bogus advice, noticed the
breakage, and then worked on the patch so that the now-updated
README gives good advice, supported by the now-updated configure
script.  Lastly, i posted the patch for review.

There IS something you can do: take a stand against pkg-config and
DTRT (the Autoconf Way).  I know there are other packages that are
heavily reliant on pkg-config, but Guile doesn't seem to be one of
them.  You can do this by helping identify what are the features
of libgc (whatever version) that Guile requires.  With that info,
it would not be hard to write a test for the configure script.
So, please help answer that question (if you can).

thi




  reply	other threads:[~2010-01-12 18:51 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-09 13:28 [PATCH] Declare `GC_dump' ourselves if <gc/gc.h> doesn't Thien-Thi Nguyen
2010-01-09 22:30 ` Andy Wingo
2010-01-10  2:37   ` Ken Raeburn
2010-01-11 22:09   ` Ludovic Courtès
2010-01-11 22:32     ` Ludovic Courtès
2010-01-12  4:51       ` Thien-Thi Nguyen
2010-01-12  4:40     ` Thien-Thi Nguyen
2010-01-12 14:17       ` Ludovic Courtès
2010-01-12 15:36         ` Thien-Thi Nguyen
2010-01-12 17:19           ` Ludovic Courtès
2010-01-12 18:51             ` Thien-Thi Nguyen [this message]
2010-01-12 19:33               ` Andy Wingo
2010-01-12 19:29     ` Andy Wingo
2010-01-12 22:42       ` Ludovic Courtès
2010-01-17 22:01   ` Neil Jerram

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d41fma0q.fsf@ambire.localdomain \
    --to=ttn@gnuvola.org \
    --cc=bug-guile@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).