Re: Weak Vectors Patch

[ludo@gnu.org (Ludovic Courtès)]

[-- Attachment #1: Type: text/plain, Size: 2274 bytes --]

Hi!

Clinton Ebadi <clinton@unknownlamer.org> writes:

> ludo@gnu.org (Ludovic Courtès) writes:

[...]

>> The patch looks good to me, modulo a few things:
>>
>>   - Could you make it 3 (or 4?) different patches, each with a test case
>>     showing what is being fixed?
>>
>>   - If that’s fine with you, you’ll need to assign copyright to the
>>     FSF.  We can arrange this off-list.
>
> I have attached a series of three patches with reformatted GNU style
> commit logs and the gnu coding style violations fixed.

Cool, thanks!

> I talked to wingo, and he suggested that (equal? WEAK-VECTOR VECTOR) =>
> #f;

Hmm what’s the motivation?  It seems more intuitive to me to have, e.g.,

  (equal? (make-vector 3 4) (make-weak-vector 3 4))
  => #t

> How do you want to handle copyright assignment?

The usual way.  ;-)

So, would you be willing to assign the copyright to the Free Software
Foundation, so that we could install it in Guile?

If so, please send the form below to assign@gnu.org.  They’ll then send
you the actual copyright assignment form by snail mail, which you’ll
have to sign and send back, after which we can integrate these and
future changes by you in Guile.

Thanks!

Ludo’.


Please email the following information to assign@gnu.org, and we
will send you the assignment form for your past and future changes.

Please use your full legal name (in ASCII characters) as the subject
line of the message.
----------------------------------------------------------------------
REQUEST: SEND FORM FOR PAST AND FUTURE CHANGES

[What is the name of the program or package you're contributing to?]


[Did you copy any files or text written by someone else in these changes?
Even if that material is free software, we need to know about it.]


[Do you have an employer who might have a basis to claim to own
your changes?  Do you attend a school which might make such a claim?]


[For the copyright registration, what country are you a citizen of?]


[What year were you born?]


[Please write your email address here.]


[Please write your postal address here.]





[Which files have you changed so far, and which new files have you written
so far?]







[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]