From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Newsgroups: gmane.lisp.guile.bugs Subject: bug#17418: #:select gives access to private variables Date: Tue, 21 Jun 2016 18:06:12 +0200 Message-ID: <87d1na7ci3.fsf@gnu.org> References: <87sion47ji.fsf@gnu.org> <8738fo2k7q.fsf@yeeloong.lan> <87vbsj4ttv.fsf@gnu.org> <87ioohvbeh.fsf@yeeloong.lan> <87egz5vb9g.fsf@yeeloong.lan> <87twgmy6z7.fsf@pobox.com> <87ziqe7fx2.fsf@gnu.org> <87wpliwozj.fsf@pobox.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1466525246 30353 80.91.229.3 (21 Jun 2016 16:07:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 21 Jun 2016 16:07:26 +0000 (UTC) Cc: 17418-done@debbugs.gnu.org To: Andy Wingo Original-X-From: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Tue Jun 21 18:07:16 2016 Return-path: Envelope-to: guile-bugs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bFOCp-0004Hj-Cg for guile-bugs@m.gmane.org; Tue, 21 Jun 2016 18:07:15 +0200 Original-Received: from localhost ([::1]:52855 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFOCo-0002vs-CV for guile-bugs@m.gmane.org; Tue, 21 Jun 2016 12:07:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37916) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFOCf-0002uX-Hk for bug-guile@gnu.org; Tue, 21 Jun 2016 12:07:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bFOCc-0007b6-LX for bug-guile@gnu.org; Tue, 21 Jun 2016 12:07:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:37629) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFOCc-0007b2-IF for bug-guile@gnu.org; Tue, 21 Jun 2016 12:07:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bFOCc-0007iV-ER for bug-guile@gnu.org; Tue, 21 Jun 2016 12:07:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Tue, 21 Jun 2016 16:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17418 X-GNU-PR-Package: guile X-GNU-PR-Keywords: Original-Received: via spool by 17418-done@debbugs.gnu.org id=D17418.146652519029616 (code D ref 17418); Tue, 21 Jun 2016 16:07:02 +0000 Original-Received: (at 17418-done) by debbugs.gnu.org; 21 Jun 2016 16:06:30 +0000 Original-Received: from localhost ([127.0.0.1]:49966 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bFOC6-0007hc-LW for submit@debbugs.gnu.org; Tue, 21 Jun 2016 12:06:30 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:46734) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bFOC2-0007hM-DK for 17418-done@debbugs.gnu.org; Tue, 21 Jun 2016 12:06:29 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bFOBr-0007Tu-QE for 17418-done@debbugs.gnu.org; Tue, 21 Jun 2016 12:06:21 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:47278) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFOBr-0007To-NE; Tue, 21 Jun 2016 12:06:15 -0400 Original-Received: from pluto.bordeaux.inria.fr ([193.50.110.57]:43552 helo=pluto) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bFOBq-0004Tl-Pi; Tue, 21 Jun 2016 12:06:15 -0400 X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 4 Messidor an 224 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-unknown-linux-gnu In-Reply-To: <87wpliwozj.fsf@pobox.com> (Andy Wingo's message of "Tue, 21 Jun 2016 17:17:20 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Original-Sender: "bug-guile" Xref: news.gmane.org gmane.lisp.guile.bugs:8111 Archived-At: Andy Wingo skribis: > On Tue 21 Jun 2016 16:52, ludo@gnu.org (Ludovic Court=C3=A8s) writes: > >> Andy Wingo skribis: >> >>> On Wed 04 Jun 2014 01:11, Mark H Weaver writes: >>> >>>> Mark H Weaver writes: >>>>> Sounds good. Specifically, I guess we should deprecate this way of >>>>> using #:select. >>>>> >>>>> If you do this, can you adjust system/repl/coop-server.scm to avoid i= t? >>>>> It imports the following private bindings: >>>>> >>>>> start-repl* run-server* add-open-socket! close-socket! >>>> >>>> Also: prompting-meta-read >>> >>> Fixed in master. >> >> I would not close the bug if it remains in 2.0.x. Thoughts? > > I think we can't break 2.0 in this regard; it's technically > incompatible. We could print a better deprecation warning but in this > case I think I did the right thing. WDYT? Yeah, you=E2=80=99re probably right; it would suddenly lead to unbound variables, whether or not people realized they were relying on =E2=80=9Cunspecified=E2=80=9D behavior. I withdraw my remark! Ludo=E2=80=99.