From: Ricardo Wurmus <rekado@elephly.net>
To: Mark H Weaver <mhw@netris.org>
Cc: 32528@debbugs.gnu.org
Subject: bug#32528: http-post breaks with XML response payload containing boundary
Date: Wed, 29 Aug 2018 12:26:02 +0200 [thread overview]
Message-ID: <87d0u1bhad.fsf@elephly.net> (raw)
In-Reply-To: <87bm9mf9d9.fsf@netris.org>
Hi Mark,
> Ricardo Wurmus <rekado@elephly.net> writes:
>
[…]
>> The reason why it fails is that Guile processes the response and treats
>> the *payload* contained in the XML response as HTTP.
>
> No, this was a good guess, but it's not actually the problem.
You are right. I also ended up trying with “wget --save-headers” after
sending the bug report and noticed the offending header like you did:
> Content-Type: multipart/related; type="text/xml"; start="<main_envelope>"; boundary="=-=-="
>
> <?xml [...]
I assumed it was part of the payload when it really was a regular
header after all.
> The problem is simply that our Content-Type header parser is broken.
> It's very simplistic and merely splits the string wherever ';' is found,
> and then checks to make sure there's only one '=' in each parameter,
> without taking into account that quoted strings in the parameters might
> include those characters.
Right. I worked around this in guile-debbugs simply by replacing the
Content-Type header parser with one that lacks the check for the unique
“=” in the string part.
> I'll work on a proper parser for Content-Type headers.
Thanks!
--
Ricardo
prev parent reply other threads:[~2018-08-29 10:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-25 8:49 bug#32528: http-post breaks with XML response payload containing boundary Ricardo Wurmus
2018-08-28 21:51 ` Mark H Weaver
2018-08-29 3:28 ` Mark H Weaver
2019-06-25 8:25 ` Ludovic Courtès
2018-08-29 10:26 ` Ricardo Wurmus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d0u1bhad.fsf@elephly.net \
--to=rekado@elephly.net \
--cc=32528@debbugs.gnu.org \
--cc=mhw@netris.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).