From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Rob Browning Newsgroups: gmane.lisp.guile.bugs Subject: bug#43521: ports.test "non-revealed port is closed" breaks other tests Date: Sat, 19 Sep 2020 14:35:26 -0500 Message-ID: <87d02h5zlt.fsf@trouble.defaultvalue.org> References: <87ft7d601y.fsf@trouble.defaultvalue.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36038"; mail-complaints-to="usenet@ciao.gmane.io" To: 43521@debbugs.gnu.org Original-X-From: bug-guile-bounces+guile-bugs=m.gmane-mx.org@gnu.org Sat Sep 19 21:36:07 2020 Return-path: Envelope-to: guile-bugs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kJieV-0009G1-3X for guile-bugs@m.gmane-mx.org; Sat, 19 Sep 2020 21:36:07 +0200 Original-Received: from localhost ([::1]:35488 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kJieT-0007zQ-Th for guile-bugs@m.gmane-mx.org; Sat, 19 Sep 2020 15:36:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59862) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJieQ-0007zG-Ky for bug-guile@gnu.org; Sat, 19 Sep 2020 15:36:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36609) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kJieQ-0007Ec-Bw for bug-guile@gnu.org; Sat, 19 Sep 2020 15:36:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kJieQ-000769-9B for bug-guile@gnu.org; Sat, 19 Sep 2020 15:36:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Rob Browning Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Sat, 19 Sep 2020 19:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43521 X-GNU-PR-Package: guile X-Debbugs-Original-To: bug-guile@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.160054413127246 (code B ref -1); Sat, 19 Sep 2020 19:36:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 19 Sep 2020 19:35:31 +0000 Original-Received: from localhost ([127.0.0.1]:48155 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJidv-00075O-La for submit@debbugs.gnu.org; Sat, 19 Sep 2020 15:35:31 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:58372) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJidu-00075H-TV for submit@debbugs.gnu.org; Sat, 19 Sep 2020 15:35:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59822) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJidu-0007sa-Lh for bug-guile@gnu.org; Sat, 19 Sep 2020 15:35:30 -0400 Original-Received: from defaultvalue.org ([45.33.119.55]:37504) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kJids-00077H-8i for bug-guile@gnu.org; Sat, 19 Sep 2020 15:35:30 -0400 Original-Received: from trouble.defaultvalue.org (localhost [127.0.0.1]) (Authenticated sender: rlb@defaultvalue.org) by defaultvalue.org (Postfix) with ESMTPSA id 0FCC92008E for ; Sat, 19 Sep 2020 14:35:27 -0500 (CDT) Original-Received: by trouble.defaultvalue.org (Postfix, from userid 1000) id 9A8E614E072; Sat, 19 Sep 2020 14:35:26 -0500 (CDT) In-Reply-To: <87ft7d601y.fsf@trouble.defaultvalue.org> Received-SPF: pass client-ip=45.33.119.55; envelope-from=rlb@defaultvalue.org; helo=defaultvalue.org X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/19 15:25:46 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guile-bounces+guile-bugs=m.gmane-mx.org@gnu.org Original-Sender: "bug-guile" Xref: news.gmane.io gmane.lisp.guile.bugs:9888 Archived-At: Rob Browning writes: > I believe the problem is that if the gc doesn't collect the port when > the test calls (gc), then the test (which recognizes that possibility) > calls close-fdes on the underlying fd. However, the port still exists, > and it may be garbage collected later, during a test that's using the > same fd, which may break that test. ...and I'd have to think about it more carefully, but if dropping the close-fdes call would completely prevent any subsequent test from re-using the fd unsafely before the lingering port is collected, then perhaps that's one potential fix. -- Rob Browning rlb @defaultvalue.org and @debian.org GPG as of 2011-07-10 E6A9 DA3C C9FD 1FF8 C676 D2C4 C0F0 39E9 ED1B 597A GPG as of 2002-11-03 14DD 432F AE39 534D B592 F9A0 25C8 D377 8C7E 73A4