From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Newsgroups: gmane.lisp.guile.bugs Subject: bug#57567: =?UTF-8?Q?=E2=80=98primitive-load=E2=80=99?= should open files with O_CLOEXEC Date: Wed, 07 Sep 2022 18:03:16 +0200 Message-ID: <87czc7qiij.fsf@gnu.org> References: <877d2ktg6b.fsf@inria.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27131"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) To: 57567-done@debbugs.gnu.org Original-X-From: bug-guile-bounces+guile-bugs=m.gmane-mx.org@gnu.org Wed Sep 07 18:14:11 2022 Return-path: Envelope-to: guile-bugs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oVxgp-0006lT-9H for guile-bugs@m.gmane-mx.org; Wed, 07 Sep 2022 18:14:11 +0200 Original-Received: from localhost ([::1]:41966 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oVxgn-0004SO-TK for guile-bugs@m.gmane-mx.org; Wed, 07 Sep 2022 12:14:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60188) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oVxX0-0007Ap-RC for bug-guile@gnu.org; Wed, 07 Sep 2022 12:04:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38972) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oVxX0-00063H-C8 for bug-guile@gnu.org; Wed, 07 Sep 2022 12:04:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oVxWz-00041o-SL for bug-guile@gnu.org; Wed, 07 Sep 2022 12:04:01 -0400 Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-To: bug-guile@gnu.org Resent-Date: Wed, 07 Sep 2022 16:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 57567 X-GNU-PR-Package: guile Mail-Followup-To: 57567@debbugs.gnu.org, ludo@gnu.org, ludo@gnu.org Original-Received: via spool by 57567-done@debbugs.gnu.org id=D57567.166256661015439 (code D ref 57567); Wed, 07 Sep 2022 16:04:01 +0000 Original-Received: (at 57567-done) by debbugs.gnu.org; 7 Sep 2022 16:03:30 +0000 Original-Received: from localhost ([127.0.0.1]:55904 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVxWR-00040u-8s for submit@debbugs.gnu.org; Wed, 07 Sep 2022 12:03:30 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:43288) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVxWP-00040f-0n for 57567-done@debbugs.gnu.org; Wed, 07 Sep 2022 12:03:25 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:48766) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oVxWJ-0005r6-Pa for 57567-done@debbugs.gnu.org; Wed, 07 Sep 2022 12:03:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=h+WqiPqTtmtQSThiF5ikZ/A795njicDiwY25MYLdj0g=; b=XNzmeSON5xtFr5ZGw3nR 1w69MTJ4mPRcv8dI5b0qC2S1IC2ttBIteGGXKeCRjEsKdr5gOOtEpTgI6n8MZwo4NgMH9uCIVMu1r ChMlFQm3v3u2bJwE7weJ+2VKDor3rwlJVAGzja2m/gUaCxifxrIyunispQiBggqOHcMri53ZYwHHl hlFhtfIhnTyK4bdDHWBZ7Kfh6ZCFwIFjc8JC7PZtcOnlXiixwcy63zpFWraPt84eSpbG7y7o8om4q EK9Ja0lxLTgiM0KgCHhGa5nHEL/Buub+XGgqDXeUvK4xKN7egPdYt20Xdp+b5uFJyNiiA0UAE8YRF QfNABD78TjSojA==; Original-Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:55920 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oVxWJ-0006Gu-8u for 57567-done@debbugs.gnu.org; Wed, 07 Sep 2022 12:03:19 -0400 In-Reply-To: <877d2ktg6b.fsf@inria.fr> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Sat, 03 Sep 2022 21:24:12 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guile-bounces+guile-bugs=m.gmane-mx.org@gnu.org Original-Sender: "bug-guile" Xref: news.gmane.io gmane.lisp.guile.bugs:10368 Archived-At: Ludovic Court=C3=A8s skribis: > Currently =E2=80=98primitive-load=E2=80=99 opens files without O_CLOEXEC: > > port =3D scm_open_file_with_encoding (filename, > scm_from_latin1_string ("r"), > SCM_BOOL_T, /* guess_encoding */ > scm_from_latin1_string ("UTF-8")); [...] > For a proper fix, one possibility would be to first augment > =E2=80=98scm_i_mode_to_open_flags=E2=80=99 to recognize some letter for O= _CLOEXEC. In > glibc, fopen(3) uses =E2=80=9Ce=E2=80=9D for that. I went ahead and did that: 0aa1a9976 'primitive-load' opens files with O_CLOEXEC. a356ceebe Add support for "e" flag (O_CLOEXEC) to 'open-file'. Ludo=E2=80=99.