From: "Ludovic Courtès" <ludo@gnu.org>
To: Ekaitz Zarraga <ekaitz@elenq.tech>
Cc: 73188@debbugs.gnu.org
Subject: bug#73188: PEG parser does not support full PEG grammar
Date: Sun, 13 Oct 2024 22:29:39 +0200 [thread overview]
Message-ID: <87cyk3rbkc.fsf_-_@gnu.org> (raw)
In-Reply-To: <20240912205751.23724-1-ekaitz@elenq.tech> (Ekaitz Zarraga's message of "Thu, 12 Sep 2024 22:57:22 +0200")
Hi Ekaitz,
Ekaitz Zarraga <ekaitz@elenq.tech> skribis:
> This commit adds support for PEG as described in:
>
> <https://bford.info/pub/lang/peg.pdf>
I would make this a comment below the ‘define-module’ form.
> It adds support for the missing features (comments, underscores in
> identifiers and escaping) while keeping the extensions (dashes in
> identifiers, < and <--).
>
> The naming system tries to be as close as possible to the one proposed
> in the paper.
>
> * module/ice-9/peg/string-peg.scm: Rewrite PEG parser.
> * test-suite/tests/peg.test: Fix import
Nice work!
Questions:
1. Is the name change for lexical elements (camel case instead of
lower-case + hyphens) user-visible? I guess no but better be safe
than sorry.
I have a preference for lower-case + hyphens out of consistency
with the rest of Scheme, but I can see how keeping the same names
as in the reference material helps.
2. Could you add tests for the missing features that this adds, and
maybe extend ‘api-peg.texi’ accordingly too?
3. You can choose to assign copyright to the FSF or to not do that¹.
In the latter case, please add a copyright line for you where
appropriate.
I’m really not a PEG expert though so I’d prefer more eyeballs here, but
I trust your judgment.
There are three (guix import *) modules that use (ice-9 peg) and that
come with tests. It would be nice to check that those tests still pass
with the modified string-peg.scm.
Thanks!
Ludo’.
¹ https://lists.gnu.org/archive/html/guile-devel/2022-10/msg00008.html
next prev parent reply other threads:[~2024-10-13 20:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-11 22:03 bug#73188: PEG parser does not support full PEG grammar Ekaitz Zarraga
2024-09-12 20:57 ` bug#73188: [PATCH v2] PEG: Add full support for PEG + some extensions Ekaitz Zarraga
2024-10-13 20:29 ` Ludovic Courtès [this message]
2024-10-13 20:59 ` bug#73188: PEG parser does not support full PEG grammar Ekaitz Zarraga
2024-10-14 11:56 ` Ludovic Courtès
2024-10-14 14:00 ` Ekaitz Zarraga
2024-10-11 12:31 ` bug#73188: [PATCH] PEG: Add support for `not-in-range` and [^...] Ekaitz Zarraga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cyk3rbkc.fsf_-_@gnu.org \
--to=ludo@gnu.org \
--cc=73188@debbugs.gnu.org \
--cc=ekaitz@elenq.tech \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).