unofficial mirror of bug-guile@gnu.org 
 help / color / mirror / Atom feed
* pedantic stuff: C++ comments in 1.8.0
@ 2006-02-28  3:24 Mike Gran
  2006-03-03  8:28 ` Ludovic Courtès
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Mike Gran @ 2006-02-28  3:24 UTC (permalink / raw)


There are some C++-style comments in 1.8.0.

*** posix.c	Mon Feb 27 18:38:55 2006
--- posix.c.0	Mon Feb 27 18:29:56 2006
***************
*** 1877,1883 ****
      {
        const int save_errno = errno;
  
!       /* No guile exceptions can occur before we have freed p's
memory. */
        scm_dynwind_end ();
        free (p);
  
--- 1877,1883 ----
      {
        const int save_errno = errno;
  
!       // No guile exceptions can occur before we have freed p's
memory.
        scm_dynwind_end ();
        free (p);
  
***************
*** 1889,1895 ****
        /* scm_from_locale_string may throw an exception.  */
        const SCM name = scm_from_locale_string (p);
  
!       /* No guile exceptions can occur before we have freed p's
memory. */
        scm_dynwind_end ();
        free (p);
  
--- 1889,1895 ----
        /* scm_from_locale_string may throw an exception.  */
        const SCM name = scm_from_locale_string (p);
  
!       // No guile exceptions can occur before we have freed p's
memory.
        scm_dynwind_end ();
        free (p);

*** eval.c	Mon Feb 27 16:26:17 2006
--- eval.c.0	Mon Feb 27 16:24:57 2006
***************
*** 5695,5702 ****
   * hare-and-tortoise implementation, found several times in guile. 
*/
  
  struct t_trace {
!   struct t_trace *trace;  /* These pointers form a trace along the
stack. */
!   SCM obj;                /* The object handled at the respective
stack frame.*/
  };
  
  static SCM
--- 5695,5702 ----
   * hare-and-tortoise implementation, found several times in guile. 
*/
  
  struct t_trace {
!   struct t_trace *trace;  // These pointers form a trace along the
stack.
!   SCM obj;                // The object handled at the respective
stack frame.
  };
  
  static SCM
***************
*** 5751,5757 ****
  
            return new_vector;
          }
!       else /* scm_is_pair (hare->obj) */
          {
            SCM result;
            SCM tail;
--- 5751,5757 ----
  
            return new_vector;
          }
!       else // scm_is_pair (hare->obj)
          {
            SCM result;
            SCM tail;
  


__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com 


_______________________________________________
Bug-guile mailing list
Bug-guile@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-guile


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: pedantic stuff: C++ comments in 1.8.0
  2006-02-28  3:24 pedantic stuff: C++ comments in 1.8.0 Mike Gran
@ 2006-03-03  8:28 ` Ludovic Courtès
  2006-03-03  8:52 ` Neil Jerram
  2006-03-03 23:57 ` Kevin Ryde
  2 siblings, 0 replies; 4+ messages in thread
From: Ludovic Courtès @ 2006-03-03  8:28 UTC (permalink / raw)
  Cc: bug-guile

Hi,

Mike Gran <spk121@yahoo.com> writes:

> There are some C++-style comments in 1.8.0.

Good catch (but note that it's also allowed by C99).  But after all,
it's not so pedantic: GCC < 3 uses C89 by default and does not recognize
such comments, and some proprietary compilers certainly don't recognize
it either ``out of the box''.

Could you resend your patch as a unified diff, i.e., using `diff -u'?
Also, make sure the original file (e.g., `posix.c.0') appears first on
the command line.

Thanks,
Ludovic.


_______________________________________________
Bug-guile mailing list
Bug-guile@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-guile


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: pedantic stuff: C++ comments in 1.8.0
  2006-02-28  3:24 pedantic stuff: C++ comments in 1.8.0 Mike Gran
  2006-03-03  8:28 ` Ludovic Courtès
@ 2006-03-03  8:52 ` Neil Jerram
  2006-03-03 23:57 ` Kevin Ryde
  2 siblings, 0 replies; 4+ messages in thread
From: Neil Jerram @ 2006-03-03  8:52 UTC (permalink / raw)
  Cc: bug-guile

Mike Gran <spk121@yahoo.com> writes:

> There are some C++-style comments in 1.8.0.

Thanks.  I'll apply your patch when I get time at the weekend, if no
one else does it first.

    Neil



_______________________________________________
Bug-guile mailing list
Bug-guile@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-guile


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: pedantic stuff: C++ comments in 1.8.0
  2006-02-28  3:24 pedantic stuff: C++ comments in 1.8.0 Mike Gran
  2006-03-03  8:28 ` Ludovic Courtès
  2006-03-03  8:52 ` Neil Jerram
@ 2006-03-03 23:57 ` Kevin Ryde
  2 siblings, 0 replies; 4+ messages in thread
From: Kevin Ryde @ 2006-03-03 23:57 UTC (permalink / raw)
  Cc: bug-guile

Mike Gran <spk121@yahoo.com> writes:
>
> There are some C++-style comments in 1.8.0.

Thanks, I applied that fix.


_______________________________________________
Bug-guile mailing list
Bug-guile@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-guile


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2006-03-03 23:57 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-02-28  3:24 pedantic stuff: C++ comments in 1.8.0 Mike Gran
2006-03-03  8:28 ` Ludovic Courtès
2006-03-03  8:52 ` Neil Jerram
2006-03-03 23:57 ` Kevin Ryde

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).