From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Newsgroups: gmane.lisp.guile.bugs Subject: bug#19883: Correction for backtrace Date: Thu, 23 Jun 2016 15:12:34 +0200 Message-ID: <87a8icoxq5.fsf@gnu.org> References: <87twyln70f.fsf@fencepost.gnu.org> <873865n2rr.fsf@fencepost.gnu.org> <87twy91vtc.fsf@gnu.org> <878ufld1iw.fsf@fencepost.gnu.org> <87k2z4dhx7.fsf@gnu.org> <874mq8dfb3.fsf@fencepost.gnu.org> <87fv9sahxx.fsf@gnu.org> <87wq34bsh7.fsf@fencepost.gnu.org> <87fus4p72f.fsf@pobox.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1466687613 28709 80.91.229.3 (23 Jun 2016 13:13:33 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 23 Jun 2016 13:13:33 +0000 (UTC) Cc: 19883@debbugs.gnu.org, David Kastrup To: Andy Wingo Original-X-From: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Thu Jun 23 15:13:16 2016 Return-path: Envelope-to: guile-bugs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bG4RX-0001gk-4k for guile-bugs@m.gmane.org; Thu, 23 Jun 2016 15:13:15 +0200 Original-Received: from localhost ([::1]:36709 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bG4RW-0005Eq-4v for guile-bugs@m.gmane.org; Thu, 23 Jun 2016 09:13:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37605) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bG4RN-0005Dg-Px for bug-guile@gnu.org; Thu, 23 Jun 2016 09:13:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bG4RK-0004wG-Ix for bug-guile@gnu.org; Thu, 23 Jun 2016 09:13:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:39593) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bG4RK-0004vx-FW for bug-guile@gnu.org; Thu, 23 Jun 2016 09:13:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bG4RK-0001Bt-CV for bug-guile@gnu.org; Thu, 23 Jun 2016 09:13:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Thu, 23 Jun 2016 13:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19883 X-GNU-PR-Package: guile X-GNU-PR-Keywords: Original-Received: via spool by 19883-submit@debbugs.gnu.org id=B19883.14666875694557 (code B ref 19883); Thu, 23 Jun 2016 13:13:02 +0000 Original-Received: (at 19883) by debbugs.gnu.org; 23 Jun 2016 13:12:49 +0000 Original-Received: from localhost ([127.0.0.1]:51930 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bG4R6-0001BR-TQ for submit@debbugs.gnu.org; Thu, 23 Jun 2016 09:12:49 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:46548) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bG4R4-0001BE-Uy for 19883@debbugs.gnu.org; Thu, 23 Jun 2016 09:12:47 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bG4Qv-0004kN-Ud for 19883@debbugs.gnu.org; Thu, 23 Jun 2016 09:12:41 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:35264) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bG4Qv-0004k6-Rd; Thu, 23 Jun 2016 09:12:37 -0400 Original-Received: from pluto.bordeaux.inria.fr ([193.50.110.57]:52120 helo=pluto) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bG4Qu-0002Ay-Mi; Thu, 23 Jun 2016 09:12:37 -0400 X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 6 Messidor an 224 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-unknown-linux-gnu In-Reply-To: <87fus4p72f.fsf@pobox.com> (Andy Wingo's message of "Thu, 23 Jun 2016 11:50:48 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Original-Sender: "bug-guile" Xref: news.gmane.org gmane.lisp.guile.bugs:8157 Archived-At: Andy Wingo skribis: > On Thu 26 Feb 2015 16:30, David Kastrup writes: > >> Try ./test 2 2000 200 > > I can reproduce the crash with your test case, thanks :) The patch below > fixes the bug for me. WDYT Ludovic? > > Andy > > commit db30120fc3a1727d8f221cbb014314f2babf841e > Author: Andy Wingo > Date: Thu Jun 23 11:47:42 2016 +0200 > > Fix race between SMOB marking and finalization >=20=20=20=20=20 > * libguile/smob.c (clear_smobnum): New helper. > (finalize_smob): Re-set the smobnum to the "finalized smob" type > before finalizing. Fixes #19883. > (scm_smob_prehistory): Pre-register a "finalized smob" type, which = has > no mark procedure. This LGTM, nice hack! Do you think the test case could be added to the test suite somehow? Thank you, Ludo=E2=80=99.