From: ludo@gnu.org (Ludovic Courtès)
To: Andy Wingo <wingo@pobox.com>
Cc: 19883@debbugs.gnu.org, David Kastrup <dak@gnu.org>
Subject: bug#19883: Correction for backtrace
Date: Thu, 23 Jun 2016 15:12:34 +0200 [thread overview]
Message-ID: <87a8icoxq5.fsf@gnu.org> (raw)
In-Reply-To: <87fus4p72f.fsf@pobox.com> (Andy Wingo's message of "Thu, 23 Jun 2016 11:50:48 +0200")
Andy Wingo <wingo@pobox.com> skribis:
> On Thu 26 Feb 2015 16:30, David Kastrup <dak@gnu.org> writes:
>
>> Try ./test 2 2000 200
>
> I can reproduce the crash with your test case, thanks :) The patch below
> fixes the bug for me. WDYT Ludovic?
>
> Andy
>
> commit db30120fc3a1727d8f221cbb014314f2babf841e
> Author: Andy Wingo <wingo@pobox.com>
> Date: Thu Jun 23 11:47:42 2016 +0200
>
> Fix race between SMOB marking and finalization
>
> * libguile/smob.c (clear_smobnum): New helper.
> (finalize_smob): Re-set the smobnum to the "finalized smob" type
> before finalizing. Fixes #19883.
> (scm_smob_prehistory): Pre-register a "finalized smob" type, which has
> no mark procedure.
This LGTM, nice hack!
Do you think the test case could be added to the test suite somehow?
Thank you,
Ludo’.
next prev parent reply other threads:[~2016-06-23 13:12 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87mvieh7mu.fsf@gnu.org>
2015-02-16 16:41 ` bug#19883: Smob's mark_smob has become unreliable in Guile 2.x David Kastrup
2015-02-16 18:13 ` bug#19883: Correction for backtrace David Kastrup
2015-02-25 22:16 ` Ludovic Courtès
2015-02-25 23:17 ` David Kastrup
2015-02-26 11:35 ` Ludovic Courtès
2015-02-26 12:32 ` David Kastrup
2015-02-26 14:03 ` Ludovic Courtès
2015-02-26 15:30 ` David Kastrup
2015-02-26 18:15 ` Ludovic Courtès
2015-02-26 19:25 ` David Kastrup
2015-02-27 9:55 ` Ludovic Courtès
2015-02-27 10:18 ` David Kastrup
2016-06-23 9:50 ` Andy Wingo
2016-06-23 10:36 ` Andy Wingo
2016-06-23 13:13 ` Ludovic Courtès
2016-06-23 13:12 ` Ludovic Courtès [this message]
2015-03-01 6:51 ` bug#19883: Smob's mark_smob has become unreliable in Guile 2.x Mark H Weaver
2015-03-01 10:09 ` David Kastrup
2015-03-01 17:02 ` Mark H Weaver
2015-03-01 18:38 ` David Kastrup
2015-03-01 15:00 ` David Kastrup
2016-10-09 7:51 ` bug#19883: The “finalized” SMOB type Artyom Poptsov
[not found] ` <87vax2klj6.fsf@elephant.savannah>
[not found] ` <87fuo5hc88.fsf@gnu.org>
2016-10-09 19:00 ` Artyom Poptsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a8icoxq5.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=19883@debbugs.gnu.org \
--cc=dak@gnu.org \
--cc=wingo@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).