From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Mark H Weaver Newsgroups: gmane.lisp.guile.bugs Subject: bug#21883: unnecessary bit shifting range limits Date: Sun, 14 Oct 2018 18:19:36 -0400 Message-ID: <87a7ngtblz.fsf@netris.org> References: <20151112070725.GA875@fysh.org> <87tvlpszzu.fsf@netris.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1539555489 1144 195.159.176.226 (14 Oct 2018 22:18:09 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 14 Oct 2018 22:18:09 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Cc: 21883@debbugs.gnu.org, Zefram To: Stefan Israelsson Tampe Original-X-From: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Mon Oct 15 00:18:05 2018 Return-path: Envelope-to: guile-bugs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gBoi3-0000B4-Ka for guile-bugs@m.gmane.org; Mon, 15 Oct 2018 00:18:03 +0200 Original-Received: from localhost ([::1]:49679 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gBokA-00078p-1j for guile-bugs@m.gmane.org; Sun, 14 Oct 2018 18:20:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49099) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gBok3-00077Z-5u for bug-guile@gnu.org; Sun, 14 Oct 2018 18:20:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gBojy-0000Yc-8A for bug-guile@gnu.org; Sun, 14 Oct 2018 18:20:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45397) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gBojy-0000YU-4Q for bug-guile@gnu.org; Sun, 14 Oct 2018 18:20:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gBojx-0004CD-Oz for bug-guile@gnu.org; Sun, 14 Oct 2018 18:20:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mark H Weaver Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Sun, 14 Oct 2018 22:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21883 X-GNU-PR-Package: guile X-GNU-PR-Keywords: Original-Received: via spool by 21883-submit@debbugs.gnu.org id=B21883.153955559816114 (code B ref 21883); Sun, 14 Oct 2018 22:20:01 +0000 Original-Received: (at 21883) by debbugs.gnu.org; 14 Oct 2018 22:19:58 +0000 Original-Received: from localhost ([127.0.0.1]:49655 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gBoju-0004Bp-7s for submit@debbugs.gnu.org; Sun, 14 Oct 2018 18:19:58 -0400 Original-Received: from world.peace.net ([64.112.178.59]:47562) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gBojs-0004BW-LY for 21883@debbugs.gnu.org; Sun, 14 Oct 2018 18:19:56 -0400 Original-Received: from mhw by world.peace.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1gBojm-0006qq-TA; Sun, 14 Oct 2018 18:19:51 -0400 In-Reply-To: (Stefan Israelsson Tampe's message of "Sun, 14 Oct 2018 11:46:12 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Original-Sender: "bug-guile" Xref: news.gmane.org gmane.lisp.guile.bugs:9190 Archived-At: Stefan Israelsson Tampe writes: > how would this slow down the code. just add the correction where you > throw the exception which should be in a branch outside the hot path. If you have a suggestion that's simpler than what I did in commits 011aec7e, 9448a078, and 1990aa91, and just as fast in the common cases, feel free to propose a patch. The words above are insufficient. Mark