From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Mark H Weaver Newsgroups: gmane.lisp.guile.bugs Subject: bug#29520: peval leaves behind dangling lexical reference Date: Mon, 04 Dec 2017 21:55:21 -0500 Message-ID: <878tehvq7a.fsf@netris.org> References: <87shcrxyat.fsf@netris.org> <87mv2zxqym.fsf@netris.org> <878tejxd76.fsf@netris.org> <87wp22w66v.fsf@netris.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1512442572 28526 195.159.176.226 (5 Dec 2017 02:56:12 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 5 Dec 2017 02:56:12 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) Cc: 29520@debbugs.gnu.org To: Stefan Israelsson Tampe Original-X-From: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Tue Dec 05 03:56:08 2017 Return-path: Envelope-to: guile-bugs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eM3Ox-00079Q-As for guile-bugs@m.gmane.org; Tue, 05 Dec 2017 03:56:07 +0100 Original-Received: from localhost ([::1]:46122 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eM3P4-0000GQ-K3 for guile-bugs@m.gmane.org; Mon, 04 Dec 2017 21:56:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49580) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eM3Ox-0000GI-Er for bug-guile@gnu.org; Mon, 04 Dec 2017 21:56:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eM3Os-0003pt-JK for bug-guile@gnu.org; Mon, 04 Dec 2017 21:56:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:37540) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eM3Os-0003pn-G4 for bug-guile@gnu.org; Mon, 04 Dec 2017 21:56:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eM3Os-000441-3d for bug-guile@gnu.org; Mon, 04 Dec 2017 21:56:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Mark H Weaver Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Tue, 05 Dec 2017 02:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29520 X-GNU-PR-Package: guile X-GNU-PR-Keywords: Original-Received: via spool by 29520-submit@debbugs.gnu.org id=B29520.151244254715601 (code B ref 29520); Tue, 05 Dec 2017 02:56:02 +0000 Original-Received: (at 29520) by debbugs.gnu.org; 5 Dec 2017 02:55:47 +0000 Original-Received: from localhost ([127.0.0.1]:46221 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eM3Od-00043Z-BI for submit@debbugs.gnu.org; Mon, 04 Dec 2017 21:55:47 -0500 Original-Received: from world.peace.net ([50.252.239.5]:36854) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eM3Oc-00043M-4O for 29520@debbugs.gnu.org; Mon, 04 Dec 2017 21:55:46 -0500 Original-Received: from pool-72-93-29-217.bstnma.east.verizon.net ([72.93.29.217] helo=jojen) by world.peace.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1eM3OV-00025j-So; Mon, 04 Dec 2017 21:55:40 -0500 In-Reply-To: <87wp22w66v.fsf@netris.org> (Mark H. Weaver's message of "Mon, 04 Dec 2017 16:10:00 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Original-Sender: "bug-guile" Xref: news.gmane.org gmane.lisp.guile.bugs:8927 Archived-At: Mark H Weaver writes: > It occurs to me that there's another problem with this optimization: > > scheme@(guile-user)> ,optimize (lambda (x y . z) (apply (lambda x x) x y z)) > $1 = (lambda x x) > > This optimization changes the arity of the procedure. The original > version checks that at least 2 arguments are provided, and ensures that > at least 2 arguments are passed to the inner procedure, which the code > might depend on. The optimization effectively removes this check. Here's an updated patch that fixes both issues. Mark diff --git a/module/language/tree-il/peval.scm b/module/language/tree-il/peval.scm index 993fa0ad6..13b7d9bc4 100644 --- a/module/language/tree-il/peval.scm +++ b/module/language/tree-il/peval.scm @@ -1585,11 +1585,15 @@ top-level bindings from ENV and return the resulting expression." (and (not opt) rest (not kw) (match body (($ _ 'apply - (($ _ _ (and lcase ($ ))) + (($ _ _ (and lcase ($ _ req1))) ($ _ _ sym) ...)) (and (equal? sym gensyms) (not (lambda-case-alternate lcase)) + (<= (length req) (length req1)) + (every (lambda (s) + (= (lexical-refcount s) 1)) + sym) lcase)) (_ #f)))) (let* ((vars (map lookup-var gensyms))