From: "Ludovic Courtès" <ludo@gnu.org>
To: Stefan Israelsson Tampe <stefan.itampe@gmail.com>
Cc: 39361@debbugs.gnu.org
Subject: bug#39361: continuation and gc performance
Date: Sat, 21 Mar 2020 18:33:41 +0100 [thread overview]
Message-ID: <878sjtzk7e.fsf@gnu.org> (raw)
In-Reply-To: <CAGua6m31eJUXj_B-2AoNkarvzjat9dYVd-HD3pEyjz5=RYmbeQ@mail.gmail.com> (Stefan Israelsson Tampe's message of "Thu, 30 Jan 2020 22:10:50 +0100")
Hi Stefan,
Stefan Israelsson Tampe <stefan.itampe@gmail.com> skribis:
> I think I found a gc leak in guile 3.0
>
> Isn't it so that so the continuation keep a copy of the stack. The issue is
> that in the stack a raw integer or float may be present and so the gc
> properties is less then ideal as those may be interpreted as pointers by
> the GC and lead to parts of the heap being kept from garnage collecting.
>
> The information about a slot being a raw value or a scm value is
> available as we do the correct gc updating of the stack inside guile 3.0.
> May I propose that we add a bitvector to the continuation that indicate
> that if a lslot is raw or not. Then add a pass that collect the rawness
> information in the creation of the closure. Finally a custom made mark
> procedure for closures can be made that uses all this information to make
> sure to mark only scm slots in the stored continuation therby improving gc
> perfromance.
I believe what you describe is already what happens in
‘scm_i_vm_mark_stack’. Or am I missing something?
Thanks,
Ludo’.
next prev parent reply other threads:[~2020-03-21 17:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAGua6m1DQ+=VoypegHmcAELrHVb-s=DymVv6nMJQoj7aN9=EuA@mail.gmail.com>
2020-01-30 21:10 ` bug#39361: continuation and gc performance Stefan Israelsson Tampe
2020-03-21 17:33 ` Ludovic Courtès [this message]
2020-03-21 20:43 ` Stefan Israelsson Tampe
2020-03-22 20:51 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878sjtzk7e.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=39361@debbugs.gnu.org \
--cc=stefan.itampe@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).