From: "Ludovic Courtès" <ludo@gnu.org>
To: 47031@debbugs.gnu.org
Subject: bug#47031: False positives for ‘-Wunbound-variable’ in 3.0.5
Date: Sat, 01 May 2021 22:34:32 +0200 [thread overview]
Message-ID: <878s4y6vmv.fsf@gnu.org> (raw)
In-Reply-To: <87im606kes.fsf@inria.fr> ("Ludovic Courtès"'s message of "Tue, 09 Mar 2021 23:18:19 +0100")
[-- Attachment #1: Type: text/plain, Size: 533 bytes --]
Hello!
Ludovic Courtès <ludo@gnu.org> skribis:
> $ cat /tmp/unbound.scm
> (use-modules (srfi srfi-35))
>
> (condition (&message (message "oh no!"))
> (&serious))
> $ guild compile -Wunbound-variable /tmp/unbound.scm
> /tmp/unbound.scm:3:0: warning: possibly unbound variable `make-compound-condition'
The problem was that ‘make-compound-condition’ is re-exported from (srfi
srfi-35) and this particular case was not handled.
The attached patch fixes it. Let me know what you think!
Ludo’.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 1714 bytes --]
diff --git a/module/language/tree-il/analyze.scm b/module/language/tree-il/analyze.scm
index 766568f38..4b53e426f 100644
--- a/module/language/tree-il/analyze.scm
+++ b/module/language/tree-il/analyze.scm
@@ -510,6 +510,11 @@ given `tree-il' element."
;; The variable is an import. At the time of use, the
;; name is bound to the import.
'import)
+ ((and=> (module-public-interface mod)
+ (lambda (interface)
+ (module-variable interface name)))
+ ;; The variable is re-exported from module.
+ 'import)
(else
;; Variable unbound in the module.
'unbound))))))
diff --git a/test-suite/tests/tree-il.test b/test-suite/tests/tree-il.test
index 217a1000f..262c2454d 100644
--- a/test-suite/tests/tree-il.test
+++ b/test-suite/tests/tree-il.test
@@ -557,6 +557,19 @@
#:env m
#:opts %opts-w-unbound))))))))
+ (pass-if "macro-inserted binding"
+ (null? (call-with-warnings
+ (lambda ()
+ (compile '(begin
+ (use-modules (srfi srfi-35))
+
+ ;; This 'condition' form expands to a
+ ;; 'make-compound-condition' call, which is
+ ;; re-exported from (ice-9 exceptions).
+ (condition (&error)
+ (&message (message "oh!"))))
+ #:opts %opts-w-unbound)))))
+
(with-test-prefix "use-before-definition"
(define-syntax-rule (pass-if-warnings expr pat test)
(pass-if 'expr
next prev parent reply other threads:[~2021-05-01 20:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-09 22:18 bug#47031: False positives for ‘-Wunbound-variable’ in 3.0.5 Ludovic Courtès
2021-05-01 20:34 ` Ludovic Courtès [this message]
2021-05-01 23:26 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878s4y6vmv.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=47031@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).