tk-stack-mark

tk-stack-mark

[Daniel Ridge]

Bug in ice-9/boot-9.scm:save-stack ?

I notice that save-stack references tk-stack-mark which does not  
appear to exist or to be the obvious transposition of any existing  
symbol name.

My uninformed intuition is that tk-stack-mark is brought in by some  
optional package not shipped by default with Guile (perhaps guile-tk?).

I never cause this bug, but I do check my Scheme system with a semi- 
static analysis that complains about tk-stack-mark being undefined and  
I would prefer not to special-case a rule for save-stack. Perhaps all  
interests could be served by:

...
((tk-stack)
    (apply make-stack #t save-stack (if (defined? 'tk-stack-mark) tk- 
stack-mark (stack-id #t)) #t 0 narrowing)
...

or by some cond-expand foo or by outright banishment of this case?

Thanks,
	Dan

Re: tk-stack-mark

[Ludovic Courtès]

Hello,

Daniel Ridge <dsridge@super.org> writes:

> I notice that save-stack references tk-stack-mark which does not
> appear to exist or to be the obvious transposition of any existing
> symbol name.

This has been fixed recently, after having been identified by
‘-Wunbound-variable’ in 1.9 (commit
b70f43e318b60f00776fae5580914f31937ec0d8).

Out of curiosity, which static analysis system did you use?

For 1.8, Guile-Lint works very well
(http://user42.tuxfamily.org/guile-lint/index.html); for 1.9, it
doesn’t, but the compiler has a few ‘-W’ switches to report similar
issues.

Thanks,
Ludo’.