From: Mark H Weaver <mhw@netris.org>
To: Nikita Karetnikov <nikita@karetnikov.org>
Cc: 14203-done@debbugs.gnu.org
Subject: bug#14203: Manual: 'my-or'; 'let' inside macros
Date: Sun, 14 Apr 2013 13:53:38 -0400 [thread overview]
Message-ID: <877gk53snx.fsf@tines.lan> (raw)
In-Reply-To: <87haj9ysvr.fsf@karetnikov.org> (Nikita Karetnikov's message of "Sun, 14 Apr 2013 20:33:12 +0400")
Nikita Karetnikov <nikita@karetnikov.org> writes:
> I think this example [1,2]:
>
> (define-syntax my-or
> (syntax-rules ()
> ((my-or)
> #t)
> ((my-or exp)
> exp)
> ((my-or exp rest ...)
> (let ((t exp))
> (if exp
> exp
> (my-or rest ...))))))
>
> should look like this:
>
> (define-syntax my-or
> (syntax-rules ()
> ((my-or)
> #t)
> ((my-or exp)
> exp)
> ((my-or exp rest ...)
> (let ((t exp))
> (if t ; <-
> t
> (my-or rest ...))))))
Indeed, thanks! I've pushed this fix to the stable-2.0 branch, and am
closing this bug.
Answers to your other questions follow.
> AFAICT, it's described here [3], but Guile is not affected, right?
> [3] http://stackoverflow.com/a/3215238
That post gives an example that looks superficially similar, but is
actually entirely different:
(define remove!
(let ((null? null?)
(cdr cdr)
(eq? eq?))
(lambda ... function that uses null?, cdr, eq? ...)
Indeed, this is not necessary in Guile due to its module system.
> So the following works as well:
>
> (define-syntax my-or
> (syntax-rules ()
> ((my-or)
> #t)
> ((my-or exp)
> exp)
> ((my-or exp rest ...)
> (if exp
> exp
> (my-or rest ...)))))
The above definition has a problem: it would result in 'exp' being
evaluated more than once, unless it returns false.
For example, if you used your proposed definition above,
(my-or (read) 5) would expand to:
(if (read)
(read)
5)
Which would obviously not do what you expect from 'or'. Instead, we
want:
(let ((t (read)))
(if t
t
5))
> Note that 'my-or' is used in several places (e.g., [4]) and it's
> necessary to change them all.
> [4] https://gnu.org/software/guile/manual/guile.html#Syntax-Case
Unless I'm mistaken, the Syntax-case section uses 'my-or', but does not
define it, so I don't think anything needs to be fixed there. Right?
Thanks,
Mark
prev parent reply other threads:[~2013-04-14 17:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-14 16:33 bug#14203: Manual: 'my-or'; 'let' inside macros Nikita Karetnikov
2013-04-14 17:53 ` Mark H Weaver [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877gk53snx.fsf@tines.lan \
--to=mhw@netris.org \
--cc=14203-done@debbugs.gnu.org \
--cc=nikita@karetnikov.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).