From: ludo@gnu.org (Ludovic Courtès)
To: 15540@debbugs.gnu.org
Subject: bug#15540: Circular module imports vs. #:select (2.0.9)
Date: Sun, 06 Oct 2013 21:36:42 +0200 [thread overview]
Message-ID: <877gdqqjhx.fsf@gnu.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 1108 bytes --]
Consider these two modules:
--8<---------------cut here---------------start------------->8---
(define-module (a) #:use-module (b) #:export (from-a))
(define from-a 1)
--8<---------------cut here---------------end--------------->8---
and:
--8<---------------cut here---------------start------------->8---
(define-module (b) #:use-module ((a) #:select (from-a)) #:export (from-b))
(define from-b 2)
--8<---------------cut here---------------end--------------->8---
This fails:
--8<---------------cut here---------------start------------->8---
scheme@(guile-user)> ,use(a)
While executing meta-command:
ERROR: no binding `from-a' in module (a)
--8<---------------cut here---------------end--------------->8---
whereas this succeeds (starting from a fresh Guile):
--8<---------------cut here---------------start------------->8---
scheme@(guile-user)> ,use(b)
scheme@(guile-user)> from-b
$1 = 2
--8<---------------cut here---------------end--------------->8---
Problem is that ‘define-module*’ processes exports after imports.
What about a patch along these lines:
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 1545 bytes --]
diff --git a/module/ice-9/boot-9.scm b/module/ice-9/boot-9.scm
index c825b35..24b8f4c 100644
--- a/module/ice-9/boot-9.scm
+++ b/module/ice-9/boot-9.scm
@@ -2872,11 +2872,8 @@ VALUE."
(error "expected list of integers for version"))
(set-module-version! module version)
(set-module-version! (module-public-interface module) version)))
- (let ((imports (resolve-imports imports)))
(call-with-deferred-observers
(lambda ()
- (if (pair? imports)
- (module-use-interfaces! module imports))
(if (list-of valid-export? exports)
(if (pair? exports)
(module-export! module exports))
@@ -2885,6 +2882,9 @@ VALUE."
(if (pair? replacements)
(module-replace! module replacements))
(error "expected replacements to be a list of symbols or symbol pairs"))
+ (let ((imports (resolve-imports module)))
+ (if (pair? imports)
+ (module-use-interfaces! module imports)))
(if (list-of valid-export? re-exports)
(if (pair? re-exports)
(module-re-export! module re-exports))
@@ -2896,7 +2896,7 @@ VALUE."
;; handlers.
(if (pair? duplicates)
(let ((handlers (lookup-duplicates-handlers duplicates)))
- (set-module-duplicates-handlers! module handlers))))))
+ (set-module-duplicates-handlers! module handlers)))))
(if transformer
(if (and (pair? transformer) (list-of symbol? transformer))
[-- Attachment #3: Type: text/plain, Size: 21 bytes --]
Thanks,
Ludo’.
next reply other threads:[~2013-10-06 19:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-06 19:36 Ludovic Courtès [this message]
2013-10-08 20:01 ` bug#15540: Circular module imports vs. #:select (2.0.9) Ian Price
2016-06-21 11:08 ` Andy Wingo
2017-02-28 10:50 ` Andy Wingo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877gdqqjhx.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=15540@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).