From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andy Wingo Newsgroups: gmane.lisp.guile.bugs Subject: bug#10109: [PATCH] (web http): list-style headers do not validate Date: Thu, 22 Dec 2011 08:21:06 -0500 Message-ID: <8762h8rbct.fsf@pobox.com> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1324560141 11910 80.91.229.12 (22 Dec 2011 13:22:21 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 22 Dec 2011 13:22:21 +0000 (UTC) Cc: 10109@debbugs.gnu.org To: Daniel Hartwig Original-X-From: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Thu Dec 22 14:22:15 2011 Return-path: Envelope-to: guile-bugs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Rdib2-0000Fw-C5 for guile-bugs@m.gmane.org; Thu, 22 Dec 2011 14:22:08 +0100 Original-Received: from localhost ([::1]:46269 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rdib1-0002iK-SM for guile-bugs@m.gmane.org; Thu, 22 Dec 2011 08:22:07 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:36369) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rdiat-0002hD-TS for bug-guile@gnu.org; Thu, 22 Dec 2011 08:22:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rdiam-0003m3-LL for bug-guile@gnu.org; Thu, 22 Dec 2011 08:21:59 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:48051) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rdiam-0003lz-JH for bug-guile@gnu.org; Thu, 22 Dec 2011 08:21:52 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1Rdics-00006Z-4Q for bug-guile@gnu.org; Thu, 22 Dec 2011 08:24:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Andy Wingo Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-guile@gnu.org Resent-Date: Thu, 22 Dec 2011 13:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10109 X-GNU-PR-Package: guile X-GNU-PR-Keywords: patch Original-Received: via spool by 10109-submit@debbugs.gnu.org id=B10109.1324560203356 (code B ref 10109); Thu, 22 Dec 2011 13:24:02 +0000 Original-Received: (at 10109) by debbugs.gnu.org; 22 Dec 2011 13:23:23 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RdicE-00005h-L5 for submit@debbugs.gnu.org; Thu, 22 Dec 2011 08:23:23 -0500 Original-Received: from a-pb-sasl-sd.pobox.com ([74.115.168.62] helo=sasl.smtp.pobox.com) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RdicC-00005Z-7f for 10109@debbugs.gnu.org; Thu, 22 Dec 2011 08:23:21 -0500 Original-Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by a-pb-sasl-sd.pobox.com (Postfix) with ESMTP id 9D0088247; Thu, 22 Dec 2011 08:21:09 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=leVpzjvNPEaukpErl7sgvh5vTQA=; b=MkIb6V PYDcxplfoEvxvKI5ZKjj2u7wtySWtV5C3oF5RkF3JytFP+he35CjZU86dvQ/9C5d EQRfBinKgznHrTcgjGgc8VHRr9QJMH0hTx5JyFImO82DeOGFP3rGdNdBOIqBVKTY qdpuu5dhQQJEkTHoNvaNpOCgvkTEuVYm8czd8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=OZBEN6xI7brIJsJuqB6JQUBcpT5OvYeA eoRMy+QpTokmAYEsdgITR4L/CjYY180h9DqGO3IXrgr40VGFRPpuFSipbzkb2bBl P8eEkN1NqVBeI5hVY/7FAuiGE3akYtCP6zmxwVy++O1O/Wm6oQRg/xVzX0Cv4rvq 2OHbqQDx4Ug= Original-Received: from a-pb-sasl-sd.pobox.com (unknown [127.0.0.1]) by a-pb-sasl-sd.pobox.com (Postfix) with ESMTP id 94FC08246; Thu, 22 Dec 2011 08:21:09 -0500 (EST) Original-Received: from badger (unknown [184.174.165.119]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by a-pb-sasl-sd.pobox.com (Postfix) with ESMTPSA id 5273D8244; Thu, 22 Dec 2011 08:21:08 -0500 (EST) In-Reply-To: (Daniel Hartwig's message of "Sun, 27 Nov 2011 23:11:08 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) X-Pobox-Relay-ID: CF180BFE-2C9F-11E1-BA72-65B1DE995924-02397024!a-pb-sasl-sd.pobox.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Thu, 22 Dec 2011 08:24:02 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Original-Sender: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.bugs:6008 Archived-At: On Sun 27 Nov 2011 10:11, Daniel Hartwig writes: > My apologies for not noticing earlier, but I have spotted a couple > minor issues with both the previous patch and original code that are > corrected by the attached. All relate to the "Cache-Control" header: > > - `max-stale' has optional value (previous code requires it) > - some directives do not have values (`no-store', etc.) > - there are `cache-extension' directives that may or may not have a value > > Attached patch tidies this up Thanks, it was a great patch. Applied and pushed. > with explicit validation of all defined > directives, though it leaves open one issue with the cache-extension > directives: I fixed this one, I think. Happy hacking, Andy -- http://wingolog.org/